Yiisoft\Yii\Sentry\Tracing\SentryWebTransactionAdapter

Complexity

Total Complexity

9

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	1	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setData()	0	5	1
A	getName()	0	3	1
A	commit()	0	11	3
A	setName()	0	5	1
A	__construct()	0	2	1
A	begin()	0	24	2

<?php

declare(strict_types=1);

namespace Yiisoft\Yii\Sentry\Tracing;

use Psr\Log\LoggerInterface;
use Sentry\SentrySdk;
use Sentry\Tracing\SpanContext;
use Sentry\Tracing\TransactionContext;

class SentryWebTransactionAdapter
{
    public function __construct(private LoggerInterface $logger, private SentryTraceMiddleware $middleware)
    {
    }

    public function begin(?string $sentryTraceString = null, string $baggage = ''): self
    {
        $hub = SentrySdk::getCurrentHub();
        if ($sentryTraceString) {
            $context = TransactionContext::fromHeaders($sentryTraceString, $baggage);
        } else {
            $context = new TransactionContext();
        }
        $context->setOp('web subtask');

        $context->setStartTimestamp(microtime(true));

It seems like microtime(true) can also be of type string; however, parameter $startTimestamp of Sentry\Tracing\SpanContext::setStartTimestamp() does only seem to accept double|null, maybe add an additional type check?

        $transaction = $hub->startTransaction($context);
        $transaction->setName('undefined action');
        $hub->setSpan($transaction);
        $this->middleware->setTransaction($transaction);

        $appContextStart = new SpanContext();
        $appContextStart->setOp('handle');
        $appContextStart->setStartTimestamp(microtime(true));
        $appSpan = $transaction->startChild($appContextStart);
        SentrySdk::getCurrentHub()->setSpan($appSpan);

        return $this;
    }

    public function setName(string $name): self
    {
        SentrySdk::getCurrentHub()->getTransaction()?->setName($name);

        return $this;
    }

    public function getName(): ?string
    {
        return SentrySdk::getCurrentHub()->getTransaction()?->getName();
    }

    /**
     * @param array<string, mixed> $data
     *
     * @return $this
     */
    public function setData(array $data): self
    {
        SentrySdk::getCurrentHub()->getTransaction()?->setData($data);

        return $this;
    }

    public function commit(): ?string
    {
        $this->logger->info('sentry force commit');
        $sentryTraceString = SentrySdk::getCurrentHub()->getSpan()?->toTraceparent();
        if (method_exists($this->logger, 'flush') && SentrySdk::getCurrentHub()->getTransaction() !== null) {
            $this->logger->flush(true);

The method flush() does not exist on Psr\Log\LoggerInterface. It seems like you code against a sub-type of Psr\Log\LoggerInterface such as Yiisoft\Log\Logger.

        }

        $this->middleware->terminate();

        return $sentryTraceString;
    }
}