RequestFactory::doParseBody() - Code Metrics - Inspection of "Add JSON support on parsing the request body + Fix..." - yiisoft/yii-runner-http - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#53)

unknown

created 2023-06-27 11:54 UTC

RequestFactory::doParseBody() B

↳ Parent: RequestFactory

Complexity

Conditions	9
Paths	7

Size

Total Lines	44
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	26
CRAP Score	9

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	9
eloc	25
c	1
b	0
f	0
nc	7
nop	3
dl	0
loc	44
ccs	26
cts	26
cp	1
crap	9
rs	8.0555

<?php

declare(strict_types=1);

namespace Yiisoft\Yii\Runner\Http;

use JsonException;
use Psr\Http\Message\ServerRequestFactoryInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\StreamFactoryInterface;
use Psr\Http\Message\StreamInterface;
use Psr\Http\Message\UploadedFileFactoryInterface;
use Psr\Http\Message\UriFactoryInterface;
use Psr\Http\Message\UriInterface;
use RuntimeException;
use Yiisoft\Yii\Runner\Http\Exception\BadRequestException;

use function array_key_exists;
use function explode;
use function fopen;
use function function_exists;
use function getallheaders;
use function in_array;
use function is_array;
use function preg_match;
use function str_replace;
use function strtolower;
use function substr;
use function ucwords;

/**
 * `ServerRequestCreator` creates an instance of a server request.
 *
 * @internal
 */
final class RequestFactory
{
    public function __construct(
        private ServerRequestFactoryInterface $serverRequestFactory,
        private UriFactoryInterface $uriFactory,
        private UploadedFileFactoryInterface $uploadedFileFactory,
        private StreamFactoryInterface $streamFactory,
    ) {
    }

    /**
     * Creates an instance of a server request from custom parameters.
     *
     * @param false|resource|null $body
     *
     * @return ServerRequestInterface The server request instance.
     */
    public function create($body = null): ServerRequestInterface
    {
        // Create base request
        $method = $_SERVER['REQUEST_METHOD'] ?? null;
        if ($method === null) {
            throw new RuntimeException('Unable to determine HTTP request method.');
        }
        $request = $this->serverRequestFactory->createServerRequest($method, $this->createUri(), $_SERVER);

        // Add headers
        foreach ($this->getHeaders() as $name => $value) {
            if ($name === 'Host' && $request->hasHeader('Host')) {
                continue;
            }
            $request = $request->withAddedHeader($name, $value);
        }

        // Add protocol
        $protocol = '1.1';
        if (array_key_exists('SERVER_PROTOCOL', $_SERVER) && $_SERVER['SERVER_PROTOCOL'] !== '') {
            $protocol = str_replace('HTTP/', '', $_SERVER['SERVER_PROTOCOL']);
        }
        $request = $request->withProtocolVersion($protocol);

        // Add body
        $body ??= fopen('php://input', 'rb');
        if ($body !== false) {
            $request = $request->withBody(
                $this->streamFactory->createStreamFromResource($body)
            );
        }

        // Add query and cookie params
        $request = $request
            ->withQueryParams($_GET)
            ->withCookieParams($_COOKIE);

        // Add uploaded files
        $files = [];
        foreach ($_FILES as $class => $info) {
            $files[$class] = [];
            $this->populateUploadedFileRecursive(
                $files[$class],
                $info['name'],
                $info['tmp_name'],
                $info['type'],
                $info['size'],
                $info['error'],
            );
        }
        $request = $request->withUploadedFiles($files);

        return $request;
    }

    /**
     * @throws BadRequestException
     */
    public function parseBody(ServerRequestInterface $request): ServerRequestInterface
    {
        $parsedBody = $this->doParseBody(
            $request->getMethod(),
            $request->getHeaderLine('content-type'),
            $request->getBody(),
        );

        return $parsedBody === null
            ? $request
            : $request->withParsedBody($parsedBody);
    }

    private function createUri(): UriInterface
    {
        $uri = $this->uriFactory->createUri();

        if (array_key_exists('HTTPS', $_SERVER) && $_SERVER['HTTPS'] !== '' && $_SERVER['HTTPS'] !== 'off') {
            $uri = $uri->withScheme('https');
        } else {
            $uri = $uri->withScheme('http');
        }

        $uri = isset($_SERVER['SERVER_PORT'])
            ? $uri->withPort((int) $_SERVER['SERVER_PORT'])
            : $uri->withPort($uri->getScheme() === 'https' ? 443 : 80);

        if (isset($_SERVER['HTTP_HOST'])) {
            $uri = preg_match('/^(.+):(\d+)$/', $_SERVER['HTTP_HOST'], $matches) === 1
                ? $uri
                    ->withHost($matches[1])
                    ->withPort((int) $matches[2])
                : $uri->withHost($_SERVER['HTTP_HOST']);
        } elseif (isset($_SERVER['SERVER_NAME'])) {
            $uri = $uri->withHost($_SERVER['SERVER_NAME']);
        }

        if (isset($_SERVER['REQUEST_URI'])) {
            $uri = $uri->withPath(explode('?', $_SERVER['REQUEST_URI'])[0]);
        }

        if (isset($_SERVER['QUERY_STRING'])) {
            $uri = $uri->withQuery($_SERVER['QUERY_STRING']);
        }

        return $uri;
    }

    /**
     * @psalm-return array<string, string>
     */
    private function getHeaders(): array
    {
        /** @psalm-var array<string, string> $_SERVER */

        if (function_exists('getallheaders') && ($headers = getallheaders()) !== false) {
            /** @psalm-var array<string, string> $headers */
            return $headers;

        }

        $headers = [];

        foreach ($_SERVER as $name => $value) {
            if (str_starts_with($name, 'REDIRECT_')) {
                $name = substr($name, 9);

                if (array_key_exists($name, $_SERVER)) {
                    continue;
                }
            }

            if (str_starts_with($name, 'HTTP_')) {
                $headers[$this->normalizeHeaderName(substr($name, 5))] = $value;
                continue;
            }

            if (str_starts_with($name, 'CONTENT_')) {
                $headers[$this->normalizeHeaderName($name)] = $value;
            }
        }

        return $headers;
    }

    private function normalizeHeaderName(string $name): string
    {
        return str_replace(' ', '-', ucwords(strtolower(str_replace('_', ' ', $name))));
    }

    /**
     * Populates uploaded files array from $_FILE data structure recursively.
     *
     * @param array $files Uploaded files array to be populated.
     * @param mixed $names File names provided by PHP.
     * @param mixed $tempNames Temporary file names provided by PHP.
     * @param mixed $types File types provided by PHP.
     * @param mixed $sizes File sizes provided by PHP.
     * @param mixed $errors Uploading issues provided by PHP.
     *
     * @psalm-suppress MixedArgument, ReferenceConstraintViolation
     */
    private function populateUploadedFileRecursive(
        array &$files,
        mixed $names,
        mixed $tempNames,
        mixed $types,
        mixed $sizes,
        mixed $errors
    ): void {
        if (is_array($names)) {
            /** @var array|string $name */
            foreach ($names as $i => $name) {
                $files[$i] = [];
                /** @psalm-suppress MixedArrayAccess */
                $this->populateUploadedFileRecursive(
                    $files[$i],
                    $name,
                    $tempNames[$i],
                    $types[$i],
                    $sizes[$i],
                    $errors[$i],
                );
            }

            return;
        }

        try {
            $stream = $this->streamFactory->createStreamFromFile($tempNames);
        } catch (RuntimeException) {
            $stream = $this->streamFactory->createStream();
        }

        $files = $this->uploadedFileFactory->createUploadedFile(
            $stream,
            (int) $sizes,
            (int) $errors,
            $names,
            $types
        );
    }

    /**
     * @throws BadRequestException
     */
    private function doParseBody(string $method, string $contentType, StreamInterface $body): ?array
    {
        if (in_array($method, ['GET', 'HEAD', 'OPTIONS'], true)) {
            return null;
        }

        if (
            $method === 'POST'
            && (
                preg_match('~^application/x-www-form-urlencoded($| |;)~', $contentType)
                || preg_match('~^multipart/form-data($| |;)~', $contentType)
            )
        ) {
            return $_POST;
        }

        if (preg_match('~^application/(|[\S]+\+)json($| |;)~', $contentType)) {
            $body = (string) $body;
            if ($body === '') {
                return null;
            }

            try {
                $parsedBody = json_decode($body, true, flags: JSON_THROW_ON_ERROR);
            } catch (JsonException $e) {
                throw new BadRequestException(
                    'Error when parsing JSON request body.',
                    previous: $e
                );
            }

            if (!is_array($parsedBody)) {
                throw new BadRequestException(
                    sprintf(
                        'Parsed JSON must contain array, but "%s" given.',
                        get_debug_type($parsedBody)
                    )
                );
            }

            return $parsedBody;
        }

        return null;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Yii\Runner\Http;
6
7		use JsonException;
8		use Psr\Http\Message\ServerRequestFactoryInterface;
9		use Psr\Http\Message\ServerRequestInterface;
10		use Psr\Http\Message\StreamFactoryInterface;
11		use Psr\Http\Message\StreamInterface;
12		use Psr\Http\Message\UploadedFileFactoryInterface;
13		use Psr\Http\Message\UriFactoryInterface;
14		use Psr\Http\Message\UriInterface;
15		use RuntimeException;
16		use Yiisoft\Yii\Runner\Http\Exception\BadRequestException;
17
18		use function array_key_exists;
19		use function explode;
20		use function fopen;
21		use function function_exists;
22		use function getallheaders;
23		use function in_array;
24		use function is_array;
25		use function preg_match;
26		use function str_replace;
27		use function strtolower;
28		use function substr;
29		use function ucwords;
30
31		/**
32		* `ServerRequestCreator` creates an instance of a server request.
33		*
34		* @internal
35		*/
36		final class RequestFactory
37		{
38	50	public function __construct(
39		private ServerRequestFactoryInterface $serverRequestFactory,
40		private UriFactoryInterface $uriFactory,
41		private UploadedFileFactoryInterface $uploadedFileFactory,
42		private StreamFactoryInterface $streamFactory,
43		) {
44	50	}
45
46		/**
47		* Creates an instance of a server request from custom parameters.
48		*
49		* @param false\|resource\|null $body
50		*
51		* @return ServerRequestInterface The server request instance.
52		*/
53	50	public function create($body = null): ServerRequestInterface
54		{
55		// Create base request
56	50	$method = $_SERVER['REQUEST_METHOD'] ?? null;
57	50	if ($method === null) {
58	1	throw new RuntimeException('Unable to determine HTTP request method.');
59		}
60	49	$request = $this->serverRequestFactory->createServerRequest($method, $this->createUri(), $_SERVER);
61
62		// Add headers
63	49	foreach ($this->getHeaders() as $name => $value) {
64	25	if ($name === 'Host' && $request->hasHeader('Host')) {
65	16	continue;
66		}
67	10	$request = $request->withAddedHeader($name, $value);
68		}
69
70		// Add protocol
71	49	$protocol = '1.1';
72	49	if (array_key_exists('SERVER_PROTOCOL', $_SERVER) && $_SERVER['SERVER_PROTOCOL'] !== '') {
73	2	$protocol = str_replace('HTTP/', '', $_SERVER['SERVER_PROTOCOL']);
74		}
75	49	$request = $request->withProtocolVersion($protocol);
76
77		// Add body
78	49	$body ??= fopen('php://input', 'rb');
79	49	if ($body !== false) {
80	47	$request = $request->withBody(
81	47	$this->streamFactory->createStreamFromResource($body)
82	47	);
83		}
84
85		// Add query and cookie params
86	49	$request = $request
87	49	->withQueryParams($_GET)
88	49	->withCookieParams($_COOKIE);
89
90		// Add uploaded files
91	49	$files = [];
92	49	foreach ($_FILES as $class => $info) {
93	49	$files[$class] = [];
94	49	$this->populateUploadedFileRecursive(
95	49	$files[$class],
96	49	$info['name'],
97	49	$info['tmp_name'],
98	49	$info['type'],
99	49	$info['size'],
100	49	$info['error'],
101	49	);
102		}
103	49	$request = $request->withUploadedFiles($files);
104
105	49	return $request;
106		}
107
108		/**
109		* @throws BadRequestException
110		*/
111	13	public function parseBody(ServerRequestInterface $request): ServerRequestInterface
112		{
113	13	$parsedBody = $this->doParseBody(
114	13	$request->getMethod(),
115	13	$request->getHeaderLine('content-type'),
116	13	$request->getBody(),
117	13	);
118
119	10	return $parsedBody === null
120	6	? $request
121	10	: $request->withParsedBody($parsedBody);
122		}
123
124	49	private function createUri(): UriInterface
125		{
126	49	$uri = $this->uriFactory->createUri();
127
128	49	if (array_key_exists('HTTPS', $_SERVER) && $_SERVER['HTTPS'] !== '' && $_SERVER['HTTPS'] !== 'off') {
129	4	$uri = $uri->withScheme('https');
130		} else {
131	45	$uri = $uri->withScheme('http');
132		}
133
134	49	$uri = isset($_SERVER['SERVER_PORT'])
135	2	? $uri->withPort((int) $_SERVER['SERVER_PORT'])
136	47	: $uri->withPort($uri->getScheme() === 'https' ? 443 : 80);
137
138	49	if (isset($_SERVER['HTTP_HOST'])) {
139	16	$uri = preg_match('/^(.+):(\d+)$/', $_SERVER['HTTP_HOST'], $matches) === 1
140	6	? $uri
141	6	->withHost($matches[1])
142	6	->withPort((int) $matches[2])
143	10	: $uri->withHost($_SERVER['HTTP_HOST']);
144	33	} elseif (isset($_SERVER['SERVER_NAME'])) {
145	2	$uri = $uri->withHost($_SERVER['SERVER_NAME']);
146		}
147
148	49	if (isset($_SERVER['REQUEST_URI'])) {
149	2	$uri = $uri->withPath(explode('?', $_SERVER['REQUEST_URI'])[0]);
150		}
151
152	49	if (isset($_SERVER['QUERY_STRING'])) {
153	2	$uri = $uri->withQuery($_SERVER['QUERY_STRING']);
154		}
155
156	49	return $uri;
157		}
158
159		/**
160		* @psalm-return array<string, string>
161		*/
162	49	private function getHeaders(): array
163		{
164		/** @psalm-var array<string, string> $_SERVER */
165
166	49	if (function_exists('getallheaders') && ($headers = getallheaders()) !== false) {
167		/** @psalm-var array<string, string> $headers */
168		return $headers;
		0 ignored issues – show Bug Best Practice introduced 2023-06-27 11:36 UTC by Report Bug Copy Issue Report The expression `return $headers` could return the type `true` which is incompatible with the type-hinted return `array`. Consider adding an additional type-check to rule them out. Loading history...
169		}
170
171	49	$headers = [];
172
173	49	foreach ($_SERVER as $name => $value) {
174	49	if (str_starts_with($name, 'REDIRECT_')) {
175	1	$name = substr($name, 9);
176
177	1	if (array_key_exists($name, $_SERVER)) {
178	1	continue;
179		}
180		}
181
182	49	if (str_starts_with($name, 'HTTP_')) {
183	16	$headers[$this->normalizeHeaderName(substr($name, 5))] = $value;
184	16	continue;
185		}
186
187	49	if (str_starts_with($name, 'CONTENT_')) {
188	10	$headers[$this->normalizeHeaderName($name)] = $value;
189		}
190		}
191
192	49	return $headers;
193		}
194
195	25	private function normalizeHeaderName(string $name): string
196		{
197	25	return str_replace(' ', '-', ucwords(strtolower(str_replace('_', ' ', $name))));
198		}
199
200		/**
201		* Populates uploaded files array from $_FILE data structure recursively.
202		*
203		* @param array $files Uploaded files array to be populated.
204		* @param mixed $names File names provided by PHP.
205		* @param mixed $tempNames Temporary file names provided by PHP.
206		* @param mixed $types File types provided by PHP.
207		* @param mixed $sizes File sizes provided by PHP.
208		* @param mixed $errors Uploading issues provided by PHP.
209		*
210		* @psalm-suppress MixedArgument, ReferenceConstraintViolation
211		*/
212	49	private function populateUploadedFileRecursive(
213		array &$files,
214		mixed $names,
215		mixed $tempNames,
216		mixed $types,
217		mixed $sizes,
218		mixed $errors
219		): void {
220	49	if (is_array($names)) {
221		/** @var array\|string $name */
222	49	foreach ($names as $i => $name) {
223	49	$files[$i] = [];
224		/** @psalm-suppress MixedArrayAccess */
225	49	$this->populateUploadedFileRecursive(
226	49	$files[$i],
227	49	$name,
228	49	$tempNames[$i],
229	49	$types[$i],
230	49	$sizes[$i],
231	49	$errors[$i],
232	49	);
233		}
234
235	49	return;
236		}
237
238		try {
239	49	$stream = $this->streamFactory->createStreamFromFile($tempNames);
240	49	} catch (RuntimeException) {
241	49	$stream = $this->streamFactory->createStream();
242		}
243
244	49	$files = $this->uploadedFileFactory->createUploadedFile(
245	49	$stream,
246	49	(int) $sizes,
247	49	(int) $errors,
248	49	$names,
249	49	$types
250	49	);
251		}
252
253		/**
254		* @throws BadRequestException
255		*/
256	13	private function doParseBody(string $method, string $contentType, StreamInterface $body): ?array
257		{
258	13	if (in_array($method, ['GET', 'HEAD', 'OPTIONS'], true)) {
259	4	return null;
260		}
261
262		if (
263	9	$method === 'POST'
264		&& (
265	9	preg_match('~^application/x-www-form-urlencoded($\| \|;)~', $contentType)
266	9	\|\| preg_match('~^multipart/form-data($\| \|;)~', $contentType)
267		)
268		) {
269	2	return $_POST;
270		}
271
272	7	if (preg_match('~^application/(\|[\S]+\+)json($\| \|;)~', $contentType)) {
273	6	$body = (string) $body;
274	6	if ($body === '') {
275	1	return null;
276		}
277
278		try {
279	5	$parsedBody = json_decode($body, true, flags: JSON_THROW_ON_ERROR);
280	1	} catch (JsonException $e) {
281	1	throw new BadRequestException(
282	1	'Error when parsing JSON request body.',
283	1	previous: $e
284	1	);
285		}
286
287	4	if (!is_array($parsedBody)) {
288	2	throw new BadRequestException(
289	2	sprintf(
290	2	'Parsed JSON must contain array, but "%s" given.',
291	2	get_debug_type($parsedBody)
292	2	)
293	2	);
294		}
295
296	2	return $parsedBody;
297		}
298
299	1	return null;
300		}
301		}
302

yiisoft / yii-runner-http

Pull Request — master (#53)

RequestFactory::doParseBody() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like