AccessChecker::process() - Code Metrics - Inspection of "Refactoring post controller" - yiisoft/yii-demo - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#138)

by Sergei

created 2020-09-15 10:41 UTC

AccessChecker::process() A

↳ Parent: AccessChecker

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	5
c	0
b	0
f	0
nc	3
nop	2
dl	0
loc	11
rs	10

<?php

declare(strict_types=1);

namespace App\Middleware;

use App\Service\UserService;
use Psr\Http\Message\ResponseFactoryInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;
use Yiisoft\Http\Status;

final class AccessChecker implements MiddlewareInterface
{
    private ResponseFactoryInterface $responseFactory;
    private UserService $userService;
    private ?string $permission = null;

    public function __construct(
        ResponseFactoryInterface $responseFactory,
        UserService $userService
    ) {
        $this->responseFactory = $responseFactory;
        $this->userService = $userService;
    }

    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        if ($this->permission === null) {
            throw new \InvalidArgumentException('Permission not set.');
        }

        if (!$this->userService->hasPermission($this->permission)) {
            return $this->responseFactory->createResponse(Status::FORBIDDEN);
        }

        return $handler->handle($request);
    }

    public function withPermission(string $permission): self
    {
        $new = clone $this;
        $new->permission = $permission;
        return $new;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace App\Middleware;
6
7			use App\Service\UserService;
8			use Psr\Http\Message\ResponseFactoryInterface;
9			use Psr\Http\Message\ResponseInterface;
10			use Psr\Http\Message\ServerRequestInterface;
11			use Psr\Http\Server\MiddlewareInterface;
12			use Psr\Http\Server\RequestHandlerInterface;
13			use Yiisoft\Http\Status;
14
15			final class AccessChecker implements MiddlewareInterface
16			{
17			private ResponseFactoryInterface $responseFactory;
18			private UserService $userService;
19			private ?string $permission = null;
20
21			public function __construct(
22			ResponseFactoryInterface $responseFactory,
23			UserService $userService
24			) {
25			$this->responseFactory = $responseFactory;
26			$this->userService = $userService;
27			}
28
29			public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
30			{
31			if ($this->permission === null) {
32			throw new \InvalidArgumentException('Permission not set.');
33			}
34
35			if (!$this->userService->hasPermission($this->permission)) {
36			return $this->responseFactory->createResponse(Status::FORBIDDEN);
37			}
38
39			return $handler->handle($request);
40			}
41
42			public function withPermission(string $permission): self
43			{
44			$new = clone $this;
45			$new->permission = $permission;
46			return $new;
47			}
48			}
49

yiisoft / yii-demo

Pull Request — master (#138)

AccessChecker::process() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like