App\Service\UserService

Complexity

Total Complexity

4

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getUser()	0	3	1
A	hasPermission()	0	4	2

<?php

declare(strict_types=1);

namespace App\Service;

use App\Entity\User;
use App\Repository\UserRepository;
use Yiisoft\Access\AccessCheckerInterface;
use Yiisoft\Yii\Web\User\User as UserComponent;

final class UserService
{
    private UserComponent $user;
    private UserRepository $repository;
    private AccessCheckerInterface $accessChecker;

    public function __construct(UserComponent $user, UserRepository $repository, AccessCheckerInterface $accessChecker)
    {
        $this->user = $user;
        $this->repository = $repository;
        $this->accessChecker = $accessChecker;
    }

    public function getUser(): ?User
    {
        return $this->repository->findIdentity($this->user->getId());

The expression return $this->repository->findIdentity($this->user->getId()) could return the type Yiisoft\Auth\IdentityInterface which includes types incompatible with the type-hinted return App\Entity\User|null. Consider adding an additional type-check to rule them out.

It seems like $this->user->getId() can also be of type null; however, parameter $id of App\Repository\UserRepository::findIdentity() does only seem to accept string, maybe add an additional type check?

    }

    public function hasPermission(string $permission): bool
    {
        $userId = $this->user->getId();
        return !is_null($userId) && $this->accessChecker->userHasPermission($userId, $permission);
    }
}