yiisoft /
yii-demo
| Conditions | 10 |
| Paths | 11 |
| Total Lines | 39 |
| Code Lines | 28 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 18 | private function xml_encode($data, \DOMNode $domElement = null, \DOMDocument $DOMDocument = null): string |
||
| 19 | { |
||
| 20 | if ($DOMDocument === null) { |
||
| 21 | $DOMDocument = new \DOMDocument(); |
||
| 22 | $DOMDocument->formatOutput = true; |
||
| 23 | $this->xml_encode(['data' => $data], $DOMDocument, $DOMDocument); |
||
| 24 | return $DOMDocument->saveXML(); |
||
| 25 | } |
||
| 26 | // To cope with embedded objects |
||
| 27 | if (is_object($data)) { |
||
| 28 | $data = get_object_vars($data); |
||
| 29 | } |
||
| 30 | if (is_array($data)) { |
||
| 31 | foreach ($data as $index => $mixedElement) { |
||
| 32 | if (is_int($index)) { |
||
| 33 | if ($index === 0) { |
||
| 34 | $node = $domElement; |
||
| 35 | } else { |
||
| 36 | $node = $DOMDocument->createElement($domElement->tagName); |
||
| 37 | $domElement->parentNode->appendChild($node); |
||
| 38 | } |
||
| 39 | } else { |
||
| 40 | $plural = $DOMDocument->createElement($index); |
||
| 41 | $domElement->appendChild($plural); |
||
|
|
|||
| 42 | $node = $plural; |
||
| 43 | if (!(rtrim($index, 's') === $index)) { |
||
| 44 | $singular = $DOMDocument->createElement(rtrim($index, 's')); |
||
| 45 | $plural->appendChild($singular); |
||
| 46 | $node = $singular; |
||
| 47 | } |
||
| 48 | } |
||
| 49 | |||
| 50 | $this->xml_encode($mixedElement, $node, $DOMDocument); |
||
| 51 | } |
||
| 52 | } else { |
||
| 53 | $data = is_bool($data) ? ($data ? 'true' : 'false') : $data; |
||
| 54 | $domElement->appendChild($DOMDocument->createTextNode($data)); |
||
| 55 | } |
||
| 56 | return ''; |
||
| 57 | } |
||
| 59 |
This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.
This is most likely a typographical error or the method has been renamed.