PostController::add() - Code Metrics - Inspection of "Refactoring post controller" - yiisoft/yii-demo - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#138)

by Alexander

created 2020-09-14 20:43 UTC

PostController::add() B

↳ Parent: Project

Complexity

Conditions	7
Paths	48

Size

Total Lines	61
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	36
nc	48
nop	3
dl	0
loc	61
rs	8.4106
c	0
b	0
f	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace App\Blog\Post;

use App\Blog\Entity\Post;
use App\Service\UserService;
use App\ViewRenderer;
use App\Service\WebControllerService;
use App\Blog\Entity\Tag;
use App\Entity\User;
use Cycle\ORM\ORMInterface;
use Cycle\ORM\Transaction;
use Psr\Http\Message\ResponseFactoryInterface;
use Psr\Http\Message\ResponseInterface as Response;
use Psr\Http\Message\ServerRequestInterface as Request;
use Yiisoft\Http\Method;
use Yiisoft\Router\UrlGeneratorInterface;
use Yiisoft\Yii\View\ViewRenderer;

use Yiisoft\Yii\Web\User\User as UserComponent;

final class PostController
{
    private ViewRenderer $viewRenderer;
    private WebControllerService $webService;
    private PostService $postService;
    private UserService $userService;

    public function __construct(
        ViewRenderer $viewRenderer,
        WebControllerService $webService,
        PostService $postService,
        UserService $userService
    ) {
        $this->viewRenderer = $viewRenderer->withControllerName('blog/post');
        $this->webService = $webService;
        $this->postService = $postService;
        $this->userService = $userService;
    }

    public function index(Request $request, PostRepository $postRepository): Response
    {
        $canEdit = $this->userService->hasPermission('editPost');
        $slug = $request->getAttribute('slug', null);
        $item = $postRepository->fullPostPage($slug);
        if ($item === null) {
            return $this->webService->getNotFoundResponse();
        }

        return $this->viewRenderer->render('index', ['item' => $item, 'canEdit' => $canEdit, 'slug' => $slug]);
    }

    public function add(Request $request, PostForm $form): Response
    {
        $parameters = [
            'title' => 'Add post',
            'action' => ['blog/add'],
            'errors' => [],
            'body' => $request->getParsedBody(),
        ];

        if ($request->getMethod() === Method::POST) {
            $form->load($parameters['body']);
            if ($form->validate()) {
                $this->postService->savePost($this->userService->getUser(), new Post(), $form);
                return $this->webService->getRedirectResponse('blog/index');
            }

            $parameters['errors'] = $form->firstErrors();
        }

        return $this->viewRenderer->withCsrf()->render('__form', $parameters);
    }

    public function edit(Request $request, PostForm $form, PostRepository $postRepository): Response
    {
        $slug = $request->getAttribute('slug', null);
        $post = $postRepository->fullPostPage($slug);
        if ($post === null) {
            return $this->webService->getNotFoundResponse();
        }

        $parameters = [
            'title' => 'Edit post',
            'action' => ['blog/edit', ['slug' => $slug]],
            'errors' => [],
            'body' => [
                'title' => $post->getTitle(),
                'content' => $post->getContent(),
                'tags' => $this->postService->getPostTags($post)
            ]
        ];

        if ($request->getMethod() === Method::POST) {
            $body = $request->getParsedBody();
            $form->load($body);
            if ($form->validate()) {
                $this->postService->savePost($this->userService->getUser(), $post, $form);
                return $this->webService->getRedirectResponse('blog/index');
            }

            $parameters['body'] = $body;
            $parameters['errors'] = $form->firstErrors();
        }

        return $this->viewRenderer->withCsrf()->render('__form', $parameters);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace App\Blog\Post;
6
7			use App\Blog\Entity\Post;
8			use App\Service\UserService;
9			use App\ViewRenderer;
10			use App\Service\WebControllerService;
11			use App\Blog\Entity\Tag;
12			use App\Entity\User;
13			use Cycle\ORM\ORMInterface;
14			use Cycle\ORM\Transaction;
15			use Psr\Http\Message\ResponseFactoryInterface;
16			use Psr\Http\Message\ResponseInterface as Response;
17			use Psr\Http\Message\ServerRequestInterface as Request;
18			use Yiisoft\Http\Method;
19			use Yiisoft\Router\UrlGeneratorInterface;
20			use Yiisoft\Yii\View\ViewRenderer;
			0 ignored issues – show Bug introduced 2020-09-14 21:21 UTC by Report Bug Copy Issue Report A parse error occurred: Cannot use Yiisoft\Yii\View\ViewRenderer as ViewRenderer because the name is already in use Loading history...
21			use Yiisoft\Yii\Web\User\User as UserComponent;
22
23			final class PostController
24			{
25			private ViewRenderer $viewRenderer;
26			private WebControllerService $webService;
27			private PostService $postService;
28			private UserService $userService;
29
30			public function __construct(
31			ViewRenderer $viewRenderer,
32			WebControllerService $webService,
33			PostService $postService,
34			UserService $userService
35			) {
36			$this->viewRenderer = $viewRenderer->withControllerName('blog/post');
37			$this->webService = $webService;
38			$this->postService = $postService;
39			$this->userService = $userService;
40			}
41
42			public function index(Request $request, PostRepository $postRepository): Response
43			{
44			$canEdit = $this->userService->hasPermission('editPost');
45			$slug = $request->getAttribute('slug', null);
46			$item = $postRepository->fullPostPage($slug);
47			if ($item === null) {
48			return $this->webService->getNotFoundResponse();
49			}
50
51			return $this->viewRenderer->render('index', ['item' => $item, 'canEdit' => $canEdit, 'slug' => $slug]);
52			}
53
54			public function add(Request $request, PostForm $form): Response
55			{
56			$parameters = [
57			'title' => 'Add post',
58			'action' => ['blog/add'],
59			'errors' => [],
60			'body' => $request->getParsedBody(),
61			];
62
63			if ($request->getMethod() === Method::POST) {
64			$form->load($parameters['body']);
65			if ($form->validate()) {
66			$this->postService->savePost($this->userService->getUser(), new Post(), $form);
67			return $this->webService->getRedirectResponse('blog/index');
68			}
69
70			$parameters['errors'] = $form->firstErrors();
71			}
72
73			return $this->viewRenderer->withCsrf()->render('__form', $parameters);
74			}
75
76			public function edit(Request $request, PostForm $form, PostRepository $postRepository): Response
77			{
78			$slug = $request->getAttribute('slug', null);
79			$post = $postRepository->fullPostPage($slug);
80			if ($post === null) {
81			return $this->webService->getNotFoundResponse();
82			}
83
84			$parameters = [
85			'title' => 'Edit post',
86			'action' => ['blog/edit', ['slug' => $slug]],
87			'errors' => [],
88			'body' => [
89			'title' => $post->getTitle(),
90			'content' => $post->getContent(),
91			'tags' => $this->postService->getPostTags($post)
92			]
93			];
94
95			if ($request->getMethod() === Method::POST) {
96			$body = $request->getParsedBody();
97			$form->load($body);
98			if ($form->validate()) {
99			$this->postService->savePost($this->userService->getUser(), $post, $form);
100			return $this->webService->getRedirectResponse('blog/index');
101			}
102
103			$parameters['body'] = $body;
104			$parameters['errors'] = $form->firstErrors();
105			}
106
107			return $this->viewRenderer->withCsrf()->render('__form', $parameters);
108			}
109			}
110

yiisoft / yii-demo

Pull Request — master (#138)

PostController::add() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like