CommentController::index() - Code Metrics - Inspection of "Implement KeySetPaginator" - yiisoft/yii-demo - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#93)

by Alexander

created 2020-04-30 20:09 UTC

CommentController::index() A

↳ Parent: CommentController

Complexity

Conditions	3
Paths	4

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	6
dl	0
loc	12
rs	10
c	0
b	0
f	0
cc	3
nc	4
nop	2

<?php

declare(strict_types=1);

namespace App\Blog;

use App\Blog\Comment\CommentService;
use App\Controller;
use Psr\Http\Message\ResponseInterface as Response;
use Psr\Http\Message\ServerRequestInterface as Request;

final class CommentController extends Controller
{
    protected function getId(): string
    {
        return 'blog/comments';
    }

    public function index(Request $request, CommentService $service): Response
    {
        $paginator = $service->getFeedPaginator();
        if ($request->getAttribute('next') !== null) {
            $paginator = $paginator->withNextPageToken((string)$request->getAttribute('next'));
        }

        if ($this->isAjaxRequest($request)) {
            return $this->renderPartial('_comments', ['data' => $paginator]);
        }

        return $this->render('index', ['data' => $paginator]);
    }

    private function isAjaxRequest(Request $request): bool
    {
        return $request->getHeaderLine('X-Requested-With') === 'XMLHttpRequest';
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace App\Blog;
6
7			use App\Blog\Comment\CommentService;
8			use App\Controller;
9			use Psr\Http\Message\ResponseInterface as Response;
10			use Psr\Http\Message\ServerRequestInterface as Request;
11
12			final class CommentController extends Controller
13			{
14			protected function getId(): string
15			{
16			return 'blog/comments';
17			}
18
19			public function index(Request $request, CommentService $service): Response
20			{
21			$paginator = $service->getFeedPaginator();
22			if ($request->getAttribute('next') !== null) {
23			$paginator = $paginator->withNextPageToken((string)$request->getAttribute('next'));
24			}
25
26			if ($this->isAjaxRequest($request)) {
27			return $this->renderPartial('_comments', ['data' => $paginator]);
28			}
29
30			return $this->render('index', ['data' => $paginator]);
31			}
32
33			private function isAjaxRequest(Request $request): bool
34			{
35			return $request->getHeaderLine('X-Requested-With') === 'XMLHttpRequest';
36			}
37			}
38

yiisoft / yii-demo

Pull Request — master (#93)

CommentController::index() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like