UserController::profile() - Code Metrics - Inspection of "Add ViewRenderer" - yiisoft/yii-demo - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#115)

by Dmitriy

created 2020-07-13 12:54 UTC

UserController::profile() A

↳ Parent: UserController

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	5
c	0
b	0
f	0
dl	0
loc	9
rs	10
cc	2
nc	2
nop	2

<?php

namespace App\Controller;

use App\Repository\UserRepository;
use App\ViewRenderer;
use Psr\Http\Message\ResponseInterface as Response;
use Psr\Http\Message\ServerRequestInterface as Request;
use Yiisoft\Data\Paginator\OffsetPaginator;
use Yiisoft\Data\Reader\Sort;

class UserController
{
    private const PAGINATION_INDEX = 5;

    private ViewRenderer $viewRenderer;

    public function __construct(ViewRenderer $viewRenderer)
    {
        $this->viewRenderer = $viewRenderer->withControllerName('user');
    }

    public function index(Request $request, UserRepository $userRepository): Response
    {
        $pageNum = (int)$request->getAttribute('page', 1);

        $dataReader = $userRepository->findAll()->withSort((new Sort([]))->withOrderString('login'));
        $paginator = (new OffsetPaginator($dataReader))
            ->withPageSize(self::PAGINATION_INDEX)
            ->withCurrentPage($pageNum);

        return $this->viewRenderer->render('index', ['paginator' => $paginator]);
    }

    public function profile(Request $request, UserRepository $userRepository): Response
    {
        $login = $request->getAttribute('login', null);
        $item = $userRepository->findByLogin($login);
        if ($item === null) {
            return $this->responseFactory->createResponse(404);

        }

        return $this->viewRenderer->render('profile', ['item' => $item]);
    }
}


1			<?php
2
3			namespace App\Controller;
4
5			use App\Repository\UserRepository;
6			use App\ViewRenderer;
7			use Psr\Http\Message\ResponseInterface as Response;
8			use Psr\Http\Message\ServerRequestInterface as Request;
9			use Yiisoft\Data\Paginator\OffsetPaginator;
10			use Yiisoft\Data\Reader\Sort;
11
12			class UserController
13			{
14			private const PAGINATION_INDEX = 5;
15
16			private ViewRenderer $viewRenderer;
17
18			public function __construct(ViewRenderer $viewRenderer)
19			{
20			$this->viewRenderer = $viewRenderer->withControllerName('user');
21			}
22
23			public function index(Request $request, UserRepository $userRepository): Response
24			{
25			$pageNum = (int)$request->getAttribute('page', 1);
26
27			$dataReader = $userRepository->findAll()->withSort((new Sort([]))->withOrderString('login'));
28			$paginator = (new OffsetPaginator($dataReader))
29			->withPageSize(self::PAGINATION_INDEX)
30			->withCurrentPage($pageNum);
31
32			return $this->viewRenderer->render('index', ['paginator' => $paginator]);
33			}
34
35			public function profile(Request $request, UserRepository $userRepository): Response
36			{
37			$login = $request->getAttribute('login', null);
38			$item = $userRepository->findByLogin($login);
39			if ($item === null) {
40			return $this->responseFactory->createResponse(404);
			0 ignored issues – show Bug Best Practice introduced 2020-07-13 10:58 UTC by Report Bug Copy Issue Report The property `responseFactory` does not exist on `App\Controller\UserController`. Did you maybe forget to declare it? Loading history...
41			}
42
43			return $this->viewRenderer->render('profile', ['item' => $item]);
44			}
45			}
46

yiisoft / yii-demo

Pull Request — master (#115)

UserController::profile() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like