UserController::profile() - Code Metrics - Inspection of "Group by usecase" - yiisoft/yii-demo - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#186)

by Alexander

created 2020-12-02 14:35 UTC

UserController::profile() A

↳ Parent: UserController

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	5
c	0
b	0
f	0
nc	2
nop	3
dl	0
loc	9
ccs	0
cts	6
cp	0
crap	6
rs	10

<?php

declare(strict_types=1);

namespace App\User;

use Psr\Http\Message\ResponseFactoryInterface;
use Psr\Http\Message\ResponseInterface as Response;
use Psr\Http\Message\ServerRequestInterface as Request;
use Yiisoft\Data\Paginator\OffsetPaginator;
use Yiisoft\Data\Reader\Sort;
use Yiisoft\Yii\View\ViewRenderer;
filter:
    dependency_paths: ["lib/*"]

class UserController
{
    private const PAGINATION_INDEX = 5;

    private ViewRenderer $viewRenderer;

    public function __construct(ViewRenderer $viewRenderer)
    {
        $this->viewRenderer = $viewRenderer->withControllerName('user');
    }

    public function index(Request $request, UserRepository $userRepository): Response
    {
        $pageNum = (int)$request->getAttribute('page', 1);

        $dataReader = $userRepository->findAll()->withSort((new Sort([]))->withOrderString('login'));
        $paginator = (new OffsetPaginator($dataReader))
            ->withPageSize(self::PAGINATION_INDEX)
            ->withCurrentPage($pageNum);

        return $this->viewRenderer->render('index', ['paginator' => $paginator]);
    }

    public function profile(Request $request, UserRepository $userRepository, ResponseFactoryInterface $responseFactory): Response
    {
        $login = $request->getAttribute('login', null);
        $item = $userRepository->findByLogin($login);
        if ($item === null) {
            return $responseFactory->createResponse(404);
        }

        return $this->viewRenderer->render('profile', ['item' => $item]);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace App\User;
6
7		use Psr\Http\Message\ResponseFactoryInterface;
8		use Psr\Http\Message\ResponseInterface as Response;
9		use Psr\Http\Message\ServerRequestInterface as Request;
10		use Yiisoft\Data\Paginator\OffsetPaginator;
11		use Yiisoft\Data\Reader\Sort;
12		use Yiisoft\Yii\View\ViewRenderer;
		0 ignored issues – show Bug introduced 2020-09-14 21:21 UTC by Report Bug Copy Issue Report The type `Yiisoft\Yii\View\ViewRenderer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
13
14		class UserController
15		{
16		private const PAGINATION_INDEX = 5;
17
18		private ViewRenderer $viewRenderer;
19
20	1	public function __construct(ViewRenderer $viewRenderer)
21		{
22	1	$this->viewRenderer = $viewRenderer->withControllerName('user');
23	1	}
24
25	1	public function index(Request $request, UserRepository $userRepository): Response
26		{
27	1	$pageNum = (int)$request->getAttribute('page', 1);
28
29	1	$dataReader = $userRepository->findAll()->withSort((new Sort([]))->withOrderString('login'));
30	1	$paginator = (new OffsetPaginator($dataReader))
31	1	->withPageSize(self::PAGINATION_INDEX)
32	1	->withCurrentPage($pageNum);
33
34	1	return $this->viewRenderer->render('index', ['paginator' => $paginator]);
35		}
36
37		public function profile(Request $request, UserRepository $userRepository, ResponseFactoryInterface $responseFactory): Response
38		{
39		$login = $request->getAttribute('login', null);
40		$item = $userRepository->findByLogin($login);
41		if ($item === null) {
42		return $responseFactory->createResponse(404);
43		}
44
45		return $this->viewRenderer->render('profile', ['item' => $item]);
46		}
47		}
48

yiisoft / yii-demo

Pull Request — master (#186)

UserController::profile() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like