ApiUserController::profile() - Code Metrics - Inspection of "Group by usecase" - yiisoft/yii-demo - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#186)

by Alexander

created 2020-12-02 14:35 UTC

ApiUserController::profile() A

↳ Parent: ApiUserController

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	6
c	0
b	0
f	0
nc	2
nop	2
dl	0
loc	12
ccs	0
cts	7
cp	0
crap	6
rs	10

<?php

declare(strict_types=1);

namespace App\User;

use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Yiisoft\Data\Reader\Sort;
use Yiisoft\DataResponse\DataResponseFactoryInterface;

class ApiUserController
{
    private DataResponseFactoryInterface $responseFactory;

    public function __construct(DataResponseFactoryInterface $responseFactory)
    {
        $this->responseFactory = $responseFactory;
    }

    public function index(UserRepository $userRepository): ResponseInterface
    {
        $dataReader = $userRepository->findAll()->withSort((new Sort([]))->withOrderString('login'));
        $users = $dataReader->read();

        $items = [];
        foreach ($users as $user) {
            $items[] = ['login' => $user->getLogin(), 'created_at' => $user->getCreatedAt()->format('H:i:s d.m.Y')];
        }

        return $this->responseFactory->createResponse($items);
    }

    public function profile(ServerRequestInterface $request, UserRepository $userRepository): ResponseInterface
    {
        $login = $request->getAttribute('login', null);

        /** @var User $user */
        $user = $userRepository->findByLogin($login);
        if ($user === null) {
            return $this->responseFactory->createResponse('Page not found', 404);
        }

        return $this->responseFactory->createResponse(
            ['login' => $user->getLogin(), 'created_at' => $user->getCreatedAt()->format('H:i:s d.m.Y')]
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace App\User;
6
7			use Psr\Http\Message\ResponseInterface;
8			use Psr\Http\Message\ServerRequestInterface;
9			use Yiisoft\Data\Reader\Sort;
10			use Yiisoft\DataResponse\DataResponseFactoryInterface;
11
12			class ApiUserController
13			{
14			private DataResponseFactoryInterface $responseFactory;
15
16			public function __construct(DataResponseFactoryInterface $responseFactory)
17			{
18			$this->responseFactory = $responseFactory;
19			}
20
21			public function index(UserRepository $userRepository): ResponseInterface
22			{
23			$dataReader = $userRepository->findAll()->withSort((new Sort([]))->withOrderString('login'));
24			$users = $dataReader->read();
25
26			$items = [];
27			foreach ($users as $user) {
28			$items[] = ['login' => $user->getLogin(), 'created_at' => $user->getCreatedAt()->format('H:i:s d.m.Y')];
29			}
30
31			return $this->responseFactory->createResponse($items);
32			}
33
34			public function profile(ServerRequestInterface $request, UserRepository $userRepository): ResponseInterface
35			{
36			$login = $request->getAttribute('login', null);
37
38			/** @var User $user */
39			$user = $userRepository->findByLogin($login);
40			if ($user === null) {
41			return $this->responseFactory->createResponse('Page not found', 404);
42			}
43
44			return $this->responseFactory->createResponse(
45			['login' => $user->getLogin(), 'created_at' => $user->getCreatedAt()->format('H:i:s d.m.Y')]
46			);
47			}
48			}
49

yiisoft / yii-demo

Pull Request — master (#186)

ApiUserController::profile() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like