PostController::edit() - Code Metrics - Inspection of "Implement adding/editing blog post in yii-demo" - yiisoft/yii-demo - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#132)

by Alexander

created 2020-09-06 14:33 UTC

PostController::edit() B

↳ Parent: PostController

Complexity

Conditions	8
Paths	22

Size

Total Lines	63
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	8
eloc	37
c	3
b	0
f	0
nc	22
nop	5
dl	0
loc	63
rs	8.0835

How to fix Long Method

<?php

namespace App\Blog\Post;

use App\Blog\Entity\Post;
use App\Entity\User;
use App\ViewRenderer;
use Cycle\ORM\ORMInterface;
use Cycle\ORM\Transaction;
use Psr\Http\Message\ResponseFactoryInterface;
use Psr\Http\Message\ResponseInterface as Response;
use Psr\Http\Message\ServerRequestInterface as Request;
use Psr\Log\LoggerInterface;
use Yiisoft\Access\AccessCheckerInterface;
use Yiisoft\Http\Method;
use Yiisoft\Router\UrlGeneratorInterface;
use Yiisoft\Yii\Web\User\User as UserComponent;

final class PostController
{
    private ViewRenderer $viewRenderer;
    private ResponseFactoryInterface $responseFactory;
    private LoggerInterface $logger;
    private UserComponent $userService;

    public function __construct(
        ViewRenderer $viewRenderer,
        ResponseFactoryInterface $responseFactory,
        LoggerInterface $logger,
        UserComponent $userService
    ) {
        $this->viewRenderer = $viewRenderer->withControllerName('blog/post');
        $this->responseFactory = $responseFactory;
        $this->logger = $logger;
        $this->userService = $userService;
    }

    public function index(Request $request, PostRepository $postRepository, AccessCheckerInterface $accessChecker): Response
    {
        $userId = $this->userService->getId();
        $canEdit = !is_null($userId) && $accessChecker->userHasPermission($userId, 'editPost');

        $slug = $request->getAttribute('slug', null);
        $item = $postRepository->fullPostPage($slug);
        if ($item === null) {
            return $this->responseFactory->createResponse(404);
        }

        return $this->viewRenderer->render('index', ['item' => $item, 'canEdit' => $canEdit, 'slug' => $slug]);
    }

    public function add(
        Request $request,
        ORMInterface $orm,
        UrlGeneratorInterface $urlGenerator
    ): Response {
        if ($this->userService->isGuest()) {
            return $this->responseFactory->createResponse(403);
        }

        $body = $request->getParsedBody();
        $parameters = [
            'body' => $body,
            'action' => ['blog/add']
        ];

        if ($request->getMethod() === Method::POST) {
            $error = '';


            try {
                foreach (['title', 'content'] as $name) {
                    if (empty($body[$name])) {
                        throw new \InvalidArgumentException(ucfirst($name) . ' is required');
                    }
                }

                $post = new Post($body['title'], $body['content']);

                $userRepo = $orm->getRepository(User::class);
                $user = $userRepo->findByPK($this->userService->getId());

                $post->setUser($user);
                $post->setUser(/** @scrutinizer ignore-type */ $user);
                $post->setPublic(true);

                $transaction = new Transaction($orm);
                $transaction->persist($post);

                $transaction->run();

                return $this->responseFactory
                    ->createResponse(302)
                    ->withHeader(
                        'Location',
                        $urlGenerator->generate('blog/index')
                    );
            } catch (\Throwable $e) {
                $this->logger->error($e);
                $error = $e->getMessage();
            }

            $parameters['error'] = $error;
        }

        $parameters['title'] = 'Add post';
        return $this->viewRenderer->withCsrf()->render('__form', $parameters);
    }

    public function edit(
        Request $request,
        ORMInterface $orm,
        UrlGeneratorInterface $urlGenerator,
        PostRepository $postRepository,
        AccessCheckerInterface $accessChecker
    ): Response {
        $userId = $this->userService->getId();
        if (is_null($userId) || !$accessChecker->userHasPermission($userId, 'editPost')) {
            return $this->responseFactory->createResponse(403);
        }

        $slug = $request->getAttribute('slug', null);
        $post = $postRepository->fullPostPage($slug);
        if ($post === null) {
            return $this->responseFactory->createResponse(404);
        }

        $parameters = [];
        $parameters['action'] = ['blog/edit', ['slug' => $slug]];

        if ($request->getMethod() === Method::POST) {
            $error = '';


            try {
                $body = $request->getParsedBody();
                $parameters['body'] = $body;

                foreach (['title', 'content'] as $name) {
                    if (empty($body[$name])) {
                        throw new \InvalidArgumentException(ucfirst($name) . ' is required');
                    }
                }

                $post->setTitle($body['title']);
                $post->setContent($body['content']);

                $transaction = new Transaction($orm);
                $transaction->persist($post);

                $transaction->run();

                return $this->responseFactory
                    ->createResponse(302)
                    ->withHeader(
                        'Location',
                        $urlGenerator->generate('blog/index')
                    );
            } catch (\Throwable $e) {
                $this->logger->error($e);
                $error = $e->getMessage();
            }

            $parameters['error'] = $error;
        } else {
            $parameters['body'] = [
                'title' => $post->getTitle(),
                'content' => $post->getContent(),
            ];
        }

        $parameters['title'] = 'Edit post';
        return $this->viewRenderer->withCsrf()->render('__form', $parameters);
    }
}


yiisoft / yii-demo

Pull Request — master (#132)

PostController::edit() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like