App\Contact\ContactController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	contact()	0	18	4
A	__construct()	0	10	1

<?php

declare(strict_types=1);

namespace App\Contact;

use App\Form\ContactForm;
use Psr\Http\Message\ResponseFactoryInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Log\LoggerInterface;
use Yiisoft\Http\Method;
use Yiisoft\Yii\View\ViewRenderer;

class ContactController
{
    private ContactMailer $mailer;
    private LoggerInterface $logger;
    private ViewRenderer $viewRenderer;
    private ResponseFactoryInterface $responseFactory;

    public function __construct(
        ViewRenderer $viewRenderer,
        ContactMailer $mailer,
        LoggerInterface $logger,
        ResponseFactoryInterface $responseFactory
    ) {
        $this->mailer = $mailer;
        $this->logger = $logger;
        $this->viewRenderer = $viewRenderer->withControllerName('contact');
        $this->responseFactory = $responseFactory;
    }

    public function contact(ServerRequestInterface $request, ContactForm $form): ResponseInterface
    {
        $parameters = [
            'form' => $form
        ];
        $sent = false;

The assignment to $sent is dead and can be removed.

        if (($request->getMethod() === Method::POST)) {
            $sent = true;

            if ($form->load($request->getParsedBody()) && $form->validate()) {

It seems like $request->getParsedBody() can also be of type null and object; however, parameter $data of Yiisoft\Form\FormModel::load() does only seem to accept array, maybe add an additional type check?

                $this->mailer->send($form, $request);
            }

            $parameters['sent'] = $sent;
        }

        return $this->viewRenderer->withCsrf()->render('form', $parameters);
    }
}