App\User\UserService

Complexity

Total Complexity

4

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getUser()	0	3	1
A	hasPermission()	0	4	2
A	__construct()	0	5	1

<?php

declare(strict_types=1);

namespace App\User;

use Yiisoft\Access\AccessCheckerInterface;
use Yiisoft\User\CurrentUser;

final class UserService
{
    private CurrentUser $currentUser;
    private UserRepository $repository;
    private AccessCheckerInterface $accessChecker;

    public function __construct(CurrentUser $currentUser, UserRepository $repository, AccessCheckerInterface $accessChecker)
    {
        $this->currentUser = $currentUser;
        $this->repository = $repository;
        $this->accessChecker = $accessChecker;
    }

    public function getUser(): ?User
    {
        return $this->repository->findIdentity($this->currentUser->getId());

The expression return $this->repository->findIdentity($this->currentUser->getId()) could return the type Yiisoft\Auth\IdentityInterface which includes types incompatible with the type-hinted return App\User\User|null. Consider adding an additional type-check to rule them out.

It seems like $this->currentUser->getId() can also be of type null; however, parameter $id of App\User\UserRepository::findIdentity() does only seem to accept string, maybe add an additional type check?

    }

    public function hasPermission(string $permission): bool
    {
        $userId = $this->currentUser->getId();
        return null !== $userId && $this->accessChecker->userHasPermission($userId, $permission);
    }
}