App\User\Console\AssignRoleCommand

Complexity

Total Complexity

8

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	0	7	1
B	execute()	0	38	6
A	__construct()	0	6	1

<?php

declare(strict_types=1);

namespace App\User\Console;

use App\User\User;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ConfirmationQuestion;
use Symfony\Component\Console\Style\SymfonyStyle;
use Yiisoft\Rbac\Manager;
use Yiisoft\Rbac\Role;
use Yiisoft\Rbac\StorageInterface;
use Yiisoft\Yii\Console\ExitCode;
use Yiisoft\Yii\Cycle\Command\CycleDependencyProxy;

class AssignRoleCommand extends Command
{
    private CycleDependencyProxy $promise;
    private Manager $manager;
    private StorageInterface $storage;

    protected static $defaultName = 'user/assignRole';

    public function __construct(CycleDependencyProxy $promise, Manager $manager, StorageInterface $storage)
    {
        $this->promise = $promise;
        $this->manager = $manager;
        $this->storage = $storage;
        parent::__construct();
    }

    public function configure(): void
    {
        $this
            ->setDescription('Assign RBAC role to given user')
            ->setHelp('This command allows you to assign RBAC role to user')
            ->addArgument('role', InputArgument::REQUIRED, 'RBAC role')
            ->addArgument('userId', InputArgument::REQUIRED, 'User id');
    }

    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $io = new SymfonyStyle($input, $output);

        $roleName = $input->getArgument('role');
        $userId = $input->getArgument('userId');

        try {
            $orm = $this->promise->getORM();
            $userRepo = $orm->getRepository(User::class);
            $user = $userRepo->findByPK($userId);
            if (null === $user) {
                throw new \Exception('Can\'t find user');
            }

            $role = $this->storage->getRoleByName($roleName);

It seems like $roleName can also be of type null and string[]; however, parameter $name of Yiisoft\Rbac\StorageInterface::getRoleByName() does only seem to accept string, maybe add an additional type check?

            if (null === $role) {
                $helper = $this->getHelper('question');
                $question = new ConfirmationQuestion('Role doesn\'t exist. Create new one? ', false);

                if (!$helper->ask($input, $output, $question)) {
                    return ExitCode::OK;
                }

                $role = new Role($roleName);

It seems like $roleName can also be of type null and string[]; however, parameter $name of Yiisoft\Rbac\Role::__construct() does only seem to accept string, maybe add an additional type check?

                $this->manager->addRole($role);
            }

            $this->manager->assign($role, $user->getId());

            $io->success('Role was assigned to given user');
        } catch (\Throwable $t) {
            $io->error($t->getMessage());
            return $t->getCode() ?: ExitCode::UNSPECIFIED_ERROR;
        }

        return ExitCode::OK;
    }
}