yiisoft / yii-debug

src/Collector/HttpClientInterfaceProxy.php

<?php

declare(strict_types=1);

namespace Yiisoft\Yii\Debug\Collector;

use Psr\Http\Client\ClientInterface;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

final class HttpClientInterfaceProxy implements ClientInterface
{
    public function __construct(private ClientInterface $decorated, private HttpClientCollector $collector)
    {
    }

    public function sendRequest(RequestInterface $request): ResponseInterface
    {
        /** @psalm-var array{file: string, line: int} $callStack */
        $callStack = debug_backtrace()[0];

        $uniqueId = random_bytes(36);
        $startTime = microtime(true);
        $this->collector->collect($request, $startTime, $callStack['file'] . ':' . $callStack['line'], $uniqueId);

It seems like $startTime can also be of type string; however, parameter $startTime of Yiisoft\Yii\Debug\Collector\HttpClientCollector::collect() does only seem to accept double, maybe add an additional type check?

        $response = null;

The assignment to $response is dead and can be removed.

        try {
            $response = $this->decorated->sendRequest($request);
        } finally {
            $endTime = microtime(true);
            $this->collector->collectTotalTime($response, $endTime, $uniqueId);

It seems like $endTime can also be of type string; however, parameter $endTime of Yiisoft\Yii\Debug\Collector\HttpClientCollector::collectTotalTime() does only seem to accept double, maybe add an additional type check?

        }

        return $response;
    }
}