Passed
Pull Request — master (#160)
by Dmitriy
11:34 queued 09:07
created

AuthenticationMethodInterfaceProxy   A

Complexity

Total Complexity 3

Size/Duplication

Total Lines 20
Duplicated Lines 0 %

Importance

Changes 0
Metric Value
wmc 3
eloc 8
dl 0
loc 20
rs 10
c 0
b 0
f 0

3 Methods

Rating   Name   Duplication   Size   Complexity  
A authenticate() 0 9 1
A challenge() 0 3 1
A __construct() 0 2 1
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Yiisoft\Yii\Debug\Collector\Web;
6
7
use Psr\Http\Message\ResponseInterface;
8
use Psr\Http\Message\ServerRequestInterface;
9
use Yiisoft\Auth\AuthenticationMethodInterface;
10
use Yiisoft\Auth\IdentityInterface;
11
use Yiisoft\Yii\Debug\Collector\IdentityCollector;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Yiisoft\Yii\Debug\Collector\Web\IdentityCollector. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
Bug introduced by
The type Yiisoft\Yii\Debug\Collector\IdentityCollector was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
12
13
final class AuthenticationMethodInterfaceProxy implements AuthenticationMethodInterface
14
{
15
    public function __construct(private AuthenticationMethodInterface $decorated, private IdentityCollector $collector)
16
    {
17
    }
18
19
    public function authenticate(ServerRequestInterface $request): ?IdentityInterface
20
    {
21
        $identity = null;
0 ignored issues
show
Unused Code introduced by
The assignment to $identity is dead and can be removed.
Loading history...
22
        try {
23
            $identity = $this->decorated->authenticate($request);
24
        } finally {
25
            $this->collector->collect($identity);
26
        }
27
        return $identity;
28
    }
29
30
    public function challenge(ResponseInterface $response): ResponseInterface
31
    {
32
        return $this->decorated->challenge($response);
33
    }
34
}
35