Yiisoft\Yii\Debug\Collector\CommandCollector

Complexity

Total Complexity

13

Size/Duplication

Total Lines	92
Duplicated Lines	0 %

Test Coverage

Coverage

87.23%

Importance

Changes	4
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	reset()	0	3	1
A	getCollected()	0	3	1
A	getIndexData()	0	34	5
B	collect()	0	36	6

<?php

declare(strict_types=1);

namespace Yiisoft\Yii\Debug\Collector;

use RuntimeException;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Event\ConsoleCommandEvent;
use Symfony\Component\Console\Event\ConsoleErrorEvent;
use Symfony\Component\Console\Event\ConsoleEvent;
use Symfony\Component\Console\Event\ConsoleTerminateEvent;

use function get_class;
use function is_object;

final class CommandCollector implements CollectorInterface, IndexCollectorInterface
{
    use CollectorTrait;

    private array $commands = [];

    public function getCollected(): array
    {
        return $this->commands;
    }

    public function collect(object $event): void
    {
        if (!is_object($event) || !$this->isActive()) {
            return;
        }

        if ($event instanceof ConsoleErrorEvent) {
            $this->commands[get_class($event)] = [
                'name' => $event->getInput()->getFirstArgument() ?? '',
                'command' => $event->getCommand(),
                'input' => $event->getInput()->__toString(),

The method __toString() does not exist on Symfony\Component\Console\Input\InputInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Symfony\Component\Console\Input\StreamableInputInterface or Symfony\Component\Console\Input\Input or Symfony\Component\Console\Input\Input. Are you sure you never get one of those?

                'output' => $event->getOutput()->fetch(),

The method fetch() does not exist on Symfony\Component\Console\Output\OutputInterface. It seems like you code against a sub-type of Symfony\Component\Console\Output\OutputInterface such as Symfony\Component\Console\Output\BufferedOutput or Symfony\Component\Console\Output\TrimmedBufferOutput or Yiisoft\Yii\Console\Output\ConsoleBufferedOutput or Yiisoft\Yii\Console\Output\ConsoleBufferedOutput.

                'error' => $event->getError()->getMessage(),
                'exitCode' => $event->getExitCode(),
            ];

            return;
        }

        if ($event instanceof ConsoleTerminateEvent) {
            $this->commands[get_class($event)] = [
                'name' => $event->getCommand()->getName(),
                'command' => $event->getCommand(),
                'input' => $event->getInput()->__toString(),
                'output' => $event->getOutput()->fetch(),
                'exitCode' => $event->getExitCode(),
            ];
            return;
        }

        if ($event instanceof ConsoleEvent) {
            $this->commands[get_class($event)] = [
                'name' => $event->getCommand()->getName(),
                'command' => $event->getCommand(),
                'input' => $event->getInput()->__toString(),
                'output' => $event->getOutput()->fetch(),
            ];
        }
    }

    public function getIndexData(): array
    {
        $eventTypes = [
            ConsoleErrorEvent::class,
            ConsoleTerminateEvent::class,
            ConsoleCommandEvent::class,
        ];

        $commandEvent = null;
        foreach ($eventTypes as $eventType) {
            if (!array_key_exists($eventType, $this->commands)) {
                continue;
            }

            $commandEvent = $this->commands[$eventType];
            break;
        }

        if ($commandEvent === null) {
            $types = array_keys($this->commands);
            throw new RuntimeException(
                sprintf(
                    'Unsupported event type encountered among "%s". Supported only "%s"',
                    implode('", "', $types),
                    implode('", "', $eventTypes),
                )
            );
        }

        return [
            'command' => [
                'name' => $commandEvent['name'],
                'class' => $commandEvent['command'] instanceof Command ? get_class($commandEvent['command']) : null,
                'input' => $commandEvent['input'],
            ],
        ];
    }

    private function reset(): void

The method reset() is not used, and could be removed.

    {
        $this->commands = [];
    }
}