ServiceCollector::collect() - Code Metrics - Inspection of "Dev server" - yiisoft/yii-debug - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#225)

by Dmitriy

created 2023-09-07 16:47 UTC

ServiceCollector::collect() A

↳ Parent: ServiceCollector

Complexity

Conditions	2
Paths	2

Size

Total Lines	27
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	13
c	1
b	0
f	0
nc	2
nop	9
dl	0
loc	27
rs	9.8333
ccs	5
cts	5
cp	1
crap	2

How to fix Many Parameters

<?php

declare(strict_types=1);

namespace Yiisoft\Yii\Debug\Collector;

final class ServiceCollector implements SummaryCollectorInterface
{
    use CollectorTrait;

    private array $items = [];

    public function __construct(private TimelineCollector $timelineCollector)
    {
    }

    public function getCollected(): array
    {
        if (!$this->isActive()) {
            return [];
        }
        return $this->items;
    }

    public function collect(
        string $service,
        string $class,
        string $method,
        ?array $arguments,
        $result,
        string $status,
        ?object $error,
        float $timeStart,
        float $timeEnd
    ): void {
        if (!$this->isActive()) {
            return;
        }

        $this->items[] = [
            'service' => $service,
            'class' => $class,
            'method' => $method,
            'arguments' => $arguments,
            'result' => $result,
            'status' => $status,
            'error' => $error,
            'timeStart' => $timeStart,
            'timeEnd' => $timeEnd,
        ];
        $this->timelineCollector->collect($this, count($this->items));
    }

    public function getSummary(): array
    {
        if (!$this->isActive()) {
            return [];
        }
        return [
            'service' => [
                'total' => count($this->items),
            ],
        ];
    }

    private function reset(): void

    {
        $this->items = [];
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Yii\Debug\Collector;
6
7		final class ServiceCollector implements SummaryCollectorInterface
8		{
9		use CollectorTrait;
10
11		private array $items = [];
12
13	2	public function __construct(private TimelineCollector $timelineCollector)
14		{
15	2	}
16
17		public function getCollected(): array
18	7	{
19		if (!$this->isActive()) {
20		return [];
21		}
22		return $this->items;
23		}
24
25		public function collect(
26		string $service,
27		string $class,
28		string $method,
29	7	?array $arguments,
30	5	$result,
31		string $status,
32		?object $error,
33	2	float $timeStart,
34		float $timeEnd
35		): void {
36		if (!$this->isActive()) {
37		return;
38		}
39
40		$this->items[] = [
41		'service' => $service,
42		'class' => $class,
43		'method' => $method,
44		'arguments' => $arguments,
45		'result' => $result,
46	1	'status' => $status,
47		'error' => $error,
48		'timeStart' => $timeStart,
49		'timeEnd' => $timeEnd,
50	1	];
51		$this->timelineCollector->collect($this, count($this->items));
52		}
53
54		public function getSummary(): array
55	1	{
56		if (!$this->isActive()) {
57	1	return [];
58		}
59		return [
60		'service' => [
61		'total' => count($this->items),
62		],
63		];
64		}
65
66		private function reset(): void
		0 ignored issues – show Unused Code introduced 2020-10-01 10:57 UTC by Report Bug Copy Issue Report The method `reset()` is not used, and could be removed. This check looks for private methods that have been defined, but are not used inside the class. Loading history...
67		{
68		$this->items = [];
69		}
70		}
71

yiisoft / yii-debug

Pull Request — master (#225)

ServiceCollector::collect() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like