Yiisoft\Yii\Debug\Tests\Unit\Collector\VarDumperCollectorTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	collectTestData()	0	3	1
A	checkCollectedData()	0	7	1
A	checkSummaryData()	0	7	1
A	getCollector()	0	3	1

<?php

declare(strict_types=1);

namespace Yiisoft\Yii\Debug\Tests\Unit\Collector;

use Yiisoft\Yii\Debug\Collector\CollectorInterface;
use Yiisoft\Yii\Debug\Collector\TimelineCollector;
use Yiisoft\Yii\Debug\Collector\VarDumperCollector;
use Yiisoft\Yii\Debug\Tests\Shared\AbstractCollectorTestCase;

final class VarDumperCollectorTest extends AbstractCollectorTestCase
{
    /**
     * @param CollectorInterface|VarDumperCollector $collector
     */
    protected function collectTestData(CollectorInterface $collector): void
    {
        $collector->collect('test', 'file:123');

The method collect() does not exist on Yiisoft\Yii\Debug\Collector\CollectorInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Yiisoft\Yii\Debug\Collector\SummaryCollectorInterface or Yiisoft\Yii\Debug\Tests\Unit\Support\DummyCollector. Are you sure you never get one of those?

    }

    protected function getCollector(): CollectorInterface
    {
        return new VarDumperCollector(new TimelineCollector());
    }

    protected function checkCollectedData(array $data): void
    {
        parent::checkCollectedData($data);
        $this->assertCount(1, $data);
        $this->assertCount(2, $data[0]);
        $this->assertSame('test', $data[0]['variable']);
        $this->assertSame('file:123', $data[0]['line']);
    }

    protected function checkSummaryData(array $data): void
    {
        parent::checkSummaryData($data);
        $this->assertCount(1, $data);
        $this->assertArrayHasKey('var-dumper', $data);

It seems like $data can also be of type Countable; however, parameter $array of PHPUnit\Framework\Assert::assertArrayHasKey() does only seem to accept ArrayAccess|array, maybe add an additional type check?

        $this->assertArrayHasKey('total', $data['var-dumper']);
        $this->assertEquals(1, $data['var-dumper']['total']);
    }
}