MigrationConfig::getAlias() - Code Metrics - Inspection of "OOP config concept [NO MERGE]" - yiisoft/yii-cycle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#5)

unknown

created 2019-11-11 15:41 UTC

MigrationConfig::getAlias() A

↳ Parent: MigrationConfig

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	3
ccs	0
cts	3
cp	0
crap	2
rs	10

<?php

namespace Yiisoft\Yii\Cycle;

use Yiisoft\Aliases\Aliases;
use Yiisoft\Yii\Cycle\Config\BaseConfig;
use Yiisoft\Yii\Cycle\Config\Params;

/**
 * @property string $directory
 * @property string $namespace
 * @property string $table
 * @property bool   $safe
 */
class MigrationConfig extends BaseConfig
{
    protected $data = [
        'directory' => '@root/migrations',
        'namespace' => 'App\\Migration',
        'table'     => 'migration',
        'safe'      => false,
    ];

    /** @var Aliases */
    private $objAliases;

    public function __construct(Params $params, Aliases $aliases)
    {
        $this->objAliases = $aliases;
        parent::__construct($params);
    }

    protected function getDirectory(): string
    {
        return $this->getAlias($this->data['directory']);
    }

    protected function getAlias(string $alias): string
    {
        return $this->objAliases->get($alias, true);

    }
}


1			<?php
2
3			namespace Yiisoft\Yii\Cycle;
4
5			use Yiisoft\Aliases\Aliases;
6			use Yiisoft\Yii\Cycle\Config\BaseConfig;
7			use Yiisoft\Yii\Cycle\Config\Params;
8
9			/**
10			* @property string $directory
11			* @property string $namespace
12			* @property string $table
13			* @property bool $safe
14			*/
15			class MigrationConfig extends BaseConfig
16			{
17			protected $data = [
18			'directory' => '@root/migrations',
19			'namespace' => 'App\\Migration',
20			'table' => 'migration',
21			'safe' => false,
22			];
23
24			/** @var Aliases */
25			private $objAliases;
26
27			public function __construct(Params $params, Aliases $aliases)
28			{
29			$this->objAliases = $aliases;
30			parent::__construct($params);
31			}
32
33			protected function getDirectory(): string
34			{
35			return $this->getAlias($this->data['directory']);
36			}
37
38			protected function getAlias(string $alias): string
39			{
40			return $this->objAliases->get($alias, true);
			0 ignored issues – show Bug Best Practice introduced 2019-10-30 16:59 UTC by Report Bug Copy Issue Report The expression `return $this->objAliases->get($alias, true)` could return the type `boolean` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
41			}
42			}
43

yiisoft / yii-cycle

Pull Request — master (#5)

MigrationConfig::getAlias() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like