DbalConfig::setConnections() - Code Metrics - Inspection of "OOP config concept [NO MERGE]" - yiisoft/yii-cycle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#5)

unknown

created 2019-11-11 15:41 UTC

DbalConfig::setConnections() A

↳ Parent: DbalConfig

Complexity

Conditions	4
Paths	3

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	6
c	1
b	0
f	0
nc	3
nop	1
dl	0
loc	9
ccs	0
cts	8
cp	0
crap	20
rs	10

<?php

namespace Yiisoft\Yii\Cycle;

use Spiral\Database\Config\DatabaseConfig;
use Yiisoft\Aliases\Aliases;
use Yiisoft\Yii\Cycle\Config\BaseConfig;
use Yiisoft\Yii\Cycle\Config\Params;

/**
 * @property string $default
 * @property array  $aliases
 * @property array  $databases
 * @property array  $connections
 */
class DbalConfig extends BaseConfig
{
    protected $data = [
        'default'     => '',
        'aliases'     => [],
        'databases'   => [],
        'connections' => [],
    ];

    /** @var Aliases */
    private $objAliases;

    public function __construct(Params $params, Aliases $aliases)
    {
        $this->objAliases = $aliases;
        parent::__construct($params);
    }

    public function prepareConfig(): DatabaseConfig
    {
        return new DatabaseConfig($this->data);
    }

    protected function setConnections($data): void
    {
        $this->data['connections'] = $data;
        foreach ($this->data['connections'] as &$connection) {
            // if connection option contain alias in path
            if (isset($connection['connection']) && preg_match('/^(?<proto>\w+:)?@/', $connection['connection'], $m)) {
                $proto = $m['proto'];
                $path = $this->getAlias(substr($connection['connection'], strlen($proto)));
                $connection['connection'] = $proto . $path;
            }
        }
    }

    protected function getAlias(string $alias): string
    {
        return $this->objAliases->get($alias, true);

    }
}


1			<?php
2
3			namespace Yiisoft\Yii\Cycle;
4
5			use Spiral\Database\Config\DatabaseConfig;
6			use Yiisoft\Aliases\Aliases;
7			use Yiisoft\Yii\Cycle\Config\BaseConfig;
8			use Yiisoft\Yii\Cycle\Config\Params;
9
10			/**
11			* @property string $default
12			* @property array $aliases
13			* @property array $databases
14			* @property array $connections
15			*/
16			class DbalConfig extends BaseConfig
17			{
18			protected $data = [
19			'default' => '',
20			'aliases' => [],
21			'databases' => [],
22			'connections' => [],
23			];
24
25			/** @var Aliases */
26			private $objAliases;
27
28			public function __construct(Params $params, Aliases $aliases)
29			{
30			$this->objAliases = $aliases;
31			parent::__construct($params);
32			}
33
34			public function prepareConfig(): DatabaseConfig
35			{
36			return new DatabaseConfig($this->data);
37			}
38
39			protected function setConnections($data): void
40			{
41			$this->data['connections'] = $data;
42			foreach ($this->data['connections'] as &$connection) {
43			// if connection option contain alias in path
44			if (isset($connection['connection']) && preg_match('/^(?<proto>\w+:)?@/', $connection['connection'], $m)) {
45			$proto = $m['proto'];
46			$path = $this->getAlias(substr($connection['connection'], strlen($proto)));
47			$connection['connection'] = $proto . $path;
48			}
49			}
50			}
51
52			protected function getAlias(string $alias): string
53			{
54			return $this->objAliases->get($alias, true);
			0 ignored issues – show Bug Best Practice introduced 2019-10-30 16:59 UTC by Report Bug Copy Issue Report The expression `return $this->objAliases->get($alias, true)` could return the type `boolean` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
55			}
56			}
57

yiisoft / yii-cycle

Pull Request — master (#5)

DbalConfig::setConnections() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like