CycleDbalConfig::setConnections() - Code Metrics - Inspection of "OOP config concept [NO MERGE]" - yiisoft/yii-cycle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#5)

unknown

created 2019-11-13 19:53 UTC

CycleDbalConfig::setConnections() A

↳ Parent: CycleDbalConfig

Complexity

Conditions	4
Paths	3

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
cc	4
eloc	6
nc	3
nop	1
dl	0
loc	9
ccs	0
cts	8
cp	0
crap	20
rs	10
c	0
b	0
f	0

<?php

namespace Yiisoft\Yii\Cycle;

use Spiral\Database\Config\DatabaseConfig;
use Yiisoft\Aliases\Aliases;
use Yiisoft\Yii\Cycle\Config\BaseConfig;

/**
 * @property-read string $default
 * @property-read array  $aliases
 * @property-read array  $databases
 * @property-read array  $connections
 */
class CycleDbalConfig extends BaseConfig
{
    protected $default     = '';
    protected $aliases     = [];
    protected $databases   = [];
    protected $connections = [];

    // private property will be ignored in toArray() method
    /** @var Aliases */
    private $objAliases;

    public function __construct(Aliases $aliases)
    {
        $this->objAliases = $aliases;
    }

    public function prepareConfig(): DatabaseConfig
    {
        return new DatabaseConfig($this->toArray());
    }

    protected function setConnections($data): void
    {
        $this->connections = $data;

        foreach ($this->connections as &$connection) {
            // if connection option contain alias in path
            if (isset($connection['connection']) && preg_match('/^(?<proto>\w+:)?@/', $connection['connection'], $m)) {
                $proto = $m['proto'];
                $path = $this->getAlias(substr($connection['connection'], strlen($proto)));
                $connection['connection'] = $proto . $path;
            }
        }
    }

    protected function getAlias(string $alias): string
    {
        return $this->objAliases->get($alias, true);

    }
}


1			<?php
2
3			namespace Yiisoft\Yii\Cycle;
4
5			use Spiral\Database\Config\DatabaseConfig;
6			use Yiisoft\Aliases\Aliases;
7			use Yiisoft\Yii\Cycle\Config\BaseConfig;
8
9			/**
10			* @property-read string $default
11			* @property-read array $aliases
12			* @property-read array $databases
13			* @property-read array $connections
14			*/
15			class CycleDbalConfig extends BaseConfig
16			{
17			protected $default = '';
18			protected $aliases = [];
19			protected $databases = [];
20			protected $connections = [];
21
22			// private property will be ignored in toArray() method
23			/** @var Aliases */
24			private $objAliases;
25
26			public function __construct(Aliases $aliases)
27			{
28			$this->objAliases = $aliases;
29			}
30
31			public function prepareConfig(): DatabaseConfig
32			{
33			return new DatabaseConfig($this->toArray());
34			}
35
36			protected function setConnections($data): void
37			{
38			$this->connections = $data;
			0 ignored issues – show Bug introduced 2019-11-13 19:55 UTC by Report Bug Copy Issue Report The property `connections` is declared read-only in `Yiisoft\Yii\Cycle\CycleDbalConfig`. Loading history...
39			foreach ($this->connections as &$connection) {
40			// if connection option contain alias in path
41			if (isset($connection['connection']) && preg_match('/^(?<proto>\w+:)?@/', $connection['connection'], $m)) {
42			$proto = $m['proto'];
43			$path = $this->getAlias(substr($connection['connection'], strlen($proto)));
44			$connection['connection'] = $proto . $path;
45			}
46			}
47			}
48
49			protected function getAlias(string $alias): string
50			{
51			return $this->objAliases->get($alias, true);
			0 ignored issues – show Bug Best Practice introduced 2019-10-30 16:59 UTC by Report Bug Copy Issue Report The expression `return $this->objAliases->get($alias, true)` could return the type `boolean` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
52			}
53			}
54

yiisoft / yii-cycle

Pull Request — master (#5)

CycleDbalConfig::setConnections() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like