Yiisoft\Yii\Cycle\DataReader\Cache\CachedCount

Complexity

Total Complexity

3

Size/Duplication

Total Lines	15
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	getCount()	0	7	2

<?php

declare(strict_types=1);

namespace Yiisoft\Yii\Cycle\DataReader\Cache;

use Countable;

final class CachedCount
{
    private ?int $count = null;
    private ?Countable $collection;
    public function __construct(Countable $collection)
    {
        $this->collection = $collection;
    }
    public function getCount(): int
    {
        if ($this->count === null) {
            $this->count = (int) $this->collection->count();

The method count() does not exist on null.

            $this->collection = null;
        }
        return $this->count;

The expression return $this->count could return the type null which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

    }
}