Yiisoft\Yii\Cycle\MigrationConfig

Complexity

Total Complexity

3

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getDirectory()	0	3	1
A	__construct()	0	4	1
A	getAlias()	0	3	1

<?php

namespace Yiisoft\Yii\Cycle;

use Spiral\Database\Config\DatabaseConfig;
use Yiisoft\Aliases\Aliases;
use Yiisoft\Yii\Cycle\Config\BaseConfig;
use Yiisoft\Yii\Cycle\Config\Params;

/**
 * Class CommonConfig
 * @package Yiisoft\Yii\Cycle\Config
 *
 * @property-read string $directory
 * @property-read string $namespace
 * @property-read string $table
 * @property-read bool   $safe
 */
class MigrationConfig extends BaseConfig
{
    protected $data = [
        'directory' => '@root/migrations',
        'namespace' => 'App\\Migration',
        'table'     => 'migration',
        'safe'      => false,
    ];

    /** @var Aliases */
    private $objAliases;

    public function __construct(Params $params, Aliases $aliases)
    {
        $this->objAliases = $aliases;
        parent::__construct($params);
    }

    protected function getDirectory(): string
    {
        return $this->getAlias($this->data['directory']);
    }

    protected function getAlias(string $alias): string
    {
        return $this->objAliases->get($alias, true);

The expression return $this->objAliases->get($alias, true) could return the type boolean which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}