Yiisoft\Yii\Cycle\DbalConfig

Complexity

Total Complexity

7

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	prepareConfig()	0	3	1
A	getAlias()	0	3	1
A	setConnections()	0	9	4

<?php

namespace Yiisoft\Yii\Cycle;

use Spiral\Database\Config\DatabaseConfig;
use Yiisoft\Aliases\Aliases;
use Yiisoft\Yii\Cycle\Config\BaseConfig;
use Yiisoft\Yii\Cycle\Config\Params;

/**
 * @property-read string $default
 * @property-read array  $aliases
 * @property-read array  $databases
 * @property-read array  $connections
 */
class DbalConfig extends BaseConfig
{
    protected $default     = '';
    protected $aliases     = [];
    protected $databases   = [];
    protected $connections = [];

    // private property will be ignored in toArray() method
    /** @var Aliases */
    private $objAliases;

    public function __construct(Params $params, Aliases $aliases)
    {
        $this->objAliases = $aliases;
        parent::__construct($params);
    }

    public function prepareConfig(): DatabaseConfig
    {
        return new DatabaseConfig($this->toArray());
    }

    protected function setConnections($data): void
    {
        $this->connections = $data;

The property connections is declared read-only in Yiisoft\Yii\Cycle\DbalConfig.

        foreach ($this->connections as &$connection) {
            // if connection option contain alias in path
            if (isset($connection['connection']) && preg_match('/^(?<proto>\w+:)?@/', $connection['connection'], $m)) {
                $proto = $m['proto'];
                $path = $this->getAlias(substr($connection['connection'], strlen($proto)));
                $connection['connection'] = $proto . $path;
            }
        }
    }

    protected function getAlias(string $alias): string
    {
        return $this->objAliases->get($alias, true);

The expression return $this->objAliases->get($alias, true) could return the type boolean which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}