Game::execute() - Code Metrics - Inspection of "Fix list command" - yiisoft/yii-console - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#183)

by Alexander

created 2023-05-28 15:24 UTC

Game::execute() A

↳ Parent: Game

Complexity

Conditions	4
Paths	4

Size

Total Lines	26
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	4
eloc	16
c	2
b	0
f	0
nc	4
nop	2
dl	0
loc	26
ccs	0
cts	16
cp	0
crap	20
rs	9.7333

<?php

declare(strict_types=1);

namespace Yiisoft\Yii\Console\Command;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Helper\QuestionHelper;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\Question;
use Symfony\Component\Console\Style\SymfonyStyle;

final class Game extends Command
{
    protected static $defaultName = '|yii';
    protected static $defaultDescription = 'A Guessing Game';

    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $steps = 1;
        $number = random_int(0, 100);

        $io = new SymfonyStyle($input, $output);
        $io->title('Welcome to the Guessing Game!');


        /** @var QuestionHelper $helper */
        $helper = $this->getHelper('question');
        $question = new Question('Please enter a number between 0 and 100: ');

        while (true) {
            $answer = (int) $helper->ask($input, $output, $question);

            if ($answer === $number) {
                $io->success('You win! You guessed the number in ' . $steps . ' steps.');
                return 0;
            }

            $steps++;
            if ($answer > $number) {
                $io->warning('Too high!');
            } else {
                $io->warning('Too low!');
            }
        }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\Yii\Console\Command;
6
7			use Symfony\Component\Console\Command\Command;
8			use Symfony\Component\Console\Helper\QuestionHelper;
9			use Symfony\Component\Console\Input\InputInterface;
10			use Symfony\Component\Console\Output\OutputInterface;
11			use Symfony\Component\Console\Question\Question;
12			use Symfony\Component\Console\Style\SymfonyStyle;
13
14			final class Game extends Command
15			{
16			protected static $defaultName = '\|yii';
17			protected static $defaultDescription = 'A Guessing Game';
18
19			protected function execute(InputInterface $input, OutputInterface $output): int
20			{
21			$steps = 1;
22			$number = random_int(0, 100);
23
24			$io = new SymfonyStyle($input, $output);
25			$io->title('Welcome to the Guessing Game!');
26
27
28			/** @var QuestionHelper $helper */
29			$helper = $this->getHelper('question');
30			$question = new Question('Please enter a number between 0 and 100: ');
31
32			while (true) {
33			$answer = (int) $helper->ask($input, $output, $question);
34
35			if ($answer === $number) {
36			$io->success('You win! You guessed the number in ' . $steps . ' steps.');
37			return 0;
38			}
39
40			$steps++;
41			if ($answer > $number) {
42			$io->warning('Too high!');
43			} else {
44			$io->warning('Too low!');
45			}
46			}
			0 ignored issues – show Bug Best Practice introduced 2023-05-28 15:25 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `integer`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
47			}
48			}
49

yiisoft / yii-console

Pull Request — master (#183)

Game::execute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like