AbstractSignature::verify() - Code Metrics - Inspection of "Refactoring" - yiisoft/yii-auth-client - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#21)

by Rustam

created 2021-01-27 18:44 UTC

AbstractSignature::verify() A

↳ Parent: AbstractSignature

Complexity

Conditions	3
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	4
nc	2
nop	3
dl	0
loc	8
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Yiisoft\Yii\AuthClient\Signature;

/**
 * BaseMethod is a base class for the OAuth signature methods.
 */
abstract class AbstractSignature
{
    /**
     * Return the canonical name of the Signature Method.
     *
     * @return string method name.
     */
    abstract public function getName(): string;

    /**
     * Verifies given OAuth request.
     *
     * @param string $signature signature to be verified.
     * @param string $baseString signature base string.
     * @param string $key signature key.
     *
     * @return bool success.
     */
    public function verify(string $signature, string $baseString, string $key): bool
    {
        $expectedSignature = $this->generateSignature($baseString, $key);
        if (empty($signature) || empty($expectedSignature)) {
            return false;
        }

        return strcmp($expectedSignature, $signature) === 0;
    }

    /**
     * Generates OAuth request signature.
     *
     * @param string $baseString signature base string.
     * @param string $key signature key.
     *
     * @return string signature string.
     */
    abstract public function generateSignature(string $baseString, string $key): string;
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\Yii\AuthClient\Signature;
6
7			/**
8			* BaseMethod is a base class for the OAuth signature methods.
9			*/
10			abstract class AbstractSignature
11			{
12			/**
13			* Return the canonical name of the Signature Method.
14			*
15			* @return string method name.
16			*/
17			abstract public function getName(): string;
18
19			/**
20			* Verifies given OAuth request.
21			*
22			* @param string $signature signature to be verified.
23			* @param string $baseString signature base string.
24			* @param string $key signature key.
25			*
26			* @return bool success.
27			*/
28			public function verify(string $signature, string $baseString, string $key): bool
29			{
30			$expectedSignature = $this->generateSignature($baseString, $key);
31			if (empty($signature) \|\| empty($expectedSignature)) {
32			return false;
33			}
34
35			return strcmp($expectedSignature, $signature) === 0;
36			}
37
38			/**
39			* Generates OAuth request signature.
40			*
41			* @param string $baseString signature base string.
42			* @param string $key signature key.
43			*
44			* @return string signature string.
45			*/
46			abstract public function generateSignature(string $baseString, string $key): string;
47			}
48

yiisoft / yii-auth-client

Pull Request — master (#21)

AbstractSignature::verify() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like