Passed
Pull Request — master (#293)
by
unknown
02:21
created

SimpleRuleHandlerContainer   A

Complexity

Total Complexity 6

Size/Duplication

Total Lines 29
Duplicated Lines 0 %

Test Coverage

Coverage 100%

Importance

Changes 1
Bugs 0 Features 0
Metric Value
wmc 6
eloc 12
c 1
b 0
f 0
dl 0
loc 29
ccs 12
cts 12
cp 1
rs 10

2 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 2 1
A resolve() 0 21 5
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Yiisoft\Validator;
6
7
use Error;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Yiisoft\Validator\Error. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
8
use InvalidArgumentException;
9
use Yiisoft\Translator\TranslatorInterface;
10
use Yiisoft\Validator\Exception\RuleHandlerInterfaceNotImplementedException;
11
use Yiisoft\Validator\Exception\RuleHandlerNotFoundException;
12
13
use function array_key_exists;
14
15
final class SimpleRuleHandlerContainer implements RuleHandlerResolverInterface
16
{
17
    private array $instances = [];
18
19 657
    public function __construct(private TranslatorInterface $translator)
20
    {
21
    }
22
23 115
    public function resolve(string $className): RuleHandlerInterface
24
    {
25 115
        if (!class_exists($className)) {
26 1
            throw new RuleHandlerNotFoundException($className);
27
        }
28
29 114
        if (array_key_exists($className, $this->instances)) {
30 35
            return $this->instances[$className];
31
        }
32
33
        try {
34 101
            $classInstance = new $className(translator: $this->translator);
35 3
        } catch (Error) {
36 3
            $classInstance = new $className();
37
        }
38
39 101
        if (!$classInstance instanceof RuleHandlerInterface) {
40 1
            throw new RuleHandlerInterfaceNotImplementedException($className);
41
        }
42
43 100
        return $this->instances[$className] = $classInstance;
44
    }
45
}
46