Rules::normalizeRule() - Code Metrics - Inspection of "Creating array of data for usage on frontend (clie..." - yiisoft/validator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#81)

by Def

created 2020-09-03 18:23 UTC

Rules::normalizeRule() A

↳ Parent: Rules

Complexity

Conditions	3
Paths	4

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3.0416

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	5
c	1
b	0
f	0
nc	4
nop	1
dl	0
loc	11
ccs	5
cts	6
cp	0.8333
crap	3.0416
rs	10

<?php

declare(strict_types=1);

namespace Yiisoft\Validator;

use Yiisoft\Validator\Rule\Callback;

/**
 * Rules represents multiple rules for a single value
 */
final class Rules
{
    /**
     * @var Rule[]
     */
    private array $rules = [];

    public function __construct(iterable $rules = [])
    {
        foreach ($rules as $rule) {
            $this->add($rule);
        }
    }

    /**
     * @param Rule|callable
     */
    public function add($rule): void
    {
        $this->rules[] = $this->normalizeRule($rule);
    }

    public function validate($value, DataSetInterface $dataSet = null, bool $previousRulesErrored = false): Result
    {
        $compoundResult = new Result();
        foreach ($this->rules as $rule) {
            $ruleResult = $rule->validate($value, $dataSet, $previousRulesErrored);
            if ($ruleResult->isValid() === false) {
                $previousRulesErrored = true;
                foreach ($ruleResult->getErrors() as $message) {
                    $compoundResult->addError($message);
                }
            }
        }
        return $compoundResult;
    }

    private function normalizeRule($rule): Rule
    {
        if (is_callable($rule)) {
            $rule = new Callback($rule);
        }

        if (!$rule instanceof Rule) {
            throw new \InvalidArgumentException('Rule should be either instance of Rule class or a callable');
        }

        return $rule;
    }

    /**
     * Return rules as array
     * @return array
     */
    public function asArray(): array
    {
        $arrayOfRules = [];
        foreach ($this->rules as $rule) {
            $arrayOfRules[] = array_merge([$rule->getName()], $rule->getOptions());
        }
        return $arrayOfRules;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Validator;
6
7		use Yiisoft\Validator\Rule\Callback;
8
9		/**
10		* Rules represents multiple rules for a single value
11		*/
12		final class Rules
13		{
14		/**
15		* @var Rule[]
16		*/
17		private array $rules = [];
18
19	17	public function __construct(iterable $rules = [])
20		{
21	17	foreach ($rules as $rule) {
22	11	$this->add($rule);
23		}
24		}
25
26		/**
27		* @param Rule\|callable
28		*/
29	17	public function add($rule): void
30		{
31	17	$this->rules[] = $this->normalizeRule($rule);
32		}
33
34	13	public function validate($value, DataSetInterface $dataSet = null, bool $previousRulesErrored = false): Result
35		{
36	13	$compoundResult = new Result();
37	13	foreach ($this->rules as $rule) {
38	13	$ruleResult = $rule->validate($value, $dataSet, $previousRulesErrored);
39	13	if ($ruleResult->isValid() === false) {
40	13	$previousRulesErrored = true;
41	13	foreach ($ruleResult->getErrors() as $message) {
42	13	$compoundResult->addError($message);
43		}
44		}
45		}
46	13	return $compoundResult;
47		}
48
49	17	private function normalizeRule($rule): Rule
50		{
51	17	if (is_callable($rule)) {
52	3	$rule = new Callback($rule);
53		}
54
55	17	if (!$rule instanceof Rule) {
56		throw new \InvalidArgumentException('Rule should be either instance of Rule class or a callable');
57		}
58
59	17	return $rule;
60		}
61
62		/**
63		* Return rules as array
64		* @return array
65		*/
66	3	public function asArray(): array
67		{
68	3	$arrayOfRules = [];
69	3	foreach ($this->rules as $rule) {
70	3	$arrayOfRules[] = array_merge([$rule->getName()], $rule->getOptions());
71		}
72	3	return $arrayOfRules;
73		}
74		}
75

yiisoft / validator

Pull Request — master (#81)

Rules::normalizeRule() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like