Yiisoft\Validator\ValidatorFactory::normalizeRule()

Complexity

Conditions	4
Paths	6

Size

Total Lines	17
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

<?php
    private function normalizeRule($rule): Rule
    {
        if (is_callable($rule)) {
            $rule = new Callback($rule);

It seems like $rule can also be of type Yiisoft\Validator\Rule; however, parameter $callback of Yiisoft\Validator\Rule\Callback::__construct() does only seem to accept callable, maybe add an additional type check?

        }

        if (!$rule instanceof Rule) {
            throw new \InvalidArgumentException(
                'Rule should be either instance of Rule class or a callable'
            );
        }

        if ($this->formatter !== null) {
            $rule = $rule->formatter($this->formatter);
        }

        return $rule;

The expression return $rule could return the type callable which is incompatible with the type-hinted return Yiisoft\Validator\Rule. Consider adding an additional type-check to rule them out.

    }