Result::getErrorsIndexedByPath() - Code Metrics - Inspection of "Validate nested data, add error details" - yiisoft/validator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#151)

unknown

created 2022-02-03 07:40 UTC

Result::getErrorsIndexedByPath() A

↳ Parent: Result

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	1
dl	0
loc	9
ccs	6
cts	6
cp	1
crap	2
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Yiisoft\Validator;

use Yiisoft\Arrays\ArrayHelper;

final class Result
{
    /**
     * @var Error[]
     */
    private array $errors = [];

    public function isValid(): bool
    {
        return $this->errors === [];
    }

    /**
     * @psalm-param list<int|string>|null $valuePath
     */
    public function addError(string $message, array $valuePath = []): void
    {
        $this->errors[] = new Error($message, $valuePath);
    }

    /**
     * @return Error[]
     */
    public function getErrorObjects(): array
    {
        return $this->errors;
    }

    /**
     * @return string[]
     */
    public function getErrors(): array
    {
        return ArrayHelper::getColumn($this->errors, function ($error) {
            /** @var Error $error */
            return $error->getMessage();
        });
    }

    public function getNestedErrors(string $separator = '.'): array
    {
        $valuePathCountMap = [];
        $errors = [];
        foreach ($this->errors as $error) {
            $stringValuePath = implode($separator, $error->getValuePath());
            $valuePathCount = $valuePathCountMap[$stringValuePath] ?? 0;
            $errorValuePath = "$stringValuePath.$valuePathCount";

            ArrayHelper::setValueByPath($errors, $errorValuePath, $error->getMessage());
            $valuePathCount++;
            $valuePathCountMap[$stringValuePath] = $valuePathCount;
        }

        return $errors;
    }

    public function getErrorsIndexedByPath(string $separator = '.'): array
    {
        $errors = [];
        foreach ($this->errors as $error) {
            $stringValuePath = implode($separator, $error->getValuePath());
            $errors[$stringValuePath][] = $error->getMessage();
        }

        return $errors;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Validator;
6
7		use Yiisoft\Arrays\ArrayHelper;
8
9		final class Result
10		{
11		/**
12		* @var Error[]
13		*/
14		private array $errors = [];
15
16	159	public function isValid(): bool
17		{
18	159	return $this->errors === [];
19		}
20
21		/**
22		* @psalm-param list<int\|string>\|null $valuePath
23		*/
24	129	public function addError(string $message, array $valuePath = []): void
25		{
26	129	$this->errors[] = new Error($message, $valuePath);
27	129	}
28
29		/**
30		* @return Error[]
31		*/
32	17	public function getErrorObjects(): array
33		{
34	17	return $this->errors;
35		}
36
37		/**
38		* @return string[]
39		*/
40	34	public function getErrors(): array
41		{
42	34	return ArrayHelper::getColumn($this->errors, function ($error) {
43		/** @var Error $error */
44	31	return $error->getMessage();
45	34	});
46		}
47
48	1	public function getNestedErrors(string $separator = '.'): array
49		{
50	1	$valuePathCountMap = [];
51	1	$errors = [];
52	1	foreach ($this->errors as $error) {
53	1	$stringValuePath = implode($separator, $error->getValuePath());
54	1	$valuePathCount = $valuePathCountMap[$stringValuePath] ?? 0;
55	1	$errorValuePath = "$stringValuePath.$valuePathCount";
56
57	1	ArrayHelper::setValueByPath($errors, $errorValuePath, $error->getMessage());
58	1	$valuePathCount++;
59	1	$valuePathCountMap[$stringValuePath] = $valuePathCount;
60		}
61
62	1	return $errors;
63		}
64
65	1	public function getErrorsIndexedByPath(string $separator = '.'): array
66		{
67	1	$errors = [];
68	1	foreach ($this->errors as $error) {
69	1	$stringValuePath = implode($separator, $error->getValuePath());
70	1	$errors[$stringValuePath][] = $error->getMessage();
71		}
72
73	1	return $errors;
74		}
75		}
76

yiisoft / validator

Pull Request — master (#151)

Result::getErrorsIndexedByPath() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like