EmailTest::dataValidationFailed() - Code Metrics - Inspection of "Add `OneOf` rule" - yiisoft/validator - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#619)

by Alexander
created 2023-08-16 08:42 UTC
EmailTest::dataValidationFailed() B

↳ Parent: EmailTest
Complexity

Conditions	1
Paths	1
Size

Total Lines	132
Code Lines	95
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
eloc	95
c	0
b	0
f	0
nc	1
nop	0
dl	0
loc	132
cc	1
rs	8.109
How to fix Long Method

<?php

declare(strict_types=1);

namespace Yiisoft\Validator\Tests\Rule;

use InvalidArgumentException;
use Yiisoft\Validator\Rule\Email;
use Yiisoft\Validator\Rule\EmailHandler;
use Yiisoft\Validator\Tests\Rule\Base\DifferentRuleInHandlerTestTrait;
use Yiisoft\Validator\Tests\Rule\Base\RuleTestCase;
use Yiisoft\Validator\Tests\Rule\Base\RuleWithOptionsTestTrait;
use Yiisoft\Validator\Tests\Rule\Base\SkipOnErrorTestTrait;
use Yiisoft\Validator\Tests\Rule\Base\WhenTestTrait;

final class EmailTest extends RuleTestCase
{
    use DifferentRuleInHandlerTestTrait;
    use RuleWithOptionsTestTrait;
    use SkipOnErrorTestTrait;
    use WhenTestTrait;

    public function dataInvalidConfiguration(): array
    {
        return [
            [['pattern' => ''], 'Pattern can\'t be empty.'],
            [['fullPattern' => ''], 'Full pattern can\'t be empty.'],
            [['idnEmailPattern' => ''], 'IDN e-mail pattern can\'t be empty.'],
        ];
    }

    /**
     * @dataProvider dataInvalidConfiguration
     */
    public function testinvalidConfiguration(array $arguments, string $expectedExceptionMessage): void
    {
        $this->expectException(InvalidArgumentException::class);
        $this->expectExceptionMessage($expectedExceptionMessage);
        new Email(...$arguments);
        new Email(/** @scrutinizer ignore-type */ ...$arguments);
    }

    public function testGetName(): void
    {
        $rule = new Email();
        $this->assertSame('email', $rule->getName());
    }

    public function dataOptions(): array
    {
        return [
            [
                new Email(),
                [
                    'pattern' => '/^[a-zA-Z0-9!#$%&\'*+\\/=?^_`{|}~-]+(?:\.[a-zA-Z0-9!#$%&\'*+\\/=?^_`{|}~-]+)*@(?:[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?\.)+[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?$/',
                    'fullPattern' => '/^[^@]*<[a-zA-Z0-9!#$%&\'*+\\/=?^_`{|}~-]+(?:\.[a-zA-Z0-9!#$%&\'*+\\/=?^_`{|}~-]+)*@(?:[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?\.)+[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?>$/',
                    'idnEmailPattern' => '/^([a-zA-Z0-9._%+-]+)@((\[\d{1,3}\.\d{1,3}\.\d{1,3}\.)|(([\w-]+\.)+))([a-zA-Z]{2,4}|\d{1,3})(\]?)$/',
                    'allowName' => false,
                    'checkDns' => false,
                    'enableIdn' => false,
                    'incorrectInputMessage' => [
                        'template' => 'The value must be a string.',
                        'parameters' => [],
                    ],
                    'message' => [
                        'template' => 'This value is not a valid email address.',
                        'parameters' => [],
                    ],
                    'skipOnEmpty' => false,
                    'skipOnError' => false,
                ],
            ],
            [
                new Email(allowName: true),
                [
                    'pattern' => '/^[a-zA-Z0-9!#$%&\'*+\\/=?^_`{|}~-]+(?:\.[a-zA-Z0-9!#$%&\'*+\\/=?^_`{|}~-]+)*@(?:[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?\.)+[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?$/',
                    'fullPattern' => '/^[^@]*<[a-zA-Z0-9!#$%&\'*+\\/=?^_`{|}~-]+(?:\.[a-zA-Z0-9!#$%&\'*+\\/=?^_`{|}~-]+)*@(?:[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?\.)+[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?>$/',
                    'idnEmailPattern' => '/^([a-zA-Z0-9._%+-]+)@((\[\d{1,3}\.\d{1,3}\.\d{1,3}\.)|(([\w-]+\.)+))([a-zA-Z]{2,4}|\d{1,3})(\]?)$/',
                    'allowName' => true,
                    'checkDns' => false,
                    'enableIdn' => false,
                    'incorrectInputMessage' => [
                        'template' => 'The value must be a string.',
                        'parameters' => [],
                    ],
                    'message' => [
                        'template' => 'This value is not a valid email address.',
                        'parameters' => [],
                    ],
                    'skipOnEmpty' => false,
                    'skipOnError' => false,
                ],
            ],
            [
                new Email(allowName: true, checkDns: true),
                [
                    'pattern' => '/^[a-zA-Z0-9!#$%&\'*+\\/=?^_`{|}~-]+(?:\.[a-zA-Z0-9!#$%&\'*+\\/=?^_`{|}~-]+)*@(?:[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?\.)+[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?$/',
                    'fullPattern' => '/^[^@]*<[a-zA-Z0-9!#$%&\'*+\\/=?^_`{|}~-]+(?:\.[a-zA-Z0-9!#$%&\'*+\\/=?^_`{|}~-]+)*@(?:[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?\.)+[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?>$/',
                    'idnEmailPattern' => '/^([a-zA-Z0-9._%+-]+)@((\[\d{1,3}\.\d{1,3}\.\d{1,3}\.)|(([\w-]+\.)+))([a-zA-Z]{2,4}|\d{1,3})(\]?)$/',
                    'allowName' => true,
                    'checkDns' => true,
                    'enableIdn' => false,
                    'incorrectInputMessage' => [
                        'template' => 'The value must be a string.',
                        'parameters' => [],
                    ],
                    'message' => [
                        'template' => 'This value is not a valid email address.',
                        'parameters' => [],
                    ],
                    'skipOnEmpty' => false,
                    'skipOnError' => false,
                ],
            ],
            [
                new Email(allowName: true, enableIdn: true),
                [
                    'pattern' => '/^[a-zA-Z0-9!#$%&\'*+\\/=?^_`{|}~-]+(?:\.[a-zA-Z0-9!#$%&\'*+\\/=?^_`{|}~-]+)*@(?:[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?\.)+[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?$/',
                    'fullPattern' => '/^[^@]*<[a-zA-Z0-9!#$%&\'*+\\/=?^_`{|}~-]+(?:\.[a-zA-Z0-9!#$%&\'*+\\/=?^_`{|}~-]+)*@(?:[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?\.)+[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?>$/',
                    'idnEmailPattern' => '/^([a-zA-Z0-9._%+-]+)@((\[\d{1,3}\.\d{1,3}\.\d{1,3}\.)|(([\w-]+\.)+))([a-zA-Z]{2,4}|\d{1,3})(\]?)$/',
                    'allowName' => true,
                    'checkDns' => false,
                    'enableIdn' => true,
                    'incorrectInputMessage' => [
                        'template' => 'The value must be a string.',
                        'parameters' => [],
                    ],
                    'message' => [
                        'template' => 'This value is not a valid email address.',
                        'parameters' => [],
                    ],
                    'skipOnEmpty' => false,
                    'skipOnError' => false,
                ],
            ],
        ];
    }

    public function dataValidationPassed(): array
    {
        $rule = new Email();
        $ruleAllowedName = new Email(allowName: true);
        $ruleEnabledIdn = new Email(enableIdn: true);
        $ruleEnabledIdnAndAllowedName = new Email(allowName: true, enableIdn: true);

        return [
            ['[email protected]', [$rule]],
            ['[email protected]', [$rule]],
            ['[email protected]', [$rule]],
            ['[email protected]', [$rule]],
            ['user+mailbox/[email protected]', [$rule]],
            ['!#$%&\'*+-/=?^_`.{|}[email protected]', [$rule]],
            ['[email protected]', [$rule]], // checkDNS is disabled
            ['[email protected]', [$rule]],
            [str_repeat('a', 64) . '@gmail.com', [$rule]],
            ['name@' . str_repeat('a', 245) . '.com', [$rule]],
            ['[email protected]', [$rule]],

            ['[email protected]', [$ruleAllowedName]],
            ['[email protected]', [$ruleAllowedName]],
            ['[email protected]', [$ruleAllowedName]],
            ['Carsten Brandt <[email protected]>', [$ruleAllowedName]],
            ['"Carsten Brandt" <[email protected]>', [$ruleAllowedName]],
            ['<[email protected]>', [$ruleAllowedName]],
            ['[email protected]', [$ruleAllowedName]],
            ['John Smith <[email protected]>', [$ruleAllowedName]],
            [
                '"This name is longer than 64 characters. Blah blah blah blah blah" <[email protected]>',
                [$ruleAllowedName],
            ],

            ['[email protected]', [$ruleEnabledIdn]],
            ['[email protected]', [$ruleEnabledIdn]],
            ['example@äüößìà.de', [$ruleEnabledIdn]],
            ['[email protected]', [$ruleEnabledIdn]],
            ['info@örtliches.de', [$ruleEnabledIdn]],
            ['sam@рмкреатиф.ru', [$ruleEnabledIdn]],
            ['[email protected]', [$ruleEnabledIdn]],
            ['[email protected]', [$ruleEnabledIdn]],
            ['üñîçøðé@üñîçøðé.com', [$ruleEnabledIdn]],

            ['info@örtliches.de', [$ruleEnabledIdnAndAllowedName]],
            ['Information <info@örtliches.de>', [$ruleEnabledIdnAndAllowedName]],
            ['sam@рмкреатиф.ru', [$ruleEnabledIdnAndAllowedName]],
            ['[email protected]', [$ruleEnabledIdnAndAllowedName]],
            ['[email protected]', [$ruleEnabledIdnAndAllowedName]],
            ['Carsten Brandt <[email protected]>', [$ruleEnabledIdnAndAllowedName]],
            ['"Carsten Brandt" <[email protected]>', [$ruleEnabledIdnAndAllowedName]],
            ['üñîçøðé 日本国 <üñîçøðé@üñîçøðé.com>', [$ruleEnabledIdnAndAllowedName]],
            ['<[email protected]>', [$ruleEnabledIdnAndAllowedName]],
            ['[email protected]', [$ruleEnabledIdnAndAllowedName]],
            ['John Smith <[email protected]>', [$ruleEnabledIdnAndAllowedName]],
            [
                '"Такое имя достаточно длинное, но оно все равно может пройти валидацию" <[email protected]>',
                [$ruleEnabledIdnAndAllowedName],
            ],

            ['[email protected]', [new Email(checkDns: true)]],

            ['[email protected]', [new Email(allowName: true, checkDns: true)]],
            ['Ivan Petrov <[email protected]>', [new Email(allowName: true, checkDns: true)]],
            ['name@ñandu.cl', [new Email(checkDns: true, enableIdn: true)]],
        ];
    }

    public function dataValidationFailed(): array
    {
        $rule = new Email();
        $ruleAllowedName = new Email(allowName: true);
        $ruleEnabledIdn = new Email(enableIdn: true);
        $ruleEnabledIdnAndAllowedName = new Email(allowName: true, enableIdn: true);
        $errors = ['' => ['This value is not a valid email address.']];
        $incorrectInputErrors = ['' => ['The value must be a string.']];

        return [
            'incorrect input, integer' => [1, [$rule], $incorrectInputErrors],
            'incorrect input, array containing string element' => [
                ['[email protected]'],
                [$ruleAllowedName],
                $incorrectInputErrors,
            ],
            'custom incorrect input message' => [
                1,
                [new Email(incorrectInputMessage: 'Custom incorrect input message.')],
                ['' => ['Custom incorrect input message.']],
            ],
            'custom incorrect input message with parameters' => [
                1,
                [new Email(incorrectInputMessage: 'Attribute - {attribute}, type - {type}.')],
                ['' => ['Attribute - , type - int.']],
            ],
            'custom incorrect input message with parameters, attribute set' => [
                ['data' => 1],
                ['data' => [new Email(incorrectInputMessage: 'Attribute - {attribute}, type - {type}.')]],
                ['data' => ['Attribute - data, type - int.']],
            ],

            ['rmcreative.ru', [$rule], $errors],
            ['Carsten Brandt <[email protected]>', [$rule], $errors],
            ['"Carsten Brandt" <[email protected]>', [$rule], $errors],
            ['<[email protected]>', [$rule], $errors],
            ['info@örtliches.de', [$rule], $errors],
            ['sam@рмкреатиф.ru', [$rule], $errors],
            ['[email protected]', [$rule], $errors],
            [str_repeat('a', 65) . '@gmail.com', [$rule], $errors],
            ['name@' . str_repeat('a', 246) . '.com', [$rule], $errors],

            // Malicious email addresses that can be used to exploit SwiftMailer vulnerability CVE-2016-10074 while IDN
            // is disabled.
            // https://legalhackers.com/advisories/SwiftMailer-Exploit-Remote-Code-Exec-CVE-2016-10074-Vuln.html

            // This is the demo email used in the proof of concept of the exploit
            ['"attacker\" -oQ/tmp/ -X/var/www/cache/phpcode.php "@email.com', [$rule], $errors],

            // Trying more addresses
            ['"Attacker -Param2 -Param3"@test.com', [$rule], $errors],
            ['\'Attacker -Param2 -Param3\'@test.com', [$rule], $errors],
            ['"Attacker \" -Param2 -Param3"@test.com', [$rule], $errors],
            ["'Attacker \\' -Param2 -Param3'@test.com", [$rule], $errors],
            ['"attacker\" -oQ/tmp/ -X/var/www/cache/phpcode.php "@email.com', [$rule], $errors],

            // And even more variants
            ['"attacker\"\ -oQ/tmp/\ -X/var/www/cache/phpcode.php"@email.com', [$rule], $errors],
            ["\"attacker\\\"\0-oQ/tmp/\0-X/var/www/cache/phpcode.php\"@email.com", [$rule], $errors],
            ['"[email protected]\"-Xbeep"@email.com', [$rule], $errors],
            ["'attacker\\' -oQ/tmp/ -X/var/www/cache/phpcode.php'@email.com", [$rule], $errors],
            ["'attacker\\\\' -oQ/tmp/ -X/var/www/cache/phpcode.php'@email.com", [$rule], $errors],
            ["'attacker\\\\'\\ -oQ/tmp/ -X/var/www/cache/phpcode.php'@email.com", [$rule], $errors],
            ["'attacker\\';touch /tmp/hackme'@email.com", [$rule], $errors],
            ["'attacker\\\\';touch /tmp/hackme'@email.com", [$rule], $errors],
            ["'attacker\\';touch/tmp/hackme'@email.com", [$rule], $errors],
            ["'attacker\\\\';touch/tmp/hackme'@email.com", [$rule], $errors],
            ['"attacker\" -oQ/tmp/ -X/var/www/cache/phpcode.php "@email.com', [$rule], $errors],

            ['rmcreative.ru', [$ruleAllowedName], $errors],
            ['info@örtliches.de', [$ruleAllowedName], $errors],
            ['üñîçøðé@üñîçøðé.com', [$ruleAllowedName], $errors],
            ['sam@рмкреатиф.ru', [$ruleAllowedName], $errors],
            ['Informtation [email protected]', [$ruleAllowedName], $errors],
            ['John Smith <example.com>', [$ruleAllowedName], $errors],
            [
                'Short Name <localPartMoreThan64Characters-blah-blah-blah-blah-blah-blah-blah-blah@example.com>',
                [$ruleAllowedName],
                $errors,
            ],
            [
                'Short Name <domainNameIsMoreThan254Characters@example-blah-blah-blah-blah-blah-blah-blah-blah-blah-' .
                'blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-' .
                'blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah-blah' .
                '.com>',
                [$ruleAllowedName],
                $errors,
            ],

            ['rmcreative.ru', [$ruleEnabledIdn], $errors],
            ['Carsten Brandt <[email protected]>', [$ruleEnabledIdn], $errors],
            ['"Carsten Brandt" <[email protected]>', [$ruleEnabledIdn], $errors],
            ['<[email protected]>', [$ruleEnabledIdn], $errors],

            [
                'Короткое имя <тест@это-доменное-имя.после-преобразования-в-idn.будет-содержать-больше-254-символов.' .
                'бла-бла-бла-бла-бла-бла-бла-бла.бла-бла-бла-бла-бла-бла.бла-бла-бла-бла-бла-бла.бла-бла-бла-бла-бла-' .
                'бла.com>',
                [$ruleEnabledIdnAndAllowedName],
                $errors,
            ],
            ['Information info@örtliches.de', [$ruleEnabledIdnAndAllowedName], $errors],
            ['rmcreative.ru', [$ruleEnabledIdnAndAllowedName], $errors],
            ['John Smith <example.com>', [$ruleEnabledIdnAndAllowedName], $errors],
            [
                'Короткое имя <после-преобразования-в-idn-тут-будет-больше-чем-64-символа@пример.com>',
                [$ruleEnabledIdnAndAllowedName],
                $errors,
            ],

            ['name@ñandu.cl', [new Email(checkDns: true)], $errors],
            ['gmail.con', [new Email(checkDns: true)], $errors],
            [
                '[email protected]',
                [new Email(checkDns: true)],
                $errors,
            ],

            'custom message' => [
                '[email protected]',
                [new Email(checkDns: true, message: 'Custom message.')],
                ['' => ['Custom message.']],
            ],
            'custom message with parameters' => [
                '[email protected]',
                [new Email(checkDns: true, message: 'Attribute - {attribute}, value - {value}.')],
                ['' => ['Attribute - , value - [email protected].']],
            ],
            'custom message with parameters, attribute set' => [
                ['data' => '[email protected]'],
                ['data' => new Email(checkDns: true, message: 'Attribute - {attribute}, value - {value}.')],
                ['data' => ['Attribute - data, value - [email protected].']],
            ],
        ];
    }

    public function testSkipOnError(): void
    {
        $this->testSkipOnErrorInternal(new Email(), new Email(skipOnError: true));
    }

    public function testWhen(): void
    {
        $when = static fn (mixed $value): bool => $value !== null;
        $this->testWhenInternal(new Email(), new Email(when: $when));
    }

    protected function getDifferentRuleInHandlerItems(): array
    {
        return [Email::class, EmailHandler::class];
    }
}

yiisoft / validator

Pull Request — master (#619)

EmailTest::dataValidationFailed() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
