ResultSet::addResult() - Code Metrics - Inspection of "Add methods to ResultSet" - yiisoft/validator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f149e6...b53585 )

by Alexander

created 2021-01-20 18:22 UTC

ResultSet::addResult() A

↳ Parent: ResultSet

Complexity

Conditions	5
Paths	8

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	9
c	1
b	0
f	0
nc	8
nop	2
dl	0
loc	17
ccs	10
cts	10
cp	1
crap	5
rs	9.6111

<?php

declare(strict_types=1);

namespace Yiisoft\Validator;

use ArrayIterator;
use InvalidArgumentException;
use IteratorAggregate;

/**
 * ResultSet stores validation result of each attribute from {@link DataSetInterface}.
 * It is typically obtained by validating data set with {@link Validator}.
 */
final class ResultSet implements IteratorAggregate
{
    /**
     * @var Result[]
     */
    private array $results = [];
    private bool $isValid = true;

    public function addResult(string $attribute, Result $result): void
    {
        if (!$result->isValid()) {
            $this->isValid = false;
        }

        if (!isset($this->results[$attribute])) {
            $this->results[$attribute] = $result;
            return;
        }

        if ($result->isValid()) {
            return;
        }

        foreach ($result->getErrors() as $error) {
            $this->results[$attribute]->addError($error);
        }
    }

    public function getResult(string $attribute): Result
    {
        if (!isset($this->results[$attribute])) {
            throw new InvalidArgumentException("There is no result for attribute \"$attribute\"");
        }

        return $this->results[$attribute];
    }

    public function getIterator(): ArrayIterator
    {
        return new ArrayIterator($this->results);
    }

    /**
     * @return string[]
     */
    public function getErrors(): array
    {
        $errors = [];
        foreach ($this->results as $attribute => $result) {
            if (!$result->isValid()) {
                $errors[$attribute] = $result->getErrors();
            }
        }

        return $errors;
    }

    public function isValid(): bool
    {
        return $this->isValid;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Validator;
6
7		use ArrayIterator;
8		use InvalidArgumentException;
9		use IteratorAggregate;
10
11		/**
12		* ResultSet stores validation result of each attribute from {@link DataSetInterface}.
13		* It is typically obtained by validating data set with {@link Validator}.
14		*/
15		final class ResultSet implements IteratorAggregate
16		{
17		/**
18		* @var Result[]
19		*/
20		private array $results = [];
21		private bool $isValid = true;
22
23	9	public function addResult(string $attribute, Result $result): void
24		{
25	9	if (!$result->isValid()) {
26	8	$this->isValid = false;
27		}
28
29	9	if (!isset($this->results[$attribute])) {
30	9	$this->results[$attribute] = $result;
31	9	return;
32		}
33
34	3	if ($result->isValid()) {
35	1	return;
36		}
37
38	2	foreach ($result->getErrors() as $error) {
39	2	$this->results[$attribute]->addError($error);
40		}
41	2	}
42
43	6	public function getResult(string $attribute): Result
44		{
45	6	if (!isset($this->results[$attribute])) {
46		throw new InvalidArgumentException("There is no result for attribute \"$attribute\"");
47		}
48
49	6	return $this->results[$attribute];
50		}
51
52		public function getIterator(): ArrayIterator
53		{
54		return new ArrayIterator($this->results);
55		}
56
57		/**
58		* @return string[]
59		*/
60	1	public function getErrors(): array
61		{
62	1	$errors = [];
63	1	foreach ($this->results as $attribute => $result) {
64	1	if (!$result->isValid()) {
65	1	$errors[$attribute] = $result->getErrors();
66		}
67		}
68
69	1	return $errors;
70		}
71
72	2	public function isValid(): bool
73		{
74	2	return $this->isValid;
75		}
76		}
77

yiisoft / validator

Push — master ( f149e6...b53585 )

ResultSet::addResult() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like