Callback::__construct() - Code Metrics - Inspection of "Enhance tests" - yiisoft/validator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#199)

by Alexander

created 2022-04-05 14:11 UTC

Callback::__construct() A

↳ Parent: Callback

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
nc	1
nop	5
dl	0
loc	11
ccs	2
cts	2
cp	1
crap	1
rs	10
c	1
b	0
f	0

<?php

declare(strict_types=1);

namespace Yiisoft\Validator\Rule;

use Yiisoft\Validator\Exception\InvalidCallbackReturnTypeException;
use Yiisoft\Validator\FormatterInterface;
use Yiisoft\Validator\Result;
use Yiisoft\Validator\Rule;
use Yiisoft\Validator\ValidationContext;

final class Callback extends Rule
{
    public function __construct(
        /**
         * @var callable
         */
        private $callback,
        ?FormatterInterface $formatter = null,
        bool $skipOnEmpty = false,
        bool $skipOnError = false,
        $when = null
    ) {
        parent::__construct(formatter: $formatter, skipOnEmpty: $skipOnEmpty, skipOnError: $skipOnError, when: $when);
    }

    protected function validateValue($value, ?ValidationContext $context = null): Result
    {
        $callback = $this->callback;
        $callbackResult = $callback($value, $context);

        if (!$callbackResult instanceof Result) {
            throw new InvalidCallbackReturnTypeException($callbackResult);
        }

        $result = new Result();
        if ($callbackResult->isValid()) {
            return $result;
        }

        foreach ($callbackResult->getErrors() as $error) {
            $result->addError($this->formatMessage($error->getMessage()), $error->getValuePath());
        }

        return $result;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Validator\Rule;
6
7		use Yiisoft\Validator\Exception\InvalidCallbackReturnTypeException;
8		use Yiisoft\Validator\FormatterInterface;
9		use Yiisoft\Validator\Result;
10		use Yiisoft\Validator\Rule;
11		use Yiisoft\Validator\ValidationContext;
12
13		final class Callback extends Rule
14		{
15	11	public function __construct(
16		/**
17		* @var callable
18		*/
19		private $callback,
20		?FormatterInterface $formatter = null,
21		bool $skipOnEmpty = false,
22		bool $skipOnError = false,
23		$when = null
24		) {
25	11	parent::__construct(formatter: $formatter, skipOnEmpty: $skipOnEmpty, skipOnError: $skipOnError, when: $when);
26		}
27
28	10	protected function validateValue($value, ?ValidationContext $context = null): Result
29		{
30	10	$callback = $this->callback;
31	10	$callbackResult = $callback($value, $context);
32
33	10	if (!$callbackResult instanceof Result) {
34	1	throw new InvalidCallbackReturnTypeException($callbackResult);
35		}
36
37	9	$result = new Result();
38	9	if ($callbackResult->isValid()) {
39		return $result;
40		}
41
42	9	foreach ($callbackResult->getErrors() as $error) {
43	9	$result->addError($this->formatMessage($error->getMessage()), $error->getValuePath());
44		}
45
46	9	return $result;
47		}
48		}
49

yiisoft / validator

Pull Request — master (#199)

Callback::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like