AttributesRulesProvider::isUseProperty() - Code Metrics - Inspection of "Improve reflection usage" - yiisoft/validator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#312)

by Dmitriy

created 2022-09-08 17:02 UTC

AttributesRulesProvider::isUseProperty() A

↳ Parent: Project

Complexity

Conditions	6
Paths	11

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	3
c	1
b	0
f	0
dl	0
loc	5
ccs	4
cts	4
cp	1
rs	9.2222
cc	6
nc	11
nop	1
crap	6

<?php

declare(strict_types=1);

namespace Yiisoft\Validator\RulesProvider;

use ReflectionAttribute;
use ReflectionClass;
use ReflectionObject;
use ReflectionProperty;
use Yiisoft\Validator\RuleInterface;
use Yiisoft\Validator\RulesProviderInterface;

final class AttributesRulesProvider implements RulesProviderInterface
{
    /**
     * @var array<RuleInterface[]>|null
     */
    private ?array $rules = null;

    public function __construct(
        /**
         * @param class-string|object $class
         */
        private string|object $source,
        private int $propertyVisibility = ReflectionProperty::IS_PRIVATE | ReflectionProperty::IS_PROTECTED | ReflectionProperty::IS_PUBLIC
    ) {
    }

    /**
     * @return array<RuleInterface[]>
     */
    public function getRules(): array
    {
        if ($this->rules === null) {
            $this->rules = $this->parseRules();
        }
        return $this->rules;

    }

    /**
     * @return array<RuleInterface[]>
     */
    private function parseRules(): array
    {
        $rules = [];

        $reflection = is_object($this->source)
            ? new ReflectionObject($this->source)
            : new ReflectionClass($this->source);
        foreach ($reflection->getProperties($this->propertyVisibility) as $property) {
            $attributes = $property->getAttributes(RuleInterface::class, ReflectionAttribute::IS_INSTANCEOF);
            foreach ($attributes as $attribute) {
                $rules[$property->getName()][] = $attribute->newInstance();
            }
        }

        return $rules;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Validator\RulesProvider;
6
7		use ReflectionAttribute;
8		use ReflectionClass;
9		use ReflectionObject;
10		use ReflectionProperty;
11		use Yiisoft\Validator\RuleInterface;
12		use Yiisoft\Validator\RulesProviderInterface;
13
14		final class AttributesRulesProvider implements RulesProviderInterface
15		{
16		/**
17		* @var array<RuleInterface[]>\|null
18		*/
19		private ?array $rules = null;
20
21	13	public function __construct(
22		/**
23		* @param class-string\|object $class
24		*/
25		private string\|object $source,
26		private int $propertyVisibility = ReflectionProperty::IS_PRIVATE \| ReflectionProperty::IS_PROTECTED \| ReflectionProperty::IS_PUBLIC
27		) {
28		}
29
30		/**
31		* @return array<RuleInterface[]>
32		*/
33	13	public function getRules(): array
34		{
35	13	if ($this->rules === null) {
36	13	$this->rules = $this->parseRules();
37		}
38	13	return $this->rules;
		0 ignored issues – show Bug Best Practice introduced 2022-08-26 14:41 UTC by Report Bug Copy Issue Report The expression `return $this->rules` could return the type `null` which is incompatible with the type-hinted return `array`. Consider adding an additional type-check to rule them out. Loading history...
39		}
40
41		/**
42		* @return array<RuleInterface[]>
43		*/
44	13	private function parseRules(): array
45		{
46	13	$rules = [];
47
48	13	$reflection = is_object($this->source)
49	5	? new ReflectionObject($this->source)
50	8	: new ReflectionClass($this->source);
51	13	foreach ($reflection->getProperties($this->propertyVisibility) as $property) {
52	13	$attributes = $property->getAttributes(RuleInterface::class, ReflectionAttribute::IS_INSTANCEOF);
53	13	foreach ($attributes as $attribute) {
54	13	$rules[$property->getName()][] = $attribute->newInstance();
55		}
56		}
57
58	13	return $rules;
59		}
60		}
61

yiisoft / validator

Pull Request — master (#312)

AttributesRulesProvider::isUseProperty() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like