Passed
Pull Request — master (#199)
by Alexander
05:46 queued 03:21
created

CompareTo::__construct()   A

Complexity

Conditions 2
Paths 2

Size

Total Lines 38
Code Lines 3

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 3
CRAP Score 2.0625

Importance

Changes 0
Metric Value
cc 2
eloc 3
c 0
b 0
f 0
nc 2
nop 8
dl 0
loc 38
ccs 3
cts 4
cp 0.75
crap 2.0625
rs 10

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
3
declare(strict_types=1);
4
5
namespace Yiisoft\Validator\Rule;
6
7
use Attribute;
8
use InvalidArgumentException;
9
use RuntimeException;
10
use Yiisoft\Validator\FormatterInterface;
11
use Yiisoft\Validator\Result;
12
use Yiisoft\Validator\Rule;
13
use Yiisoft\Validator\ValidationContext;
14
15
/**
16
 * Compares the specified value with another value.
17
 *
18
 * The value being compared with a constant {@see CompareTo::$compareValue}, which is set
19
 * in the constructor.
20
 *
21
 * It supports different comparison operators, specified
22
 * via the {@see CompareTo::$operator}.
23
 *
24
 * The default comparison function is based on string values, which means the values
25
 * are compared byte by byte. When comparing numbers, make sure to change {@see CompareTo::$type} to
26
 * {@see CompareTo::TYPE_NUMBER} to enable numeric comparison.
27
 */
28
#[Attribute(Attribute::TARGET_PROPERTY)]
29
final class CompareTo extends Rule
30
{
31
    /**
32
     * Constant for specifying the comparison as string values.
33
     * No conversion will be done before comparison.
34
     *
35
     * @see $type
36
     */
37
    public const TYPE_STRING = 'string';
38
    /**
39
     * Constant for specifying the comparison as numeric values.
40
     * String values will be converted into numbers before comparison.
41
     *
42
     * @see $type
43
     */
44
    public const TYPE_NUMBER = 'number';
45
    private array $validOperators = [
46
        '==' => 1,
47
        '===' => 1,
48
        '!=' => 1,
49
        '!==' => 1,
50
        '>' => 1,
51
        '>=' => 1,
52
        '<' => 1,
53
        '<=' => 1,
54
    ];
55
56 30
    public function __construct(
57
        /**
58
         * @var mixed the constant value to be compared with.
59
         */
60
        private $compareValue,
61
        /**
62
         * @var string|null user-defined error message
63
         */
64
        private ?string $message = null,
65
        /**
66
         * @var string the type of the values being compared.
67
         */
68
        private string $type = self::TYPE_STRING,
69
        /**
70
         * @var string the operator for comparison. The following operators are supported:
71
         *
72
         * - `==`: check if two values are equal. The comparison is done is non-strict mode.
73
         * - `===`: check if two values are equal. The comparison is done is strict mode.
74
         * - `!=`: check if two values are NOT equal. The comparison is done is non-strict mode.
75
         * - `!==`: check if two values are NOT equal. The comparison is done is strict mode.
76
         * - `>`: check if value being validated is greater than the value being compared with.
77
         * - `>=`: check if value being validated is greater than or equal to the value being compared with.
78
         * - `<`: check if value being validated is less than the value being compared with.
79
         * - `<=`: check if value being validated is less than or equal to the value being compared with.
80
         *
81
         * When you want to compare numbers, make sure to also chabge @see CompareTo::$type} to
82
         * {@see CompareTo::TYPE_NUMBER}.
83
         */
84
        private string $operator = '==',
85
        ?FormatterInterface $formatter = null,
86
        bool $skipOnEmpty = false,
87
        bool $skipOnError = false,
88
        $when = null
89
    ) {
90 30
        parent::__construct(formatter: $formatter, skipOnEmpty: $skipOnEmpty, skipOnError: $skipOnError, when: $when);
91
92 30
        if (!isset($this->validOperators[$operator])) {
93
            throw new InvalidArgumentException("Operator \"$operator\" is not supported.");
94
        }
95
    }
96
97 21
    private function getMessage(): string
98
    {
99 21
        if ($this->message !== null) {
100 1
            return $this->message;
101
        }
102
103 20
        switch ($this->operator) {
104 20
            case '==':
105 15
            case '===':
106 6
                return 'Value must be equal to "{value}".';
107 14
            case '!=':
108 11
            case '!==':
109 7
                return 'Value must not be equal to "{value}".';
110 7
            case '>':
111 2
                return 'Value must be greater than "{value}".';
112 5
            case '>=':
113 2
                return 'Value must be greater than or equal to "{value}".';
114 3
            case '<':
115 2
                return 'Value must be less than "{value}".';
116 1
            case '<=':
117 1
                return 'Value must be less than or equal to "{value}".';
118
            default:
119
                throw new RuntimeException("Unknown operator: {$this->operator}");
120
        }
121
    }
122
123 29
    protected function validateValue($value, ?ValidationContext $context = null): Result
124
    {
125 29
        $result = new Result();
126
127 29
        if (!$this->compareValues($this->operator, $this->type, $value, $this->compareValue)) {
128 14
            $message = $this->formatMessage($this->getMessage(), ['value' => $this->compareValue]);
129 14
            $result->addError($message);
130
        }
131
132 29
        return $result;
133
    }
134
135
    /**
136
     * Compares two values with the specified operator.
137
     *
138
     * @param string $operator the comparison operator
139
     * @param string $type the type of the values being compared
140
     * @param mixed $value the value being compared
141
     * @param mixed $compareValue another value being compared
142
     *
143
     * @return bool whether the comparison using the specified operator is true.
144
     */
145 29
    protected function compareValues(string $operator, string $type, $value, $compareValue): bool
146
    {
147 29
        if ($type === self::TYPE_NUMBER) {
148
            $value = (float) $value;
149
            $compareValue = (float)$compareValue;
150
        } else {
151 29
            $value = (string) $value;
152 29
            $compareValue = (string) $compareValue;
153
        }
154 29
        switch ($operator) {
155 29
            case '==':
156 4
                return $value == $compareValue;
157 25
            case '===':
158 4
                return $value === $compareValue;
159 21
            case '!=':
160 5
                return $value != $compareValue;
161 16
            case '!==':
162 4
                return $value !== $compareValue;
163 12
            case '>':
164 3
                return $value > $compareValue;
165 9
            case '>=':
166 3
                return $value >= $compareValue;
167 6
            case '<':
168 3
                return $value < $compareValue;
169 3
            case '<=':
170 3
                return $value <= $compareValue;
171
            default:
172
                return false;
173
        }
174
    }
175
176 7
    public function getOptions(): array
177
    {
178 7
        return array_merge(parent::getOptions(), [
179 7
            'compareValue' => $this->compareValue,
180 7
            'message' => $this->formatMessage($this->getMessage(), ['value' => $this->compareValue]),
181 7
            'type' => $this->type,
182 7
            'operator' => $this->operator,
183
        ]);
184
    }
185
}
186