Passed
Pull Request — master (#288)
by Alexander
10:50 queued 07:32
created

Compare::__construct()   A

Complexity

Conditions 2
Paths 2

Size

Total Lines 49
Code Lines 3

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 3
CRAP Score 2.0625

Importance

Changes 1
Bugs 0 Features 0
Metric Value
eloc 3
c 1
b 0
f 0
dl 0
loc 49
ccs 3
cts 4
cp 0.75
rs 10
cc 2
nc 2
nop 9
crap 2.0625

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
3
declare(strict_types=1);
4
5
namespace Yiisoft\Validator\Rule;
6
7
use Closure;
8
use InvalidArgumentException;
9
use RuntimeException;
10
use Yiisoft\Validator\BeforeValidationInterface;
11
use Yiisoft\Validator\Rule\Trait\BeforeValidationTrait;
12
use Yiisoft\Validator\Rule\Trait\RuleNameTrait;
13
use Yiisoft\Validator\SerializableRuleInterface;
14
use Yiisoft\Validator\ValidationContext;
15
16
abstract class Compare implements SerializableRuleInterface, BeforeValidationInterface
17
{
18
    use BeforeValidationTrait;
19
    use RuleNameTrait;
20
21
    /**
22
     * Constant for specifying the comparison as string values.
23
     * No conversion will be done before comparison.
24
     *
25
     * @see $type
26
     */
27
    public const TYPE_STRING = 'string';
28
    /**
29
     * Constant for specifying the comparison as numeric values.
30
     * String values will be converted into numbers before comparison.
31
     *
32
     * @see $type
33
     */
34
    public const TYPE_NUMBER = 'number';
35
36
    private array $validOperators = [
37
        '==' => 1,
38
        '===' => 1,
39
        '!=' => 1,
40
        '!==' => 1,
41
        '>' => 1,
42
        '>=' => 1,
43
        '<' => 1,
44
        '<=' => 1,
45
    ];
46
47 15
    public function __construct(
48
        /**
49
         * @var mixed The constant value to be compared with. When both this property
50
         * and {@see $targetAttribute} are set, this property takes precedence.
51
         */
52
        private $targetValue = null,
53
        /**
54
         * @var string|null The name of the attribute to be compared with. When both this property
55
         * and {@see $targetValue} are set, the {@see $targetValue} takes precedence.
56
         *
57
         * @see $targetValue
58
         */
59
        private ?string $targetAttribute = null,
60
        /**
61
         * @var string|null User-defined error message.
62
         */
63
        private ?string $message = null,
64
        /**
65
         * @var string The type of the values being compared.
66
         */
67
        private string $type = self::TYPE_STRING,
68
        /**
69
         * @var string The operator for comparison. The following operators are supported:
70
         *
71
         * - `==`: check if two values are equal. The comparison is done is non-strict mode.
72
         * - `===`: check if two values are equal. The comparison is done is strict mode.
73
         * - `!=`: check if two values are NOT equal. The comparison is done is non-strict mode.
74
         * - `!==`: check if two values are NOT equal. The comparison is done is strict mode.
75
         * - `>`: check if value being validated is greater than the value being compared with.
76
         * - `>=`: check if value being validated is greater than or equal to the value being compared with.
77
         * - `<`: check if value being validated is less than the value being compared with.
78
         * - `<=`: check if value being validated is less than or equal to the value being compared with.
79
         *
80
         * When you want to compare numbers, make sure to also change @see $type} to
81
         * {@see TYPE_NUMBER}.
82
         */
83
        private string $operator = '==',
84
        private bool $skipOnEmpty = false,
85
        private $skipOnEmptyCallback = null,
86
        private bool $skipOnError = false,
87
        /**
88
         * @var Closure(mixed, ValidationContext):bool|null
89
         */
90
        private ?Closure $when = null,
91
    ) {
92 15
        $this->initSkipOnEmptyProperties($skipOnEmpty, $skipOnEmptyCallback);
93
94 15
        if (!isset($this->validOperators[$operator])) {
95
            throw new InvalidArgumentException("Operator \"$operator\" is not supported.");
96
        }
97
    }
98
99 65
    public function getTargetValue(): mixed
100
    {
101 65
        return $this->targetValue;
102
    }
103
104 65
    public function getTargetAttribute(): ?string
105
    {
106 65
        return $this->targetAttribute;
107
    }
108
109 65
    public function getType(): string
110
    {
111 65
        return $this->type;
112
    }
113
114 65
    public function getOperator(): string
115
    {
116 65
        return $this->operator;
117
    }
118
119 80
    public function getMessage(): string
120
    {
121 80
        return $this->message ?? match ($this->operator) {
122 17
            '==', '===' => 'Value must be equal to "{targetValueOrAttribute}".',
123 16
            '!=', '!==' => 'Value must not be equal to "{targetValueOrAttribute}".',
124 8
            '>' => 'Value must be greater than "{targetValueOrAttribute}".',
125 8
            '>=' => 'Value must be greater than or equal to "{targetValueOrAttribute}".',
126 8
            '<' => 'Value must be less than "{targetValueOrAttribute}".',
127 8
            '<=' => 'Value must be less than or equal to "{targetValueOrAttribute}".',
128 80
            default => throw new RuntimeException("Unknown operator: $this->operator."),
129
        };
130
    }
131
132 45
    public function getOptions(): array
133
    {
134
        return [
135 45
            'targetValue' => $this->targetValue,
136 45
            'targetAttribute' => $this->targetAttribute,
137
            'message' => [
138 45
                'message' => $this->getMessage(),
139
                'parameters' => [
140 45
                    'targetValue' => $this->targetValue,
141 45
                    'targetAttribute' => $this->targetAttribute,
142 45
                    'targetValueOrAttribute' => $this->targetValue ?? $this->targetAttribute,
143
                ],
144
            ],
145 45
            'type' => $this->type,
146 45
            'operator' => $this->operator,
147 45
            'skipOnEmpty' => $this->skipOnEmpty,
148 45
            'skipOnError' => $this->skipOnError,
149
        ];
150
    }
151
152 6
    public function getHandlerClassName(): string
153
    {
154 6
        return CompareHandler::class;
155
    }
156
}
157