ResultSet::addResult() - Code Metrics - Inspection of "Added "when" method for validation at condition" - yiisoft/validator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#55)

by Alexander

created 2020-03-03 19:04 UTC

ResultSet::addResult() A

↳ Parent: ResultSet

Complexity

Conditions	6
Paths	8

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	9
c	1
b	0
f	0
nc	8
nop	2
dl	0
loc	16
cc	6
rs	9.2222
ccs	10
cts	10
cp	1
crap	6

<?php

declare(strict_types=1);

namespace Yiisoft\Validator;

/**
 * ResultSet stores validation result of each attribute from {@link DataSetInterface}.
 * It is typically obtained by validating data set with {@link Validator}.
 */
final class ResultSet implements \IteratorAggregate
{
    /**
     * @var Result[]
     */
    private array $results = [];
    private bool $hasErrors = false;

    public function addResult(
        string $attribute,
        Result $result
    ): void {
        if ($this->hasErrors === false && $result->isValid() === false) {
            $this->hasErrors = true;
        }
        if (!isset($this->results[$attribute])) {
            $this->results[$attribute] = $result;
            return;
        }
        if ($result->isValid()) {
            return;
        }
        foreach ($result->getErrors() as $error) {
            $this->results[$attribute]->addError($error);
        }
    }

    public function hasErrors(): bool
    {
        return $this->hasErrors;
    }

    public function getResult(string $attribute): Result
    {
        if (!isset($this->results[$attribute])) {
            throw new \InvalidArgumentException("There is no result for attribute \"$attribute\"");
        }

        return $this->results[$attribute];
    }

    public function getIterator()
    {
        return new \ArrayIterator($this->results);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Validator;
6
7		/**
8		* ResultSet stores validation result of each attribute from {@link DataSetInterface}.
9		* It is typically obtained by validating data set with {@link Validator}.
10		*/
11		final class ResultSet implements \IteratorAggregate
12		{
13		/**
14		* @var Result[]
15		*/
16		private array $results = [];
17		private bool $hasErrors = false;
18
19	4	public function addResult(
20		string $attribute,
21		Result $result
22		): void {
23	4	if ($this->hasErrors === false && $result->isValid() === false) {
24	4	$this->hasErrors = true;
25		}
26	4	if (!isset($this->results[$attribute])) {
27	4	$this->results[$attribute] = $result;
28	4	return;
29		}
30	2	if ($result->isValid()) {
31	1	return;
32		}
33	1	foreach ($result->getErrors() as $error) {
34	1	$this->results[$attribute]->addError($error);
35		}
36		}
37
38		public function hasErrors(): bool
39		{
40		return $this->hasErrors;
41		}
42
43	4	public function getResult(string $attribute): Result
44		{
45	4	if (!isset($this->results[$attribute])) {
46		throw new \InvalidArgumentException("There is no result for attribute \"$attribute\"");
47		}
48
49	4	return $this->results[$attribute];
50		}
51
52		public function getIterator()
53		{
54		return new \ArrayIterator($this->results);
55		}
56		}
57

yiisoft / validator

Pull Request — master (#55)

ResultSet::addResult() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like