CountHandler::validate() - Code Metrics - Inspection of "Add "exactly" functionality to HasLength rule and..." - yiisoft/validator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#274)

by Alexander

created 2022-07-25 11:00 UTC

CountHandler::validate() A

↳ Parent: CountHandler

Complexity

Conditions	3
Paths	3

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3.512

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	12
c	1
b	0
f	0
dl	0
loc	22
ccs	8
cts	13
cp	0.6153
rs	9.8666
cc	3
nc	3
nop	3
crap	3.512

<?php

declare(strict_types=1);

namespace Yiisoft\Validator\Rule;

use Countable;
use Yiisoft\Validator\Exception\UnexpectedRuleException;
use Yiisoft\Validator\Formatter;
use Yiisoft\Validator\FormatterInterface;
use Yiisoft\Validator\Result;
use Yiisoft\Validator\Rule\Trait\LimitHandlerTrait;
use Yiisoft\Validator\RuleHandlerInterface;
use Yiisoft\Validator\ValidationContext;

use function count;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

/**
 * Validates that the value contains certain number of items. Can be applied to arrays or classes implementing
 * {@see Countable} interface.
 */
final class CountHandler implements RuleHandlerInterface
{
    use LimitHandlerTrait;

    private FormatterInterface $formatter;

    public function __construct(?FormatterInterface $formatter = null)
    {
        $this->formatter = $formatter ?? new Formatter();
    }

    public function validate(mixed $value, object $rule, ValidationContext $context): Result
    {
        if (!$rule instanceof Count) {
            throw new UnexpectedRuleException(Count::class, $rule);
        }

        $result = new Result();

        if (!is_countable($value)) {
            $formattedMessage = $this->formatter->format(
                $rule->getMessage(),
                ['attribute' => $context->getAttribute(), 'value' => $value]
            );
            $result->addError($formattedMessage);

            return $result;
        }

        $count = count($value);
        $this->validateLimits($value, $rule, $context, $count, $result);

        return $result;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Validator\Rule;
6
7		use Countable;
8		use Yiisoft\Validator\Exception\UnexpectedRuleException;
9		use Yiisoft\Validator\Formatter;
10		use Yiisoft\Validator\FormatterInterface;
11		use Yiisoft\Validator\Result;
12		use Yiisoft\Validator\Rule\Trait\LimitHandlerTrait;
13		use Yiisoft\Validator\RuleHandlerInterface;
14		use Yiisoft\Validator\ValidationContext;
15
16		use function count;
		0 ignored issues – show Bug introduced 2022-04-13 07:54 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Yiisoft\Validator\Rule\count`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
17
18		/**
19		* Validates that the value contains certain number of items. Can be applied to arrays or classes implementing
20		* {@see Countable} interface.
21		*/
22		final class CountHandler implements RuleHandlerInterface
23		{
24		use LimitHandlerTrait;
25
26		private FormatterInterface $formatter;
27
28	21	public function __construct(?FormatterInterface $formatter = null)
29		{
30	21	$this->formatter = $formatter ?? new Formatter();
31		}
32
33	20	public function validate(mixed $value, object $rule, ValidationContext $context): Result
34		{
35	20	if (!$rule instanceof Count) {
36	1	throw new UnexpectedRuleException(Count::class, $rule);
37		}
38
39	19	$result = new Result();
40
41	19	if (!is_countable($value)) {
42		$formattedMessage = $this->formatter->format(
43		$rule->getMessage(),
44		['attribute' => $context->getAttribute(), 'value' => $value]
45		);
46		$result->addError($formattedMessage);
47
48		return $result;
49		}
50
51	19	$count = count($value);
52	19	$this->validateLimits($value, $rule, $context, $count, $result);
53
54	19	return $result;
55		}
56		}
57

yiisoft / validator

Pull Request — master (#274)

CountHandler::validate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like