NestedTest::testHandler()

Passed

Pull Request — master (#416)

by Sergei

created 2022-12-02 08:29 UTC

↳ Parent: NestedTest

Size

Total Lines	10
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	4
c	0
b	0
f	0
nc	2
nop	3
dl	0
loc	10

<?php

declare(strict_types=1);

namespace Yiisoft\Validator\Tests\TestEnvironments\Php81\Rule;

use PHPUnit\Framework\TestCase;
use ReflectionProperty;
use Yiisoft\Validator\Rule\Nested;
use Yiisoft\Validator\Rule\Number;
use Yiisoft\Validator\Tests\Support\ValidatorFactory;
use Yiisoft\Validator\Tests\Support\Data\ObjectWithDifferentPropertyVisibility;
use Yiisoft\Validator\Validator;

final class NestedTest extends TestCase
{
    public function dataHandler(): array
    {
        return [
            'object' => [
                new class () {
                    #[Nested(['number' => new Number(max: 7)])]
                    private ObjectWithDifferentPropertyVisibility $object;

                    public function __construct()
                    {
                        $this->object = new ObjectWithDifferentPropertyVisibility();
                    }
                },
                [
                    'object.number' => ['Value must be no greater than 7.'],
                ],
            ],
            'object-private-only' => [
                new class () {
                    #[Nested(
                        ['age' => new Number(min: 100, skipOnEmpty: true), 'number' => new Number(max: 7)],
                        propertyVisibility: ReflectionProperty::IS_PRIVATE
                    )]
                    private ObjectWithDifferentPropertyVisibility $object;

                    public function __construct()
                    {
                        $this->object = new ObjectWithDifferentPropertyVisibility();
                    }
                },
                [
                    'object.number' => ['Value must be no greater than 7.'],
                ],
            ],
        ];
    }

    /**
     * @dataProvider dataHandler
     */
    public function testHandler(
        object $data,
        array $expectedErrorMessagesIndexedByPath,
        ?bool $expectedIsValid = false
    ): void {
        $result = $this->createValidator()->validate($data);

        $this->assertSame($expectedIsValid, $result->isValid());
        if (!$expectedIsValid) {
$a = canBeFalseAndNull();

// Instead of
if ( ! $a) { }

// Better use one of the explicit versions:
if ($a !== null) { }
if ($a !== false) { }
if ($a !== null && $a !== false) { }
            $this->assertSame($expectedErrorMessagesIndexedByPath, $result->getErrorMessagesIndexedByPath());
        }
    }

    private function createValidator(): Validator
    {
        return ValidatorFactory::make();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\Validator\Tests\TestEnvironments\Php81\Rule;
6
7			use PHPUnit\Framework\TestCase;
8			use ReflectionProperty;
9			use Yiisoft\Validator\Rule\Nested;
10			use Yiisoft\Validator\Rule\Number;
11			use Yiisoft\Validator\Tests\Support\ValidatorFactory;
12			use Yiisoft\Validator\Tests\Support\Data\ObjectWithDifferentPropertyVisibility;
13			use Yiisoft\Validator\Validator;
14
15			final class NestedTest extends TestCase
16			{
17			public function dataHandler(): array
18			{
19			return [
20			'object' => [
21			new class () {
22			#[Nested(['number' => new Number(max: 7)])]
23			private ObjectWithDifferentPropertyVisibility $object;
24
25			public function __construct()
26			{
27			$this->object = new ObjectWithDifferentPropertyVisibility();
28			}
29			},
30			[
31			'object.number' => ['Value must be no greater than 7.'],
32			],
33			],
34			'object-private-only' => [
35			new class () {
36			#[Nested(
37			['age' => new Number(min: 100, skipOnEmpty: true), 'number' => new Number(max: 7)],
38			propertyVisibility: ReflectionProperty::IS_PRIVATE
39			)]
40			private ObjectWithDifferentPropertyVisibility $object;
41
42			public function __construct()
43			{
44			$this->object = new ObjectWithDifferentPropertyVisibility();
45			}
46			},
47			[
48			'object.number' => ['Value must be no greater than 7.'],
49			],
50			],
51			];
52			}
53
54			/**
55			* @dataProvider dataHandler
56			*/
57			public function testHandler(
58			object $data,
59			array $expectedErrorMessagesIndexedByPath,
60			?bool $expectedIsValid = false
61			): void {
62			$result = $this->createValidator()->validate($data);
63
64			$this->assertSame($expectedIsValid, $result->isValid());
65			if (!$expectedIsValid) {
			0 ignored issues – show Bug Best Practice introduced 2022-12-01 11:29 UTC by Report Bug Copy Issue Report The expression `$expectedIsValid` of type `boolean\|null` is loosely compared to `false`; this is ambiguous if the boolean can be false. You might want to explicitly use `!== null` instead. If an expression can have both `false`, and `null` as possible values. It is generally a good practice to always use strict comparison to clearly distinguish between those two values. $a = canBeFalseAndNull(); // Instead of if ( ! $a) { } // Better use one of the explicit versions: if ($a !== null) { } if ($a !== false) { } if ($a !== null && $a !== false) { } Loading history...
66			$this->assertSame($expectedErrorMessagesIndexedByPath, $result->getErrorMessagesIndexedByPath());
67			}
68			}
69
70			private function createValidator(): Validator
71			{
72			return ValidatorFactory::make();
73			}
74			}
75

yiisoft / validator

Pull Request — master (#416)

NestedTest::testHandler()

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like