ResultSet::addResult() - Code Metrics - Inspection of "Fix #28: Implement context aware validation" - yiisoft/validator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#41)

by Alexander

created 2019-12-26 12:57 UTC

ResultSet::addResult() A

↳ Parent: ResultSet

Complexity

Conditions	4
Paths	4

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	7
nc	4
nop	2
dl	0
loc	11
ccs	8
cts	8
cp	1
crap	4
rs	10
c	1
b	0
f	0

<?php

namespace Yiisoft\Validator;

/**
 * ResultSet stores validation result of each attribute from {@link DataSetInterface}.
 * It is typically obtained by validating data set with {@link Validator}.
 */
final class ResultSet implements \IteratorAggregate
{
    /**
     * @var Result[]
     */
    private array $results = [];

    public function addResult(string $attribute, Result $result): void
    {
        if (!isset($this->results[$attribute])) {
            $this->results[$attribute] = $result;
            return;
        }
        if ($result->isValid()) {
            return;
        }
        foreach ($result->getErrors() as $error) {
            $this->results[$attribute]->addError($error);
        }
    }

    public function getResult(string $attribute): Result
    {
        if (!isset($this->results[$attribute])) {
            throw new \InvalidArgumentException("There is no result for attribute \"$attribute\"");
        }

        return $this->results[$attribute];
    }

    public function getIterator()
    {
        return new \ArrayIterator($this->results);
    }
}


1		<?php
2
3		namespace Yiisoft\Validator;
4
5		/**
6		* ResultSet stores validation result of each attribute from {@link DataSetInterface}.
7		* It is typically obtained by validating data set with {@link Validator}.
8		*/
9		final class ResultSet implements \IteratorAggregate
10		{
11		/**
12		* @var Result[]
13		*/
14		private array $results = [];
15
16	4	public function addResult(string $attribute, Result $result): void
17		{
18	4	if (!isset($this->results[$attribute])) {
19	4	$this->results[$attribute] = $result;
20	4	return;
21		}
22	2	if ($result->isValid()) {
23	1	return;
24		}
25	1	foreach ($result->getErrors() as $error) {
26	1	$this->results[$attribute]->addError($error);
27		}
28		}
29
30	4	public function getResult(string $attribute): Result
31		{
32	4	if (!isset($this->results[$attribute])) {
33		throw new \InvalidArgumentException("There is no result for attribute \"$attribute\"");
34		}
35
36	4	return $this->results[$attribute];
37		}
38
39		public function getIterator()
40		{
41		return new \ArrayIterator($this->results);
42		}
43		}
44

yiisoft / validator

Pull Request — master (#41)

ResultSet::addResult() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like