CountHandler::validate() - Code Metrics - Inspection of "Test refactoring" - yiisoft/validator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#335)

by Sergei

created 2022-10-12 13:39 UTC

CountHandler::validate() A

↳ Parent: CountHandler

Complexity

Conditions	3
Paths	3

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	3.004

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	12
c	1
b	0
f	0
dl	0
loc	22
ccs	12
cts	13
cp	0.9231
rs	9.8666
cc	3
nc	3
nop	3
crap	3.004

<?php

declare(strict_types=1);

namespace Yiisoft\Validator\Rule;

use Countable;
use Yiisoft\Translator\TranslatorInterface;
use Yiisoft\Validator\Exception\UnexpectedRuleException;
use Yiisoft\Validator\Result;
use Yiisoft\Validator\Rule\Trait\LimitHandlerTrait;
use Yiisoft\Validator\RuleHandlerInterface;
use Yiisoft\Validator\ValidationContext;

use function count;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

/**
 * Validates that the value contains certain number of items. Can be applied to arrays or classes implementing
 * {@see Countable} interface.
 */
final class CountHandler implements RuleHandlerInterface
{
    use LimitHandlerTrait;

    public function __construct(private TranslatorInterface $translator)
    {
    }

    public function validate(mixed $value, object $rule, ValidationContext $context): Result
    {
        if (!$rule instanceof Count) {
            throw new UnexpectedRuleException(Count::class, $rule);
        }

        $result = new Result();

        if (!is_countable($value)) {
            $formattedMessage = $this->translator->translate(
                $rule->getMessage(),
                ['attribute' => $context->getAttribute(), 'value' => $value]
            );
            $result->addError($formattedMessage);

            return $result;
        }

        $count = count($value);
        $this->validateLimits($value, $rule, $context, $count, $result);

        return $result;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Validator\Rule;
6
7		use Countable;
8		use Yiisoft\Translator\TranslatorInterface;
9		use Yiisoft\Validator\Exception\UnexpectedRuleException;
10		use Yiisoft\Validator\Result;
11		use Yiisoft\Validator\Rule\Trait\LimitHandlerTrait;
12		use Yiisoft\Validator\RuleHandlerInterface;
13		use Yiisoft\Validator\ValidationContext;
14
15		use function count;
		0 ignored issues – show Bug introduced 2022-04-13 07:54 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Yiisoft\Validator\Rule\count`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
16
17		/**
18		* Validates that the value contains certain number of items. Can be applied to arrays or classes implementing
19		* {@see Countable} interface.
20		*/
21		final class CountHandler implements RuleHandlerInterface
22		{
23		use LimitHandlerTrait;
24
25	24	public function __construct(private TranslatorInterface $translator)
26		{
27		}
28
29	24	public function validate(mixed $value, object $rule, ValidationContext $context): Result
30		{
31	24	if (!$rule instanceof Count) {
32		throw new UnexpectedRuleException(Count::class, $rule);
33		}
34
35	24	$result = new Result();
36
37	24	if (!is_countable($value)) {
38	1	$formattedMessage = $this->translator->translate(
39	1	$rule->getMessage(),
40	1	['attribute' => $context->getAttribute(), 'value' => $value]
41		);
42	1	$result->addError($formattedMessage);
43
44	1	return $result;
45		}
46
47	23	$count = count($value);
48	23	$this->validateLimits($value, $rule, $context, $count, $result);
49
50	23	return $result;
51		}
52		}
53

yiisoft / validator

Pull Request — master (#335)

CountHandler::validate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like