Rules::normalizeRule() - Code Metrics - Inspection of "Fix #28: Implement context aware validation" - yiisoft/validator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#41)

by Alexander

created 2019-12-25 17:41 UTC

Rules::normalizeRule() A

↳ Parent: Rules

Complexity

Conditions	3
Paths	4

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3.0416

Importance

Changes

Metric	Value
cc	3
eloc	5
nc	4
nop	1
dl	0
loc	11
ccs	5
cts	6
cp	0.8333
crap	3.0416
rs	10
c	0
b	0
f	0

<?php


namespace Yiisoft\Validator;

use Yiisoft\Validator\Rule\Callback;

/**
 * Rules represents multiple rules for a single value
 */
class Rules
{
    /**
     * @var Rule[]
     */
    private array $rules = [];

    public function __construct(iterable $rules = [])
    {
        foreach ($rules as $rule) {
            $this->rules[] = $this->normalizeRule($rule);
        }
    }

    private function normalizeRule($rule): Rule
    {
        if (is_callable($rule)) {
            $rule = new Callback($rule);
        }

        if (!$rule instanceof Rule) {
            throw new \InvalidArgumentException('Rule should be either instance of Rule class or a callable');
        }

        return $rule;
    }

    public function add(Rule $rule): self
    {
        $new = clone $this;
        $new->rules[] = $this->normalizeRule($rule);
        return $new;
    }

    public function validate($value, DataSetInterface $dataSet = null): Result
    {
        $compoundResult = new Result();
        foreach ($this->rules as $rule) {
            $ruleResult = $rule->validate($value, $dataSet);
            if ($ruleResult->isValid() === false) {
                foreach ($ruleResult->getErrors() as $error) {
                    $compoundResult = $compoundResult->addError($error);
                }
            }
        }
        return $compoundResult;
    }
}


1		<?php
2
3
4		namespace Yiisoft\Validator;
5
6		use Yiisoft\Validator\Rule\Callback;
7
8		/**
9		* Rules represents multiple rules for a single value
10		*/
11		class Rules
12		{
13		/**
14		* @var Rule[]
15		*/
16		private array $rules = [];
17
18	3	public function __construct(iterable $rules = [])
19		{
20	3	foreach ($rules as $rule) {
21	2	$this->rules[] = $this->normalizeRule($rule);
22		}
23		}
24
25	3	private function normalizeRule($rule): Rule
26		{
27	3	if (is_callable($rule)) {
28	1	$rule = new Callback($rule);
29		}
30
31	3	if (!$rule instanceof Rule) {
32		throw new \InvalidArgumentException('Rule should be either instance of Rule class or a callable');
33		}
34
35	3	return $rule;
36		}
37
38	1	public function add(Rule $rule): self
39		{
40	1	$new = clone $this;
41	1	$new->rules[] = $this->normalizeRule($rule);
42	1	return $new;
43		}
44
45	3	public function validate($value, DataSetInterface $dataSet = null): Result
46		{
47	3	$compoundResult = new Result();
48	3	foreach ($this->rules as $rule) {
49	3	$ruleResult = $rule->validate($value, $dataSet);
50	3	if ($ruleResult->isValid() === false) {
51	3	foreach ($ruleResult->getErrors() as $error) {
52	3	$compoundResult = $compoundResult->addError($error);
53		}
54		}
55		}
56	3	return $compoundResult;
57		}
58		}
59

yiisoft / validator

Pull Request — master (#41)

Rules::normalizeRule() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like