Result::getErrorsIndexedByPath() - Code Metrics - Inspection of "Validate nested data, add error details" - yiisoft/validator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#151)

unknown

created 2022-02-03 12:02 UTC

Result::getErrorsIndexedByPath() A

↳ Parent: Result

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	1
dl	0
loc	9
ccs	6
cts	6
cp	1
crap	2
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Yiisoft\Validator;

use Yiisoft\Arrays\ArrayHelper;

final class Result implements ErrorsReadInterface
{
    /**
     * @var Error[]
     */
    private array $errors = [];

    public function isValid(): bool
    {
        return $this->errors === [];
    }

    /**
     * @return Error[]
     */
    public function getErrorObjects(): array
    {
        return $this->errors;
    }

    /**
     * @return string[]
     */
    public function getErrors(): array
    {
        return ArrayHelper::getColumn($this->errors, static fn (Error $error) => $error->getMessage());
    }

    public function getNestedErrors(): array
    {
        $nestedErrors = [];
        foreach ($this->errors as $error) {
            $valuePath = $error->getValuePath();
            if ($valuePath === []) {
                $nestedErrors[0][] = $error->getMessage();
            } else {
                $errors = ArrayHelper::getValue($nestedErrors, $valuePath, []);
                $errors[] = $error->getMessage();

                ArrayHelper::setValue($nestedErrors, $valuePath, $errors);
            }
        }

        return $nestedErrors;
    }

    public function getErrorsIndexedByPath(string $separator = '.'): array
    {
        $errors = [];
        foreach ($this->errors as $error) {
            $stringValuePath = implode($separator, $error->getValuePath());
            $errors[$stringValuePath][] = $error->getMessage();
        }

        return $errors;
    }

    /**
     * @psalm-param array<int|string> $valuePath
     */
    public function addError(string $message, array $valuePath = []): void
    {
        $this->errors[] = new Error($message, $valuePath);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Validator;
6
7		use Yiisoft\Arrays\ArrayHelper;
8
9		final class Result implements ErrorsReadInterface
10		{
11		/**
12		* @var Error[]
13		*/
14		private array $errors = [];
15
16	163	public function isValid(): bool
17		{
18	163	return $this->errors === [];
19		}
20
21		/**
22		* @return Error[]
23		*/
24	19	public function getErrorObjects(): array
25		{
26	19	return $this->errors;
27		}
28
29		/**
30		* @return string[]
31		*/
32	37	public function getErrors(): array
33		{
34	37	return ArrayHelper::getColumn($this->errors, static fn (Error $error) => $error->getMessage());
35		}
36
37	2	public function getNestedErrors(): array
38		{
39	2	$nestedErrors = [];
40	2	foreach ($this->errors as $error) {
41	2	$valuePath = $error->getValuePath();
42	2	if ($valuePath === []) {
43	1	$nestedErrors[0][] = $error->getMessage();
44		} else {
45	2	$errors = ArrayHelper::getValue($nestedErrors, $valuePath, []);
46	2	$errors[] = $error->getMessage();
47
48	2	ArrayHelper::setValue($nestedErrors, $valuePath, $errors);
49		}
50		}
51
52	2	return $nestedErrors;
53		}
54
55	2	public function getErrorsIndexedByPath(string $separator = '.'): array
56		{
57	2	$errors = [];
58	2	foreach ($this->errors as $error) {
59	2	$stringValuePath = implode($separator, $error->getValuePath());
60	2	$errors[$stringValuePath][] = $error->getMessage();
61		}
62
63	2	return $errors;
64		}
65
66		/**
67		* @psalm-param array<int\|string> $valuePath
68		*/
69	133	public function addError(string $message, array $valuePath = []): void
70		{
71	133	$this->errors[] = new Error($message, $valuePath);
72	133	}
73		}
74

yiisoft / validator

Pull Request — master (#151)

Result::getErrorsIndexedByPath() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like