Passed
Pull Request — master (#364)
by
unknown
04:53 queued 01:51
created

Compare::__construct()   A

Complexity

Conditions 2
Paths 2

Size

Total Lines 49
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 2
CRAP Score 2.1481

Importance

Changes 1
Bugs 0 Features 0
Metric Value
eloc 2
c 1
b 0
f 0
dl 0
loc 49
ccs 2
cts 3
cp 0.6667
rs 10
cc 2
nc 2
nop 10
crap 2.1481

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
3
declare(strict_types=1);
4
5
namespace Yiisoft\Validator\Rule;
6
7
use Closure;
8
use InvalidArgumentException;
9
use Yiisoft\Validator\Rule\Trait\SkipOnEmptyTrait;
10
use Yiisoft\Validator\Rule\Trait\SkipOnErrorTrait;
11
use Yiisoft\Validator\Rule\Trait\WhenTrait;
12
use Yiisoft\Validator\SerializableRuleInterface;
13
use Yiisoft\Validator\SkipOnEmptyInterface;
14
use Yiisoft\Validator\SkipOnErrorInterface;
15
use Yiisoft\Validator\ValidationContext;
16
use Yiisoft\Validator\WhenInterface;
17
18
abstract class Compare implements SerializableRuleInterface, SkipOnEmptyInterface, SkipOnErrorInterface, WhenInterface
19
{
20
    use SkipOnEmptyTrait;
21
    use SkipOnErrorTrait;
22
    use WhenTrait;
23
24
    /**
25
     * Constant for specifying the comparison as string values.
26
     * Values will be converted to strings before comparison.
27
     *
28
     * @see $type
29
     */
30
    public const TYPE_STRING = 'string';
31
    /**
32
     * Constant for specifying the comparison as numeric values.
33
     * Values will be converted to float numbers before comparison.
34
     *
35
     * @see $type
36
     */
37
    public const TYPE_NUMBER = 'number';
38
39
    private array $validOperatorsMap = [
40
        '==' => 1,
41
        '===' => 1,
42
        '!=' => 1,
43
        '!==' => 1,
44
        '>' => 1,
45
        '>=' => 1,
46
        '<' => 1,
47
        '<=' => 1,
48
    ];
49
50 33
    public function __construct(
51
        /**
52
         * @var scalar|null The constant value to be compared with. When both this property and {@see $targetAttribute}
53
         * are set, this property takes precedence.
54
         */
55
        private int|float|string|bool|null $targetValue = null,
56
        /**
57
         * @var string|null The name of the attribute to be compared with. When both this property and
58
         * {@see $targetValue} are set, the {@see $targetValue} takes precedence.
59
         */
60
        private string|null $targetAttribute = null,
61
        private string $incorrectDataSetTypeMessage = 'The attribute value returned from a custom data set must have ' .
62
        'a scalar type.',
63
        private string|null $nonScalarMessage = null,
64
        /**
65
         * @var string|null User-defined error message.
66
         */
67
        private string|null $scalarMessage = null,
68
        /**
69
         * @var string The type of the values being compared.
70
         */
71
        private string $type = self::TYPE_STRING,
72
        /**
73
         * @var string The operator for comparison. The following operators are supported:
74
         *
75
         * - `==`: check if two values are equal. The comparison is done in non-strict mode.
76
         * - `===`: check if two values are equal. The comparison is done in strict mode.
77
         * - `!=`: check if two values are NOT equal. The comparison is done in non-strict mode.
78
         * - `!==`: check if two values are NOT equal. The comparison is done in strict mode.
79
         * - `>`: check if value being validated is greater than the value being compared with.
80
         * - `>=`: check if value being validated is greater than or equal to the value being compared with.
81
         * - `<`: check if value being validated is less than the value being compared with.
82
         * - `<=`: check if value being validated is less than or equal to the value being compared with.
83
         *
84
         * When you want to compare numbers, make sure to also change {@see $type} to {@see TYPE_NUMBER}.
85
         */
86
        private string $operator = '==',
87
        /**
88
         * @var bool|callable|null
89
         */
90
        private mixed $skipOnEmpty = null,
91
        private bool $skipOnError = false,
92
        /**
93
         * @var Closure(mixed, ValidationContext):bool|null
94
         */
95
        private ?Closure $when = null,
96
    ) {
97 33
        if (!isset($this->validOperatorsMap[$this->operator])) {
98
            throw new InvalidArgumentException("Operator \"$operator\" is not supported.");
99
        }
100
    }
101
102
    /**
103
     * @return scalar|null
104
     */
105 72
    public function getTargetValue(): int|float|string|bool|null
106
    {
107 72
        return $this->targetValue;
108
    }
109
110 72
    public function getTargetAttribute(): string|null
111
    {
112 72
        return $this->targetAttribute;
113
    }
114
115 71
    public function getType(): string
116
    {
117 71
        return $this->type;
118
    }
119
120 71
    public function getOperator(): string
121
    {
122 71
        return $this->operator;
123
    }
124
125 1
    public function getIncorrectDataSetTypeMessage(): string
126
    {
127 1
        return $this->incorrectDataSetTypeMessage;
128
    }
129
130 40
    public function getNonScalarMessage(): string
131
    {
132 40
        return $this->nonScalarMessage ?? $this->getMessageByOperator();
133
    }
134
135 79
    public function getScalarMessage(): string
136
    {
137 79
        return $this->scalarMessage ?? $this->getMessageByOperator();
138
    }
139
140 72
    private function getMessageByOperator(): string
141
    {
142 72
        return match ($this->operator) {
143 24
            '==', '===' => 'Value must be equal to "{targetValueOrAttribute}".',
144 16
            '!=', '!==' => 'Value must not be equal to "{targetValueOrAttribute}".',
145 8
            '>' => 'Value must be greater than "{targetValueOrAttribute}".',
146 8
            '>=' => 'Value must be greater than or equal to "{targetValueOrAttribute}".',
147 8
            '<' => 'Value must be less than "{targetValueOrAttribute}".',
148 72
            '<=' => 'Value must be less than or equal to "{targetValueOrAttribute}".',
149
        };
150
    }
151
152 40
    public function getOptions(): array
153
    {
154 40
        $messageParameters = [
155 40
            'targetValue' => $this->targetValue,
156 40
            'targetAttribute' => $this->targetAttribute,
157 40
            'targetValueOrAttribute' => $this->targetValue ?? $this->targetAttribute,
158
        ];
159
160
        return [
161 40
            'targetValue' => $this->targetValue,
162 40
            'targetAttribute' => $this->targetAttribute,
163
            'incorrectDataSetTypeMessage' => [
164 40
                'message' => $this->incorrectDataSetTypeMessage,
165
            ],
166
            'nonScalarMessage' => [
167 40
                'message' => $this->getNonScalarMessage(),
168
                'parameters' => $messageParameters,
169
            ],
170
            'scalarMessage' => [
171 40
                'message' => $this->getScalarMessage(),
172
                'parameters' => $messageParameters,
173
            ],
174 40
            'type' => $this->type,
175 40
            'operator' => $this->operator,
176 40
            'skipOnEmpty' => $this->getSkipOnEmptyOption(),
177 40
            'skipOnError' => $this->skipOnError,
178
        ];
179
    }
180
181 72
    public function getHandlerClassName(): string
182
    {
183 72
        return CompareHandler::class;
184
    }
185
}
186