Passed
Pull Request — master (#297)
by Sergei
14:07 queued 14s
created

Nested::getPropertyVisibility()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 3
Code Lines 1

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 2
CRAP Score 1

Importance

Changes 0
Metric Value
eloc 1
c 0
b 0
f 0
dl 0
loc 3
ccs 2
cts 2
cp 1
rs 10
cc 1
nc 1
nop 0
crap 1
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Yiisoft\Validator\Rule;
6
7
use Attribute;
8
use Closure;
9
use InvalidArgumentException;
10
use JetBrains\PhpStorm\ArrayShape;
11
use ReflectionProperty;
12
use Traversable;
13
use Yiisoft\Strings\StringHelper;
14
use Yiisoft\Validator\BeforeValidationInterface;
15
use Yiisoft\Validator\Rule\Trait\BeforeValidationTrait;
16
use Yiisoft\Validator\Rule\Trait\RuleNameTrait;
17
use Yiisoft\Validator\RuleInterface;
18
use Yiisoft\Validator\RulesDumper;
19
use Yiisoft\Validator\RulesProvider\AttributesRulesProvider;
20
use Yiisoft\Validator\RulesProviderInterface;
21
use Yiisoft\Validator\SerializableRuleInterface;
22
use Yiisoft\Validator\ValidationContext;
23
24
use function array_pop;
25
use function count;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Yiisoft\Validator\Rule\count. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
26
use function implode;
27
use function is_array;
28
use function ltrim;
29
use function rtrim;
30
use function sprintf;
31
32
/**
33
 * Can be used for validation of nested structures.
34
 */
35
#[Attribute(Attribute::TARGET_PROPERTY | Attribute::IS_REPEATABLE)]
36
final class Nested implements SerializableRuleInterface, BeforeValidationInterface
37
{
38
    use BeforeValidationTrait;
39
    use RuleNameTrait;
40
41
    private const SEPARATOR = '.';
42
    private const EACH_SHORTCUT = '*';
43
44
    /**
45
     * @var iterable<Closure|Closure[]|RuleInterface|RuleInterface[]>|null
46
     */
47
    private ?iterable $rules = null;
48
49 22
    public function __construct(
50
        /**
51
         * Rules for validate value that can be described by:
52
         * - object that implement {@see RulesProviderInterface};
53
         * - name of class from whose attributes their will be derived;
54
         * - array or object implementing the `Traversable` interface that contain {@see RuleInterface} implementations
55
         *   or closures.
56
         *
57
         * `$rules` can be null if validatable value is object. In this case rules will be derived from object via
58
         * `getRules()` method if object implement {@see RulesProviderInterface} or from attributes otherwise.
59
         *
60
         * @var class-string|iterable<Closure|Closure[]|RuleInterface|RuleInterface[]>|RulesProviderInterface|null
61
         */
62
        iterable|object|string|null $rules = null,
63
64
        /**
65
         * @var int What visibility levels to use when reading data and rules from validatable object.
66
         */
67
        private int $propertyVisibility = ReflectionProperty::IS_PRIVATE | ReflectionProperty::IS_PROTECTED | ReflectionProperty::IS_PUBLIC,
68
69
        /**
70
         * @var int What visibility levels to use when reading rules from the class specified in {@see $rules}
71
         * attribute.
72
         */
73
        private int $rulesPropertyVisibility = ReflectionProperty::IS_PRIVATE | ReflectionProperty::IS_PROTECTED | ReflectionProperty::IS_PUBLIC,
74
75
        private bool $requirePropertyPath = false,
76
        private string $noPropertyPathMessage = 'Property path "{path}" is not found.',
77
        private bool $normalizeRules = true,
78
        private bool $skipOnEmpty = false,
79
80
        /**
81
         * @var callable
82
         */
83
        private $skipOnEmptyCallback = null,
84
        private bool $skipOnError = false,
85
86
        /**
87
         * @var Closure(mixed, ValidationContext):bool|null
88
         */
89
        private ?Closure $when = null,
90
    ) {
91 22
        $this->initSkipOnEmptyProperties($skipOnEmpty, $skipOnEmptyCallback);
92 22
        $this->rules = $this->prepareRules($rules);
93
    }
94
95
    /**
96
     * @return iterable<Closure|Closure[]|RuleInterface|RuleInterface[]>|null
97
     */
98 37
    public function getRules(): ?iterable
99
    {
100 37
        return $this->rules;
101
    }
102
103 7
    public function getPropertyVisibility(): int
104
    {
105 7
        return $this->propertyVisibility;
106
    }
107
108
    /**
109
     * @return bool
110
     */
111 31
    public function getRequirePropertyPath(): bool
112
    {
113 31
        return $this->requirePropertyPath;
114
    }
115
116
    /**
117
     * @return string
118
     */
119 8
    public function getNoPropertyPathMessage(): string
120
    {
121 8
        return $this->noPropertyPathMessage;
122
    }
123
124
    /**
125
     * @param class-string|iterable<Closure|Closure[]|RuleInterface|RuleInterface[]>|RulesProviderInterface|null $source
0 ignored issues
show
Documentation Bug introduced by
The doc comment class-string|iterable<Cl...sProviderInterface|null at position 0 could not be parsed: Unknown type name 'class-string' at position 0 in class-string|iterable<Closure|Closure[]|RuleInterface|RuleInterface[]>|RulesProviderInterface|null.
Loading history...
126
     */
127 22
    private function prepareRules(iterable|object|string|null $source): ?iterable
128
    {
129 22
        if ($source === null) {
130 16
            return null;
131
        }
132
133 6
        if ($source instanceof RulesProviderInterface) {
134 1
            $rules = $source->getRules();
135 1
            return $this->normalizeRules ? $this->normalizeRules($rules) : $rules;
0 ignored issues
show
Bug Best Practice introduced by
The expression return $this->normalizeR...eRules($rules) : $rules could return the type array which is incompatible with the type-hinted return iterable|null. Consider adding an additional type-check to rule them out.
Loading history...
136
        }
137
138 5
        $isTraversable = $source instanceof Traversable;
139
140 5
        if (!$isTraversable && !is_array($source)) {
141 2
            $rules = (new AttributesRulesProvider($source, $this->rulesPropertyVisibility))->getRules();
0 ignored issues
show
Bug introduced by
It seems like $source can also be of type iterable; however, parameter $source of Yiisoft\Validator\RulesP...Provider::__construct() does only seem to accept object|string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

141
            $rules = (new AttributesRulesProvider(/** @scrutinizer ignore-type */ $source, $this->rulesPropertyVisibility))->getRules();
Loading history...
142 2
            $this->assertRulesNotEmpty($rules);
143 2
            return $rules;
0 ignored issues
show
Bug Best Practice introduced by
The expression return $rules returns the type array which is incompatible with the type-hinted return iterable|null.
Loading history...
144
        }
145
146
        /** @psalm-suppress InvalidArgument Psalm don't see $isTraversable above. */
147 3
        $rules = $isTraversable ? iterator_to_array($source) : $source;
0 ignored issues
show
Bug introduced by
It seems like $source can also be of type array; however, parameter $iterator of iterator_to_array() does only seem to accept Traversable, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

147
        $rules = $isTraversable ? iterator_to_array(/** @scrutinizer ignore-type */ $source) : $source;
Loading history...
148 3
        $this->assertRulesNotEmpty($rules);
0 ignored issues
show
Bug introduced by
It seems like $rules can also be of type Traversable; however, parameter $rules of Yiisoft\Validator\Rule\N...::assertRulesNotEmpty() does only seem to accept array, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

148
        $this->assertRulesNotEmpty(/** @scrutinizer ignore-type */ $rules);
Loading history...
149
150 2
        if (self::checkRules($rules)) {
151 1
            $message = sprintf('Each rule should be an instance of %s.', RuleInterface::class);
152 1
            throw new InvalidArgumentException($message);
153
        }
154
155 1
        return $this->normalizeRules ? $this->normalizeRules($rules) : $rules;
0 ignored issues
show
Bug Best Practice introduced by
The expression return $this->normalizeR...eRules($rules) : $rules returns the type array which is incompatible with the type-hinted return iterable|null.
Loading history...
156
    }
157
158 2
    private static function checkRules($rules): bool
159
    {
160 2
        return array_reduce(
161
            $rules,
162 2
            function (bool $carry, $rule) {
163 2
                return $carry || (is_array($rule) ? self::checkRules($rule) : !$rule instanceof RuleInterface);
164
            },
165
            false
166
        );
167
    }
168
169 2
    private function normalizeRules(iterable $sourceRules): array
170
    {
171 2
        $rules = $sourceRules instanceof Traversable ? iterator_to_array($sourceRules) : $sourceRules;
172 2
        while (true) {
173 2
            $breakWhile = true;
174 2
            $rulesMap = [];
175
176 2
            foreach ($rules as $valuePath => $rule) {
177 2
                if ($valuePath === self::EACH_SHORTCUT) {
178 1
                    throw new InvalidArgumentException('Bare shortcut is prohibited. Use "Each" rule instead.');
179
                }
180
181 1
                $parts = StringHelper::parsePath(
182 1
                    (string) $valuePath,
183
                    delimiter: self::EACH_SHORTCUT,
184
                    preserveDelimiterEscaping: true
185
                );
186 1
                if (count($parts) === 1) {
187 1
                    continue;
188
                }
189
190
                $breakWhile = false;
191
192
                $lastValuePath = array_pop($parts);
193
                $lastValuePath = ltrim($lastValuePath, '.');
194
                $lastValuePath = str_replace('\\' . self::EACH_SHORTCUT, self::EACH_SHORTCUT, $lastValuePath);
195
196
                $remainingValuePath = implode(self::EACH_SHORTCUT, $parts);
197
                $remainingValuePath = rtrim($remainingValuePath, self::SEPARATOR);
198
199
                if (!isset($rulesMap[$remainingValuePath])) {
200
                    $rulesMap[$remainingValuePath] = [];
201
                }
202
203
                $rulesMap[$remainingValuePath][$lastValuePath] = $rule;
204
                unset($rules[$valuePath]);
205
            }
206
207 1
            foreach ($rulesMap as $valuePath => $nestedRules) {
208
                $rules[$valuePath] = new Each([new self($nestedRules, normalizeRules: false)]);
209
            }
210
211 1
            if ($breakWhile === true) {
212 1
                break;
213
            }
214
        }
215
216 1
        return $rules;
0 ignored issues
show
Bug Best Practice introduced by
The expression return $rules could return the type iterable which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.
Loading history...
217
    }
218
219 4
    #[ArrayShape([
220
        'requirePropertyPath' => 'bool',
221
        'noPropertyPathMessage' => 'array',
222
        'skipOnEmpty' => 'bool',
223
        'skipOnError' => 'bool',
224
        'rules' => 'array|null',
225
    ])]
226
    public function getOptions(): array
227
    {
228
        return [
229 4
            'requirePropertyPath' => $this->getRequirePropertyPath(),
230
            'noPropertyPathMessage' => [
231 4
                'message' => $this->getNoPropertyPathMessage(),
232
            ],
233 4
            'skipOnEmpty' => $this->skipOnEmpty,
234 4
            'skipOnError' => $this->skipOnError,
235 4
            'rules' => $this->rules === null ? null : (new RulesDumper())->asArray($this->rules),
236
        ];
237
    }
238
239 22
    public function getHandlerClassName(): string
240
    {
241 22
        return NestedHandler::class;
242
    }
243
244 5
    private function assertRulesNotEmpty(array $rules): void
245
    {
246 5
        if (empty($rules)) {
247 1
            throw new InvalidArgumentException('Rules must not be empty.');
248
        }
249
    }
250
}
251