AttributeDataSet::handleAttributes() - Code Metrics - Inspection of "Fix attributes collecting" - yiisoft/validator - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#249)

by Dmitriy

created 2022-07-16 04:50 UTC

AttributeDataSet::handleAttributes() C

↳ Parent: Project

Complexity

Conditions	14
Paths	51

Size

Total Lines	76
Code Lines	42

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	37
CRAP Score	14.0826

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	42
dl	0
loc	76
ccs	37
cts	40
cp	0.925
rs	6.2666
c	1
b	0
f	0
cc	14
nc	51
nop	1
crap	14.0826

How to fix Long Method Complexity

<?php

declare(strict_types=1);

namespace Yiisoft\Validator\DataSet;

use ReflectionAttribute;
use ReflectionClass;
use Yiisoft\Validator\RuleInterface;
use Yiisoft\Validator\RulesProviderInterface;

/**
 * This data set makes use of attributes introduced in PHP 8. It simplifies rules configuration process, especially for
 * nested data and relations. Please refer to the guide for example.
 *
 * @link https://www.php.net/manual/en/language.attributes.overview.php
 */
final class AttributeDataSet implements RulesProviderInterface
{
    use ArrayDataTrait;

    private object $baseAnnotatedObject;

    public function __construct(object $baseAnnotatedObject, array $data = [])
    {
        $this->baseAnnotatedObject = $baseAnnotatedObject;
        $this->data = $data;
    }

    public function getRules(): iterable
    {
        $classMeta = new ReflectionClass($this->baseAnnotatedObject);

        return $this->collectAttributes($classMeta);
    }

    // TODO: use Generator to collect attributes
    private function collectAttributes(ReflectionClass $classMeta): array
    {
        $rules = [];
        foreach ($classMeta->getProperties() as $property) {
            $attributes = $property->getAttributes(RuleInterface::class, ReflectionAttribute::IS_INSTANCEOF);
            foreach ($attributes as $attribute) {
                /** @psalm-suppress UndefinedMethod */
                $rules[$property->getName()][] = $attribute->newInstance();
            }
        }

        return $rules;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Validator\DataSet;
6
7		use ReflectionAttribute;
8		use ReflectionClass;
9		use Yiisoft\Validator\RuleInterface;
10		use Yiisoft\Validator\RulesProviderInterface;
11
12		/**
13		* This data set makes use of attributes introduced in PHP 8. It simplifies rules configuration process, especially for
14		* nested data and relations. Please refer to the guide for example.
15		*
16		* @link https://www.php.net/manual/en/language.attributes.overview.php
17		*/
18		final class AttributeDataSet implements RulesProviderInterface
19		{
20		use ArrayDataTrait;
21
22		private object $baseAnnotatedObject;
23
24		public function __construct(object $baseAnnotatedObject, array $data = [])
25		{
26		$this->baseAnnotatedObject = $baseAnnotatedObject;
27		$this->data = $data;
28		}
29	2
30		public function getRules(): iterable
31	2	{
32	2	$classMeta = new ReflectionClass($this->baseAnnotatedObject);
33
34		return $this->collectAttributes($classMeta);
35	2	}
36
37	2	// TODO: use Generator to collect attributes
38		private function collectAttributes(ReflectionClass $classMeta): array
39	2	{
40		$rules = [];
41		foreach ($classMeta->getProperties() as $property) {
42	2	$attributes = $property->getAttributes(RuleInterface::class, ReflectionAttribute::IS_INSTANCEOF);
43		foreach ($attributes as $attribute) {
44	2	/** @psalm-suppress UndefinedMethod */
45	2	$rules[$property->getName()][] = $attribute->newInstance();
46	2	}
47		}
48
49		return $rules;
50	2	}
51		}
52

yiisoft / validator

Pull Request — master (#249)

AttributeDataSet::handleAttributes() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like