BooleanValueTest::dataValidationFailed() - Code Metrics - Inspection of "Adjust messages in `Boolean` and `IsTrue` rules, r..." - yiisoft/validator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#491)

unknown

created 2022-12-26 10:07 UTC

BooleanValueTest::dataValidationFailed() A

↳ Parent: BooleanValueTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	99
Code Lines	54

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	54
nc	1
nop	0
dl	0
loc	99
rs	9.0036
c	0
b	0
f	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace Yiisoft\Validator\Tests\Rule;

use Yiisoft\Validator\Rule\BooleanValue;
use Yiisoft\Validator\Rule\BooleanValueHandler;
use Yiisoft\Validator\Tests\Rule\Base\DifferentRuleInHandlerTestTrait;
use Yiisoft\Validator\Tests\Rule\Base\RuleTestCase;
use Yiisoft\Validator\Tests\Rule\Base\RuleWithOptionsTestTrait;
use Yiisoft\Validator\Tests\Rule\Base\SkipOnErrorTestTrait;
use Yiisoft\Validator\Tests\Rule\Base\WhenTestTrait;

final class BooleanValueTest extends RuleTestCase
{
    use DifferentRuleInHandlerTestTrait;
    use RuleWithOptionsTestTrait;
    use SkipOnErrorTestTrait;
    use WhenTestTrait;

    public function testGetName(): void
    {
        $rule = new BooleanValue();
        $this->assertSame('boolean', $rule->getName());
    }

    public function dataOptions(): array
    {
        return [
            [
                new BooleanValue(),
                [
                    'trueValue' => '1',
                    'falseValue' => '0',
                    'strict' => false,
                    'incorrectInputMessage' => [
                        'template' => 'The allowed types are integer, float, string, boolean. {type} given.',
                        'parameters' => [
                            'true' => '1',
                            'false' => '0',
                        ],
                    ],
                    'message' => [
                        'template' => 'Value must be either "{true}" or "{false}".',
                        'parameters' => [
                            'true' => '1',
                            'false' => '0',
                        ],
                    ],
                    'skipOnEmpty' => false,
                    'skipOnError' => false,
                ],
            ],
            [
                new BooleanValue(trueValue: true, falseValue: false, strict: true),
                [
                    'trueValue' => true,
                    'falseValue' => false,
                    'strict' => true,
                    'incorrectInputMessage' => [
                        'template' => 'The allowed types are integer, float, string, boolean. {type} given.',
                        'parameters' => [
                            'true' => 'true',
                            'false' => 'false',
                        ],
                    ],
                    'message' => [
                        'template' => 'Value must be either "{true}" or "{false}".',
                        'parameters' => [
                            'true' => 'true',
                            'false' => 'false',
                        ],
                    ],
                    'skipOnEmpty' => false,
                    'skipOnError' => false,
                ],
            ],
            [
                new BooleanValue(
                    trueValue: 'YES',
                    falseValue: 'NO',
                    strict: true,
                    incorrectInputMessage: 'Custom message 1.',
                    message: 'Custom message 2.',
                    skipOnEmpty: true,
                    skipOnError: true
                ),
                [
                    'trueValue' => 'YES',
                    'falseValue' => 'NO',
                    'strict' => true,
                    'incorrectInputMessage' => [
                        'template' => 'Custom message 1.',
                        'parameters' => [
                            'true' => 'YES',
                            'false' => 'NO',
                        ],
                    ],
                    'message' => [
                        'template' => 'Custom message 2.',
                        'parameters' => [
                            'true' => 'YES',
                            'false' => 'NO',
                        ],
                    ],
                    'skipOnEmpty' => true,
                    'skipOnError' => true,
                ],
            ],
        ];
    }

    public function dataValidationPassed(): array
    {
        return [
            [true, [new BooleanValue()]],
            [false, [new BooleanValue()]],

            ['0', [new BooleanValue()]],
            ['1', [new BooleanValue()]],

            ['0', [new BooleanValue(strict: true)]],
            ['1', [new BooleanValue(strict: true)]],

            [true, [new BooleanValue(trueValue: true, falseValue: false, strict: true)]],
            [false, [new BooleanValue(trueValue: true, falseValue: false, strict: true)]],
        ];
    }

    public function dataValidationFailed(): array
    {
        $defaultErrors = ['' => ['Value must be either "1" or "0".']];
        $booleanErrors = ['' => ['Value must be either "true" or "false".']];

        return [
            ['5', [new BooleanValue()], $defaultErrors],

            [null, [new BooleanValue()], ['' => ['The allowed types are integer, float, string, boolean. null given.']]],
            [[], [new BooleanValue()], ['' => ['The allowed types are integer, float, string, boolean. array given.']]],

            [true, [new BooleanValue(strict: true)], $defaultErrors],
            [false, [new BooleanValue(strict: true)], $defaultErrors],

            ['0', [new BooleanValue(trueValue: true, falseValue: false, strict: true)], $booleanErrors],
            [
                [],
                [new BooleanValue(trueValue: true, falseValue: false, strict: true)],
                ['' => ['The allowed types are integer, float, string, boolean. array given.']],
            ],

            'custom message' => [
                5,
                [new BooleanValue(message: 'Custom error.')],
                ['' => ['Custom error.']],
            ],
            'custom message with parameters' => [
                5,
                [
                    new BooleanValue(
                        message: 'Attribute - {attribute}, true - {true}, false - {false}, value - {value}.',
                    ),
                ],
                ['' => ['Attribute - , true - 1, false - 0, value - 5.']],
            ],
            'custom message with parameters, custom true and false values, strict' => [
                5,
                [
                    new BooleanValue(
                        trueValue: true,
                        falseValue: false,
                        strict: true,
                        message: 'Attribute - {attribute}, true - {true}, false - {false}, value - {value}.',
                    ),
                ],
                ['' => ['Attribute - , true - true, false - false, value - 5.']],
            ],
            'custom message with parameters, attribute set' => [
                ['data' => 5],
                [
                    'data' => new BooleanValue(
                        message: 'Attribute - {attribute}, true - {true}, false - {false}, value - {value}.',
                    ),
                ],
                ['data' => ['Attribute - data, true - 1, false - 0, value - 5.']],
            ],
            'custom incorrect input message' => [
                [],
                [new BooleanValue(incorrectInputMessage: 'Custom error.')],
                ['' => ['Custom error.']],
            ],
            'custom incorrect input message with parameters' => [
                [],
                [
                    new BooleanValue(
                        incorrectInputMessage: 'Attribute - {attribute}, true - {true}, false - {false}, type - {type}.',
                    ),
                ],
                ['' => ['Attribute - , true - 1, false - 0, type - array.']],
            ],
            'custom incorrect input message with parameters, custom true and false values, strict' => [
                [],
                [
                    new BooleanValue(
                        trueValue: true,
                        falseValue: false,
                        strict: true,
                        incorrectInputMessage: 'Attribute - {attribute}, true - {true}, false - {false}, type - {type}.',
                    ),
                ],
                ['' => ['Attribute - , true - true, false - false, type - array.']],
            ],
            'custom incorrect input message with parameters, attribute set' => [
                ['data' => []],
                [
                    'data' => new BooleanValue(
                        incorrectInputMessage: 'Attribute - {attribute}, true - {true}, false - {false}, type - {type}.',
                    ),
                ],
                ['data' => ['Attribute - data, true - 1, false - 0, type - array.']],
            ],
            'custom incorrect input message, null' => [
                null,
                [
                    new BooleanValue(
                        incorrectInputMessage: 'Attribute - {attribute}, true - {true}, false - {false}, type - {type}.',
                    ),
                ],
                ['' => ['Attribute - , true - 1, false - 0, type - null.']],
            ],
        ];
    }

    public function testSkipOnError(): void
    {
        $this->testSkipOnErrorInternal(new BooleanValue(), new BooleanValue(skipOnError: true));
    }

    public function testWhen(): void
    {
        $when = static fn (mixed $value): bool => $value !== null;
        $this->testWhenInternal(new BooleanValue(), new BooleanValue(when: $when));
    }

    protected function getDifferentRuleInHandlerItems(): array
    {
        return [BooleanValue::class, BooleanValueHandler::class];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\Validator\Tests\Rule;
6
7			use Yiisoft\Validator\Rule\BooleanValue;
8			use Yiisoft\Validator\Rule\BooleanValueHandler;
9			use Yiisoft\Validator\Tests\Rule\Base\DifferentRuleInHandlerTestTrait;
10			use Yiisoft\Validator\Tests\Rule\Base\RuleTestCase;
11			use Yiisoft\Validator\Tests\Rule\Base\RuleWithOptionsTestTrait;
12			use Yiisoft\Validator\Tests\Rule\Base\SkipOnErrorTestTrait;
13			use Yiisoft\Validator\Tests\Rule\Base\WhenTestTrait;
14
15			final class BooleanValueTest extends RuleTestCase
16			{
17			use DifferentRuleInHandlerTestTrait;
18			use RuleWithOptionsTestTrait;
19			use SkipOnErrorTestTrait;
20			use WhenTestTrait;
21
22			public function testGetName(): void
23			{
24			$rule = new BooleanValue();
25			$this->assertSame('boolean', $rule->getName());
26			}
27
28			public function dataOptions(): array
29			{
30			return [
31			[
32			new BooleanValue(),
33			[
34			'trueValue' => '1',
35			'falseValue' => '0',
36			'strict' => false,
37			'incorrectInputMessage' => [
38			'template' => 'The allowed types are integer, float, string, boolean. {type} given.',
39			'parameters' => [
40			'true' => '1',
41			'false' => '0',
42			],
43			],
44			'message' => [
45			'template' => 'Value must be either "{true}" or "{false}".',
46			'parameters' => [
47			'true' => '1',
48			'false' => '0',
49			],
50			],
51			'skipOnEmpty' => false,
52			'skipOnError' => false,
53			],
54			],
55			[
56			new BooleanValue(trueValue: true, falseValue: false, strict: true),
57			[
58			'trueValue' => true,
59			'falseValue' => false,
60			'strict' => true,
61			'incorrectInputMessage' => [
62			'template' => 'The allowed types are integer, float, string, boolean. {type} given.',
63			'parameters' => [
64			'true' => 'true',
65			'false' => 'false',
66			],
67			],
68			'message' => [
69			'template' => 'Value must be either "{true}" or "{false}".',
70			'parameters' => [
71			'true' => 'true',
72			'false' => 'false',
73			],
74			],
75			'skipOnEmpty' => false,
76			'skipOnError' => false,
77			],
78			],
79			[
80			new BooleanValue(
81			trueValue: 'YES',
82			falseValue: 'NO',
83			strict: true,
84			incorrectInputMessage: 'Custom message 1.',
85			message: 'Custom message 2.',
86			skipOnEmpty: true,
87			skipOnError: true
88			),
89			[
90			'trueValue' => 'YES',
91			'falseValue' => 'NO',
92			'strict' => true,
93			'incorrectInputMessage' => [
94			'template' => 'Custom message 1.',
95			'parameters' => [
96			'true' => 'YES',
97			'false' => 'NO',
98			],
99			],
100			'message' => [
101			'template' => 'Custom message 2.',
102			'parameters' => [
103			'true' => 'YES',
104			'false' => 'NO',
105			],
106			],
107			'skipOnEmpty' => true,
108			'skipOnError' => true,
109			],
110			],
111			];
112			}
113
114			public function dataValidationPassed(): array
115			{
116			return [
117			[true, [new BooleanValue()]],
118			[false, [new BooleanValue()]],
119
120			['0', [new BooleanValue()]],
121			['1', [new BooleanValue()]],
122
123			['0', [new BooleanValue(strict: true)]],
124			['1', [new BooleanValue(strict: true)]],
125
126			[true, [new BooleanValue(trueValue: true, falseValue: false, strict: true)]],
127			[false, [new BooleanValue(trueValue: true, falseValue: false, strict: true)]],
128			];
129			}
130
131			public function dataValidationFailed(): array
132			{
133			$defaultErrors = ['' => ['Value must be either "1" or "0".']];
134			$booleanErrors = ['' => ['Value must be either "true" or "false".']];
135
136			return [
137			['5', [new BooleanValue()], $defaultErrors],
138
139			[null, [new BooleanValue()], ['' => ['The allowed types are integer, float, string, boolean. null given.']]],
140			[[], [new BooleanValue()], ['' => ['The allowed types are integer, float, string, boolean. array given.']]],
141
142			[true, [new BooleanValue(strict: true)], $defaultErrors],
143			[false, [new BooleanValue(strict: true)], $defaultErrors],
144
145			['0', [new BooleanValue(trueValue: true, falseValue: false, strict: true)], $booleanErrors],
146			[
147			[],
148			[new BooleanValue(trueValue: true, falseValue: false, strict: true)],
149			['' => ['The allowed types are integer, float, string, boolean. array given.']],
150			],
151
152			'custom message' => [
153			5,
154			[new BooleanValue(message: 'Custom error.')],
155			['' => ['Custom error.']],
156			],
157			'custom message with parameters' => [
158			5,
159			[
160			new BooleanValue(
161			message: 'Attribute - {attribute}, true - {true}, false - {false}, value - {value}.',
162			),
163			],
164			['' => ['Attribute - , true - 1, false - 0, value - 5.']],
165			],
166			'custom message with parameters, custom true and false values, strict' => [
167			5,
168			[
169			new BooleanValue(
170			trueValue: true,
171			falseValue: false,
172			strict: true,
173			message: 'Attribute - {attribute}, true - {true}, false - {false}, value - {value}.',
174			),
175			],
176			['' => ['Attribute - , true - true, false - false, value - 5.']],
177			],
178			'custom message with parameters, attribute set' => [
179			['data' => 5],
180			[
181			'data' => new BooleanValue(
182			message: 'Attribute - {attribute}, true - {true}, false - {false}, value - {value}.',
183			),
184			],
185			['data' => ['Attribute - data, true - 1, false - 0, value - 5.']],
186			],
187			'custom incorrect input message' => [
188			[],
189			[new BooleanValue(incorrectInputMessage: 'Custom error.')],
190			['' => ['Custom error.']],
191			],
192			'custom incorrect input message with parameters' => [
193			[],
194			[
195			new BooleanValue(
196			incorrectInputMessage: 'Attribute - {attribute}, true - {true}, false - {false}, type - {type}.',
197			),
198			],
199			['' => ['Attribute - , true - 1, false - 0, type - array.']],
200			],
201			'custom incorrect input message with parameters, custom true and false values, strict' => [
202			[],
203			[
204			new BooleanValue(
205			trueValue: true,
206			falseValue: false,
207			strict: true,
208			incorrectInputMessage: 'Attribute - {attribute}, true - {true}, false - {false}, type - {type}.',
209			),
210			],
211			['' => ['Attribute - , true - true, false - false, type - array.']],
212			],
213			'custom incorrect input message with parameters, attribute set' => [
214			['data' => []],
215			[
216			'data' => new BooleanValue(
217			incorrectInputMessage: 'Attribute - {attribute}, true - {true}, false - {false}, type - {type}.',
218			),
219			],
220			['data' => ['Attribute - data, true - 1, false - 0, type - array.']],
221			],
222			'custom incorrect input message, null' => [
223			null,
224			[
225			new BooleanValue(
226			incorrectInputMessage: 'Attribute - {attribute}, true - {true}, false - {false}, type - {type}.',
227			),
228			],
229			['' => ['Attribute - , true - 1, false - 0, type - null.']],
230			],
231			];
232			}
233
234			public function testSkipOnError(): void
235			{
236			$this->testSkipOnErrorInternal(new BooleanValue(), new BooleanValue(skipOnError: true));
237			}
238
239			public function testWhen(): void
240			{
241			$when = static fn (mixed $value): bool => $value !== null;
242			$this->testWhenInternal(new BooleanValue(), new BooleanValue(when: $when));
243			}
244
245			protected function getDifferentRuleInHandlerItems(): array
246			{
247			return [BooleanValue::class, BooleanValueHandler::class];
248			}
249			}
250

yiisoft / validator

Pull Request — master (#491)

BooleanValueTest::dataValidationFailed() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like