Test Failed
Pull Request — master (#297)
by Alexander
04:29 queued 02:17
created

Nested::prepareRules()   B

Complexity

Conditions 9
Paths 10

Size

Total Lines 29
Code Lines 16

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 7
CRAP Score 25.4838

Importance

Changes 0
Metric Value
eloc 16
c 0
b 0
f 0
dl 0
loc 29
ccs 7
cts 17
cp 0.4118
rs 8.0555
cc 9
nc 10
nop 1
crap 25.4838
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Yiisoft\Validator\Rule;
6
7
use Attribute;
8
use Closure;
9
use InvalidArgumentException;
10
use JetBrains\PhpStorm\ArrayShape;
11
use ReflectionProperty;
12
use Traversable;
13
use Yiisoft\Strings\StringHelper;
14
use Yiisoft\Validator\BeforeValidationInterface;
15
use Yiisoft\Validator\Rule\Trait\BeforeValidationTrait;
16
use Yiisoft\Validator\Rule\Trait\RuleNameTrait;
17
use Yiisoft\Validator\RuleInterface;
18
use Yiisoft\Validator\RulesDumper;
19
use Yiisoft\Validator\RulesProvider\AttributesRulesProvider;
20
use Yiisoft\Validator\RulesProviderInterface;
21
use Yiisoft\Validator\SerializableRuleInterface;
22
use Yiisoft\Validator\ValidationContext;
23
24
use function array_pop;
25
use function count;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Yiisoft\Validator\Rule\count. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
26
use function implode;
27
use function is_array;
28
use function ltrim;
29
use function rtrim;
30
use function sprintf;
31
32
/**
33
 * Can be used for validation of nested structures.
34
 */
35
#[Attribute(Attribute::TARGET_PROPERTY | Attribute::IS_REPEATABLE)]
36
final class Nested implements SerializableRuleInterface, BeforeValidationInterface
37
{
38
    use BeforeValidationTrait;
39
    use RuleNameTrait;
40
41 6
    private const SEPARATOR = '.';
42
    private const EACH_SHORTCUT = '*';
43
44
    /**
45
     * @var iterable<Closure|Closure[]|RuleInterface|RuleInterface[]>|null
46
     */
47
    private ?iterable $rules = null;
48
49
    public function __construct(
50
        /**
51
         * Null available only for objects.
52
         *
53
         * @var class-string|iterable<Closure|Closure[]|RuleInterface|RuleInterface[]>|RulesProviderInterface|null
54
         */
55
        iterable|object|string|null $rules = null,
56
57
        /**
58
         * Use on parse data and rules from object value when {@see $rules} is null.
59
         *
60 6
         * @var int
61
         */
62 6
        private int $propertyVisibility = ReflectionProperty::IS_PRIVATE | ReflectionProperty::IS_PROTECTED | ReflectionProperty::IS_PUBLIC,
63 6
64 1
        /**
65
         * This options use on parse rules from class defined in {@see $rules}.
66
         *
67 5
         * @var int
68 1
         */
69 1
        private int $rulesPropertyVisibility = ReflectionProperty::IS_PRIVATE | ReflectionProperty::IS_PROTECTED | ReflectionProperty::IS_PUBLIC,
70
        private bool $requirePropertyPath = false,
71
        private string $noPropertyPathMessage = 'Property path "{path}" is not found.',
72 4
        private bool $normalizeRules = true,
73
        private bool $skipOnEmpty = false,
74 4
75 4
        /**
76
         * @var callable
77
         */
78
        private $skipOnEmptyCallback = null,
79
        private bool $skipOnError = false,
80
81
        /**
82 27
         * @var Closure(mixed, ValidationContext):bool|null
83
         */
84 27
        private ?Closure $when = null,
85
    ) {
86
        $this->initSkipOnEmptyProperties($skipOnEmpty, $skipOnEmptyCallback);
87
        $this->rules = $this->prepareRules($rules);
88
    }
89
90 27
    /**
91
     * @return iterable<Closure|Closure[]|RuleInterface|RuleInterface[]>|null
92 27
     */
93
    public function getRules(): ?iterable
94
    {
95
        return $this->rules;
96
    }
97
98 7
    public function getPropertyVisibility(): int
99
    {
100 7
        return $this->propertyVisibility;
101
    }
102
103 5
    /**
104
     * @return bool
105 5
     */
106
    public function getRequirePropertyPath(): bool
107 5
    {
108 5
        return $this->requirePropertyPath;
109
    }
110
111
    /**
112
     * @return string
113
     */
114 4
    public function getNoPropertyPathMessage(): string
115
    {
116
        return $this->noPropertyPathMessage;
117 4
    }
118 4
119 4
    /**
120 4
     * @param class-string|iterable<Closure|Closure[]|RuleInterface|RuleInterface[]>|RulesProviderInterface|null $source
0 ignored issues
show
Documentation Bug introduced by
The doc comment class-string|iterable<Cl...sProviderInterface|null at position 0 could not be parsed: Unknown type name 'class-string' at position 0 in class-string|iterable<Closure|Closure[]|RuleInterface|RuleInterface[]>|RulesProviderInterface|null.
Loading history...
121
     */
122 4
    private function prepareRules(iterable|object|string|null $source): ?iterable
123 4
    {
124 1
        if ($source === null) {
125
            return null;
126
        }
127 3
128 3
        if ($source instanceof RulesProviderInterface) {
129
            $rules = $source->getRules();
130
            return $this->normalizeRules ? $this->normalizeRules($rules) : $rules;
0 ignored issues
show
Bug Best Practice introduced by
The expression return $this->normalizeR...eRules($rules) : $rules could return the type array which is incompatible with the type-hinted return iterable|null. Consider adding an additional type-check to rule them out.
Loading history...
131
        }
132 3
133 3
        $isTraversable = $source instanceof Traversable;
134
135
        if (!$isTraversable && !is_array($source)) {
136
            $rules = (new AttributesRulesProvider($source, $this->rulesPropertyVisibility))->getRules();
0 ignored issues
show
Bug introduced by
It seems like $source can also be of type iterable; however, parameter $source of Yiisoft\Validator\RulesP...Provider::__construct() does only seem to accept object|string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

136
            $rules = (new AttributesRulesProvider(/** @scrutinizer ignore-type */ $source, $this->rulesPropertyVisibility))->getRules();
Loading history...
137
            $this->assertRulesNotEmpty($rules);
138
            return $rules;
0 ignored issues
show
Bug Best Practice introduced by
The expression return $rules returns the type array which is incompatible with the type-hinted return iterable|null.
Loading history...
139
        }
140
141
        /** @psalm-suppress InvalidArgument Psalm don't see $isTraversable above. */
142
        $rules = $isTraversable ? iterator_to_array($source) : $source;
0 ignored issues
show
Bug introduced by
It seems like $source can also be of type array; however, parameter $iterator of iterator_to_array() does only seem to accept Traversable, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

142
        $rules = $isTraversable ? iterator_to_array(/** @scrutinizer ignore-type */ $source) : $source;
Loading history...
143
        $this->assertRulesNotEmpty($rules);
0 ignored issues
show
Bug introduced by
It seems like $rules can also be of type Traversable; however, parameter $rules of Yiisoft\Validator\Rule\N...::assertRulesNotEmpty() does only seem to accept array, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

143
        $this->assertRulesNotEmpty(/** @scrutinizer ignore-type */ $rules);
Loading history...
144
145
        if (self::checkRules($rules)) {
146
            $message = sprintf('Each rule should be an instance of %s.', RuleInterface::class);
147
            throw new InvalidArgumentException($message);
148
        }
149
150
        return $this->normalizeRules ? $this->normalizeRules($rules) : $rules;
0 ignored issues
show
Bug Best Practice introduced by
The expression return $this->normalizeR...eRules($rules) : $rules returns the type array which is incompatible with the type-hinted return iterable|null.
Loading history...
151
    }
152
153 3
    private static function checkRules($rules): bool
154
    {
155
        return array_reduce(
156
            $rules,
157 3
            function (bool $carry, $rule) {
158 3
                return $carry || (is_array($rule) ? self::checkRules($rule) : !$rule instanceof RuleInterface);
159
            },
160
            false
161
        );
162 3
    }
163
164
    private function normalizeRules(iterable $sourceRules): array
165 4
    {
166
        $rules = $sourceRules instanceof Traversable ? iterator_to_array($sourceRules) : $sourceRules;
167
        while (true) {
168
            $breakWhile = true;
169
            $rulesMap = [];
170
171
            foreach ($rules as $valuePath => $rule) {
172
                if ($valuePath === self::EACH_SHORTCUT) {
173
                    throw new InvalidArgumentException('Bare shortcut is prohibited. Use "Each" rule instead.');
174
                }
175 4
176
                $parts = StringHelper::parsePath(
177 4
                    (string) $valuePath,
178
                    delimiter: self::EACH_SHORTCUT,
179 4
                    preserveDelimiterEscaping: true
180 4
                );
181 4
                if (count($parts) === 1) {
182
                    continue;
183
                }
184
185 11
                $breakWhile = false;
186
187 11
                $lastValuePath = array_pop($parts);
188
                $lastValuePath = ltrim($lastValuePath, '.');
189
                $lastValuePath = str_replace('\\' . self::EACH_SHORTCUT, self::EACH_SHORTCUT, $lastValuePath);
190
191
                $remainingValuePath = implode(self::EACH_SHORTCUT, $parts);
192
                $remainingValuePath = rtrim($remainingValuePath, self::SEPARATOR);
193
194
                if (!isset($rulesMap[$remainingValuePath])) {
195
                    $rulesMap[$remainingValuePath] = [];
196
                }
197
198
                $rulesMap[$remainingValuePath][$lastValuePath] = $rule;
199
                unset($rules[$valuePath]);
200
            }
201
202
            foreach ($rulesMap as $valuePath => $nestedRules) {
203
                $rules[$valuePath] = new Each([new self($nestedRules, normalizeRules: false)]);
204
            }
205
206
            if ($breakWhile === true) {
207
                break;
208
            }
209
        }
210
211
        return $rules;
0 ignored issues
show
Bug Best Practice introduced by
The expression return $rules could return the type iterable which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.
Loading history...
212
    }
213
214
    #[ArrayShape([
215
        'requirePropertyPath' => 'bool',
216
        'noPropertyPathMessage' => 'array',
217
        'skipOnEmpty' => 'bool',
218
        'skipOnError' => 'bool',
219
        'rules' => 'array|null',
220
    ])]
221
    public function getOptions(): array
222
    {
223
        return [
224
            'requirePropertyPath' => $this->getRequirePropertyPath(),
225
            'noPropertyPathMessage' => [
226
                'message' => $this->getNoPropertyPathMessage(),
227
            ],
228
            'skipOnEmpty' => $this->skipOnEmpty,
229
            'skipOnError' => $this->skipOnError,
230
            'rules' => $this->rules === null ? null : (new RulesDumper())->asArray($this->rules),
231
        ];
232
    }
233
234
    public function getHandlerClassName(): string
235
    {
236
        return NestedHandler::class;
237
    }
238
239
    private function assertRulesNotEmpty(array $rules): void
240
    {
241
        if (empty($rules)) {
242
            throw new InvalidArgumentException('Rules must not be empty.');
243
        }
244
    }
245
}
246