BeforeValidationTrait::skipOnEmptyCallback() - Code Metrics - Inspection of "Adjust skip on empty" - yiisoft/validator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#288)

by Alexander

created 2022-08-21 13:25 UTC

BeforeValidationTrait::skipOnEmptyCallback() A

↳ Parent: BeforeValidationTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
eloc	4
c	0
b	0
f	0
dl	0
loc	7
ccs	5
cts	5
cp	1
rs	10
cc	1
nc	1
nop	1
crap	1

<?php

declare(strict_types=1);

namespace Yiisoft\Validator\Rule\Trait;

use Closure;
use InvalidArgumentException;
use Yiisoft\Validator\SkipOnEmptyCallback\SkipNone;
use Yiisoft\Validator\SkipOnEmptyCallback\SkipOnEmpty;
use Yiisoft\Validator\ValidationContext;

use function is_callable;

trait BeforeValidationTrait
{
    public function getSkipOnEmpty(): bool
    {
        return $this->skipOnEmpty;
    }

    public function getSkipOnEmptyCallback(): callable
    {
        return $this->skipOnEmptyCallback;
    }

    public function shouldSkipOnEmpty(mixed $validatedValue): bool
    {
        return ($this->skipOnEmptyCallback)($validatedValue);
    }

    protected function initSkipOnEmptyProperties(bool $skipOnEmpty = false, ?callable $skipOnEmptyCallback = null): void
    {
        $this->skipOnEmpty = $skipOnEmpty;

        $this->skipOnEmptyCallback = $skipOnEmptyCallback;


        if ($this->skipOnEmptyCallback) {
            if (!is_callable($this->skipOnEmptyCallback)) {
                throw new InvalidArgumentException('$skipOnEmptyCallback must be a callable.');
            }

            $this->skipOnEmpty = true;

            return;
        }

        $this->skipOnEmptyCallback = $this->skipOnEmpty === false ? new SkipNone() : new SkipOnEmpty();
    }

    public function skipOnEmpty(bool $value): self
    {
        $new = clone $this;
        $new->skipOnEmpty = $value;

        $new->initSkipOnEmptyProperties($new->skipOnEmpty);

        return $new;
    }

    public function skipOnEmptyCallback(?callable $value): self
    {
        $new = clone $this;
        $new->skipOnEmptyCallback = $value;

        $new->initSkipOnEmptyProperties(false, $value);

        return $new;
    }

    public function shouldSkipOnError(): bool
    {
        return $this->skipOnError;

    }

    /**
     * @psalm-return Closure(mixed, ValidationContext):bool|null
     *
     * @return Closure|null
     */
    public function getWhen(): ?Closure
    {
        return $this->when;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Validator\Rule\Trait;
6
7		use Closure;
8		use InvalidArgumentException;
9		use Yiisoft\Validator\SkipOnEmptyCallback\SkipNone;
10		use Yiisoft\Validator\SkipOnEmptyCallback\SkipOnEmpty;
11		use Yiisoft\Validator\ValidationContext;
12
13		use function is_callable;
14
15		trait BeforeValidationTrait
16		{
17	24	public function getSkipOnEmpty(): bool
18		{
19	24	return $this->skipOnEmpty;
20		}
21
22	24	public function getSkipOnEmptyCallback(): callable
23		{
24	24	return $this->skipOnEmptyCallback;
25		}
26
27	79	public function shouldSkipOnEmpty(mixed $validatedValue): bool
28		{
29	79	return ($this->skipOnEmptyCallback)($validatedValue);
30		}
31
32	138	protected function initSkipOnEmptyProperties(bool $skipOnEmpty = false, ?callable $skipOnEmptyCallback = null): void
33		{
34	138	$this->skipOnEmpty = $skipOnEmpty;
		0 ignored issues – show Bug Best Practice introduced 2022-08-09 12:33 UTC by Report Bug Copy Issue Report The property `skipOnEmpty` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
35	138	$this->skipOnEmptyCallback = $skipOnEmptyCallback;
		0 ignored issues – show Bug Best Practice introduced 2022-08-09 12:33 UTC by Report Bug Copy Issue Report The property `skipOnEmptyCallback` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
36
37	138	if ($this->skipOnEmptyCallback) {
38	35	if (!is_callable($this->skipOnEmptyCallback)) {
39		throw new InvalidArgumentException('$skipOnEmptyCallback must be a callable.');
40		}
41
42	35	$this->skipOnEmpty = true;
43
44	35	return;
45		}
46
47	138	$this->skipOnEmptyCallback = $this->skipOnEmpty === false ? new SkipNone() : new SkipOnEmpty();
48		}
49
50	35	public function skipOnEmpty(bool $value): self
51		{
52	35	$new = clone $this;
53	35	$new->skipOnEmpty = $value;
		0 ignored issues – show Bug Best Practice introduced 2022-08-15 10:21 UTC by Report Bug Copy Issue Report The property `skipOnEmpty` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
54	35	$new->initSkipOnEmptyProperties($new->skipOnEmpty);
55
56	35	return $new;
57		}
58
59	35	public function skipOnEmptyCallback(?callable $value): self
60		{
61	35	$new = clone $this;
62	35	$new->skipOnEmptyCallback = $value;
		0 ignored issues – show Bug Best Practice introduced 2022-08-09 12:33 UTC by Report Bug Copy Issue Report The property `skipOnEmptyCallback` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
63	35	$new->initSkipOnEmptyProperties(false, $value);
64
65	35	return $new;
66		}
67
68	77	public function shouldSkipOnError(): bool
69		{
70	77	return $this->skipOnError;
		0 ignored issues – show Bug introduced 2022-08-09 12:33 UTC by Report Bug Copy Issue Report The property `skipOnError` does not exist on `Yiisoft\Validator\Rule\Trait\BeforeValidationTrait`. Did you mean `skipOnEmpty`? Loading history...
71		}
72
73		/**
74		* @psalm-return Closure(mixed, ValidationContext):bool\|null
75		*
76		* @return Closure\|null
77		*/
78	76	public function getWhen(): ?Closure
79		{
80	76	return $this->when;
81		}
82		}
83

yiisoft / validator

Pull Request — master (#288)

BeforeValidationTrait::skipOnEmptyCallback() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like